Re: [systemd-devel] [HEADS-UP] It's release time!
On 02/18/2014 01:33 PM, Tom Gundersen wrote: On Tue, Feb 18, 2014 at 1:20 PM, Jan Janssen medhe...@web.de wrote: the *.link files for networkd completely lack documentation. They are documented in udev(8). Let me know if anything is unclear or lacking. And in general, I would say that networkd could benefit from a more detailed man page before this gets released. Anything in particular you feel is unclear or lacking (I'm going through it now anyway, but more input is always better)? Cheers, Tom Hi, I now installed systemd 209 from arch testing and it lacks documentation about resolv.conf. It appears that you're supposed to create your own one or link the one created in /run. This really needs mentioning in the man page of networkd. Jan ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Thu, 2014-02-20 at 02:03 +0100, Lennart Poettering wrote: On Thu, 20.02.14 01:21, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: Even if there can be reasonable style disagreements about exactly where to use mixed declarations, at least some uses of them are certainly beneficial. It's only a matter of getting used to reading them if you've only read old-style code before. I'm sure that if C had had mixed declarations from the beginning, nobody would come up with a coding style which declared that particular feature to be harmful. Given systemd's approach to features, I think it's pretty ironic if its coding style has a you can't expect me to get used to new features attitude to something that's been used for more than a decade. Oh, it's really not like that. We make use of a lot of newer language features all the time. We have have a lot of gccisms in our code, such as the gcc cleanup attribute. And there's already C11 bits in the code, too. I know that some other new features are used. However, I don't believe that the underlying reason behind opposing mixed declarations would be anything other than being used to lack of it and opposing change. However, there are certain language features that we consider obvious improvements and there are others where we are a lot more conservative. It's a matter of taste I figure, it's like tabs vs. spaces. We don't allow tabs either in our sources... And neither do we allow declaration after statements... For indentation style, you have to pick _something_ anyway. But you don't have to randomly forbid some normal language features, and the only reason for people to have such a taste is being used to old-style sources. There is no reason why people would pick out mixed declarations in particular as something to oppose if it was not a newer feature. If C had had mixed declarations from the beginning, but not the - operator, we might have people who are fine mixed declarations but insist that people write (*p).x instead of p-x. Nobody has such a taste now when they haven't become familiar with sources using only such style. We are apparently not alone on this btw, after all gcc *does* have this warning flag support even in C99 and C11 mode... Yes, there are people who still want to avoid that. I think they're quite similar to the people who insist that systemd must be only harmful as sysvinit has worked fine for them 20+ years. That's the reason for my comment about irony above. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
It was 2014-02-18 wto 03:26, when Lennart Poettering wrote: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! --8---cut here---start-8--- $ git checkout b67f562c9cac44bd78b24f5aae78a1797c5d4182 $ git clean -dfx [...] $ ./autogen.sh [...] $ ./configure [...] $ make [...] CC src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_link': src/libsystemd/sd-rtnl/rtnl-message.c:145:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_addr': src/libsystemd/sd-rtnl/rtnl-message.c:219:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:431:38: error: 'IFLA_CARRIER' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:431:38: note: each undeclared identifier is reported only once for each function it appears in src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u32': src/libsystemd/sd-rtnl/rtnl-message.c:514:38: error: 'IFLA_PROMISCUITY' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:515:38: error: 'IFLA_NUM_TX_QUEUES' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:516:38: error: 'IFLA_NUM_RX_QUEUES' undeclared (first use in this function) make[2]: *** [src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 --8---cut here---end---8--- I build on Ubuntu 12.04 so there definitely something may be missing in my system and I would like configure or README to tell me what am I missing? README says I need Linux kernel = 3.0 (= 3.8 for Smack). NEWS mentions 3.5 for /dev/kmsg. However, the undeclared symbols above seem to be introduced later - IFLA_CARRIER - v3.9 - IFLA_NUM_[RT]X_QUEUES - v3.6 - IFLA_PROMISCUITY - v3.5 -- Łukasz Stelmach Samsung RD Institute Poland Samsung Electronics pgpTA_oah7afT.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, Feb 19, 2014 at 12:47 PM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and Lennart Poettering at 18/02/14 02:26 did gyre and gimble: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! So I'm not sure if this is just a product of my package building stuff, but I get a lot more warning during build than I used to, primarily -Wmaybe-uninitialized and -Wdeclaration-after-statement warnings. I'm sure most are harmless but do you know if this is something at my end (compiler, default options etc) that's different for other folks? It doesn't happen for me with 208 with the same environment hence why it looks like some kind of change upstream. I attach both build logs for reference (both have -Wdeclaration-after-statement but neither has -Wmaybe-uninitialized in flags). I think it's all a side effect of link time optimization -lto. Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, Feb 19, 2014 at 12:19 PM, Łukasz Stelmach l.stelm...@samsung.com wrote: It was 2014-02-18 wto 03:26, when Lennart Poettering wrote: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! --8---cut here---start-8--- $ git checkout b67f562c9cac44bd78b24f5aae78a1797c5d4182 $ git clean -dfx [...] $ ./autogen.sh [...] $ ./configure [...] $ make [...] CC src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_link': src/libsystemd/sd-rtnl/rtnl-message.c:145:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_addr': src/libsystemd/sd-rtnl/rtnl-message.c:219:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:431:38: error: 'IFLA_CARRIER' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:431:38: note: each undeclared identifier is reported only once for each function it appears in src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u32': src/libsystemd/sd-rtnl/rtnl-message.c:514:38: error: 'IFLA_PROMISCUITY' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:515:38: error: 'IFLA_NUM_TX_QUEUES' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:516:38: error: 'IFLA_NUM_RX_QUEUES' undeclared (first use in this function) make[2]: *** [src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 --8---cut here---end---8--- I build on Ubuntu 12.04 so there definitely something may be missing in my system and I would like configure or README to tell me what am I missing? README says I need Linux kernel = 3.0 (= 3.8 for Smack). NEWS mentions 3.5 for /dev/kmsg. However, the undeclared symbols above seem to be introduced later - IFLA_CARRIER - v3.9 - IFLA_NUM_[RT]X_QUEUES - v3.6 - IFLA_PROMISCUITY - v3.5 We probably don't want to support such old kernels much longer, but in this case it was easy enough to fix, so I added the defines to missing.h. Please test and let me know if you are still experiencing problems. Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
It was 2014-02-19 śro 15:52, when Tom Gundersen wrote: On Wed, Feb 19, 2014 at 12:19 PM, Łukasz Stelmach l.stelm...@samsung.com wrote: It was 2014-02-18 wto 03:26, when Lennart Poettering wrote: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! --8---cut here---start-8--- $ git checkout b67f562c9cac44bd78b24f5aae78a1797c5d4182 $ git clean -dfx [...] $ ./autogen.sh [...] $ ./configure [...] $ make [...] CC src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_link': src/libsystemd/sd-rtnl/rtnl-message.c:145:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_addr': src/libsystemd/sd-rtnl/rtnl-message.c:219:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:431:38: error: 'IFLA_CARRIER' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:431:38: note: each undeclared identifier is reported only once for each function it appears in src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u32': src/libsystemd/sd-rtnl/rtnl-message.c:514:38: error: 'IFLA_PROMISCUITY' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:515:38: error: 'IFLA_NUM_TX_QUEUES' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:516:38: error: 'IFLA_NUM_RX_QUEUES' undeclared (first use in this function) make[2]: *** [src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 --8---cut here---end---8--- I build on Ubuntu 12.04 so there definitely something may be missing in my system and I would like configure or README to tell me what am I missing? README says I need Linux kernel = 3.0 (= 3.8 for Smack). NEWS mentions 3.5 for /dev/kmsg. However, the undeclared symbols above seem to be introduced later - IFLA_CARRIER - v3.9 - IFLA_NUM_[RT]X_QUEUES - v3.6 - IFLA_PROMISCUITY - v3.5 We probably don't want to support such old kernels much longer, but in this case it was easy enough to fix, so I added the defines to missing.h. Please test and let me know if you are still experiencing problems. src/libsystemd/sd-rtnl/test-rtnl.c needs to #include missing.h -- Łukasz Stelmach Samsung RD Institute Poland Samsung Electronics pgpi_8QKZip4G.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, Feb 19, 2014 at 4:05 PM, Łukasz Stelmach l.stelm...@samsung.com wrote: It was 2014-02-19 śro 15:52, when Tom Gundersen wrote: On Wed, Feb 19, 2014 at 12:19 PM, Łukasz Stelmach l.stelm...@samsung.com wrote: It was 2014-02-18 wto 03:26, when Lennart Poettering wrote: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! --8---cut here---start-8--- $ git checkout b67f562c9cac44bd78b24f5aae78a1797c5d4182 $ git clean -dfx [...] $ ./autogen.sh [...] $ ./configure [...] $ make [...] CC src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_link': src/libsystemd/sd-rtnl/rtnl-message.c:145:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_new_addr': src/libsystemd/sd-rtnl/rtnl-message.c:219:55: warning: declaration of 'index' shadows a global declaration [-Wshadow] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:431:38: error: 'IFLA_CARRIER' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:431:38: note: each undeclared identifier is reported only once for each function it appears in src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u32': src/libsystemd/sd-rtnl/rtnl-message.c:514:38: error: 'IFLA_PROMISCUITY' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:515:38: error: 'IFLA_NUM_TX_QUEUES' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:516:38: error: 'IFLA_NUM_RX_QUEUES' undeclared (first use in this function) make[2]: *** [src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 --8---cut here---end---8--- I build on Ubuntu 12.04 so there definitely something may be missing in my system and I would like configure or README to tell me what am I missing? README says I need Linux kernel = 3.0 (= 3.8 for Smack). NEWS mentions 3.5 for /dev/kmsg. However, the undeclared symbols above seem to be introduced later - IFLA_CARRIER - v3.9 - IFLA_NUM_[RT]X_QUEUES - v3.6 - IFLA_PROMISCUITY - v3.5 We probably don't want to support such old kernels much longer, but in this case it was easy enough to fix, so I added the defines to missing.h. Please test and let me know if you are still experiencing problems. src/libsystemd/sd-rtnl/test-rtnl.c needs to #include missing.h Indeed. Fixed. -t ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, 19.02.14 11:47, Colin Guthrie (gm...@colin.guthr.ie) wrote:
'Twas brillig, and Lennart Poettering at 18/02/14 02:26 did gyre and gimble:
Heya!
It's release time again! It has been more than 4 months now since the
last release. That's kinda emberassing, since we actually intended to go
for a 2-3 week cycle... The big dbus transition took some time however.
Aynway, I just finished a review of the git history, marked backportable
fixes, and put together the NEWS.
Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a
release? I'd like to roll the release tomorrow (tuesday) or
wednesday. Please have a closer look and test!
So I'm not sure if this is just a product of my package building stuff,
but I get a lot more warning during build than I used to, primarily
-Wmaybe-uninitialized and -Wdeclaration-after-statement warnings.
I'm sure most are harmless but do you know if this is something at my
end (compiler, default options etc) that's different for other folks?
It doesn't happen for me with 208 with the same environment hence why it
looks like some kind of change upstream.
I attach both build logs for reference (both have
-Wdeclaration-after-statement but neither has -Wmaybe-uninitialized in
flags).
src/libsystemd/sd-bus/bus-kernel.c: In function 'bus_message_setup_kmsg':
src/libsystemd/sd-bus/bus-kernel.c:230:9: warning: ISO C90 forbids mixed
declarations and code [-Wdeclaration-after-statement]
assert_cc(ALIGN8(offsetof(struct kdbus_item, vec) +
sizeof(struct kdbus_vec)) ==
This one happens if you don't have a compiler/libc that supports C11
static fallbacks. We then emulate them with an array definition, which
however gcc then complains about because we mix it with
-Wdeclaration-after-statement.
If have gcc (GCC) 4.8.2 20131212 (Red Hat 4.8.2-7) and glibc
2.18 where C11 static asserts work fine, and where the warning is hence
not generated.
Zbigniew suggest we should drop -Wdeclaration-after-statement. I am not
convinced that that would be a good idea since generally declarations
after statements are an abomination, and we should avoid them, and it is
nice if gcc warns about that. I am open to dropping the warning though
with a gcc pragma in case we are compiled on an old system that lacks
C11 static asserts. But then again, I am not sure it's worth it...
src/libsystemd/sd-bus/bus-message.c: In function
'sd_bus_message_open_container':
src/libsystemd/sd-bus/bus-message.c:1917:18: warning: 'begin' may be used
uninitialized in this function [-Wmaybe-uninitialized]
w-begin = begin;
Fixed this one. But you could as well ignore it...
/usr/include/bits/poll2.h: In function 'bus_poll':
/usr/include/bits/poll2.h:71:2: warning: call to '__ppoll_chk_warn' declared
with attribute warning: ppoll called with fds buffer too small file nfds
entries [enabled by default]
return __ppoll_chk (__fds, __nfds, __timeout, __ss, __bos (__fds));
^
This one I really don't grok, and the code looks totally fine...
src/journal/cat.c: In function 'main':
src/shared/util.c:5906:23: warning: 'buf' may be used uninitialized in this
function [-Wmaybe-uninitialized]
char *buf, *p;
Fixed this one, but doesn't matter...
src/journal/sd-journal.c: In function 'add_file':
src/journal/sd-journal.c:1304:11: warning: 'f' may be used uninitialized in
this function [-Wmaybe-uninitialized]
r = hashmap_put(j-files, f-path, f);
^
Same...
src/shared/acpi-fpdt.c: In function 'acpi_get_boot_usec':
src/shared/acpi-fpdt.c:102:12: warning: 'l' may be used uninitialized in this
function [-Wmaybe-uninitialized]
if (l != tbl-length)
^
src/shared/acpi-fpdt.c:86:16: note: 'l' was declared here
size_t l;
Same...
src/shared/efivars.c: In function 'read_usec.isra.2':
src/shared/efivars.c:409:12: warning: 'x' may be used uninitialized in this
function [-Wmaybe-uninitialized]
*u = x;
^
Same...
src/shared/utf8.c:226:44: warning: 'ss' may be used uninitialized in this
function [-Wmaybe-uninitialized]
for (f = s; f (const uint8_t*) s + length; f += 2) {
^
src/shared/efivars.c:133:16: note: 'ss' was declared here
size_t ss;
Same...
src/libsystemd/sd-bus/bus-control.c: In function 'sd_bus_get_owner':
src/libsystemd/sd-bus/bus-control.c:710:494: warning: 'p' may be used
uninitialized in this function [-Wmaybe-uninitialized]
c-label = strndup(p, sz);
Same...
CCLD test-date
CCLD test-namespace
CCLD test-replace-var
CCLD test-sleep
src/shared/sleep-config.c: In function 'can_sleep':
src/shared/sleep-config.c:245:54: warning: 'used' may be used uninitialized
in this function [-Wmaybe-uninitialized]
log_debug(Hibernation is %spossible, Active(anon)=%llu kB, size=%zu
kB, used=%zu
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, Feb 19, 2014 at 5:53 PM, Lennart Poettering lenn...@poettering.net wrote: Please try to rebuild things again. You should still see some noise, but much less. Can you post your results again? This should show it for you too: $ make -j8 distcheck Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
The only thing in master I'm still having to patch in production is the is-enabled code path so it doesn't look up all the symlinks. I don't see that as a release blocker, though. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, 19.02.14 10:53, David Timothy Strauss (da...@davidstrauss.net) wrote: The only thing in master I'm still having to patch in production is the is-enabled code path so it doesn't look up all the symlinks. I don't see that as a release blocker, though. David, did you see the changes I made to the cgroup mask propagation bits? I reworked some code there to make sure that the mask doesn't keep increasing, but actually can lose bits again if cgroup properties are unset. Now, as far as I can see I didn't break your scalibility changes, but I was wondering if you could give this a test run with your huge number of units setup? Thanks! Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, Feb 19, 2014 at 10:57 AM, Lennart Poettering lenn...@poettering.net wrote: did you see the changes I made to the cgroup mask propagation bits? I reworked some code there to make sure that the mask doesn't keep increasing, but actually can lose bits again if cgroup properties are unset. Now, as far as I can see I didn't break your scalibility changes, but I was wondering if you could give this a test run with your huge number of units setup? I actually hadn't noticed them yet. I looked at them just now, and it seems like the running time should be identical if controllers don't get removed (and longer but actually correct if they do). I'll test out master on a VM to ensure there's no major performance regression. There's nothing complicated happening in our production environment with cgroups and parents that I can't replicate on a test machine. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, 19.02.14 19:43, Colin Guthrie (gm...@colin.guthr.ie) wrote: 'Twas brillig, and Lennart Poettering at 19/02/14 16:53 did gyre and gimble: Soo, pretty much all of these are false positives triggered by -flto. Before adding -flto we only got these fals positives within source files, now we ge them across source files. We usually just patched these issues away by initializing variables where initialization wasn't really necessary. I did the same now for all of these. Please try to rebuild things again. You should still see some noise, but much less. Can you post your results again? Thanks for that. I did remember reading some posts about compilers so figured they were all down to that but nice that an actual bug was found too. Here's the results with 8f61afd. Are you sure you updated this properly? The warnings include lines of codes that don't even look like that anymore... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, Feb 19, 2014 at 10:57 AM, Lennart Poettering lenn...@poettering.net wrote: Now, as far as I can see I didn't break your scalibility changes, but I was wondering if you could give this a test run with your huge number of units setup? With 4000 units (2000 sockets and 2000 corresponding services with CPUShares= enabled), Fedora 20 boots fine on master. Fedora 20's normal systemd v208 *does not* boot fine with that number of units, especially with controllers in use. I'm 99% sure your changes don't introduce any performance regression. And, based on my reading of the changes, I'm 100% sure that any regression we might find later would be solvable with a simple, backportable patch. In an unrelated note, I'm not sure if we can fix the Failed to get D-Bus connection: Failed to connect to socket /run/systemd/private: No such file or directory stuff or make it less noisy. IIRC, that goes away with kdbus, but it will be a while before that's in general use. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, 2014-02-19 at 17:53 +0100, Lennart Poettering wrote: Zbigniew suggest we should drop -Wdeclaration-after-statement. I am not convinced that that would be a good idea since generally declarations after statements are an abomination, and we should avoid them, and it is nice if gcc warns about that. Even if there can be reasonable style disagreements about exactly where to use mixed declarations, at least some uses of them are certainly beneficial. It's only a matter of getting used to reading them if you've only read old-style code before. I'm sure that if C had had mixed declarations from the beginning, nobody would come up with a coding style which declared that particular feature to be harmful. Given systemd's approach to features, I think it's pretty ironic if its coding style has a you can't expect me to get used to new features attitude to something that's been used for more than a decade. BTW I looked at the CODING_STYLE file and there's a factual error: 'Processors speak double natively anyway' is not true for SSE math, which is normally used for all math operations on AMD64. SSE has separate operations for floats and doubles, and doubles can be slower. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Thu, Feb 20, 2014 at 01:21:01AM +0200, Uoti Urpala wrote: On Wed, 2014-02-19 at 17:53 +0100, Lennart Poettering wrote: Zbigniew suggest we should drop -Wdeclaration-after-statement. I am not convinced that that would be a good idea since generally declarations after statements are an abomination, and we should avoid them, and it is nice if gcc warns about that. Even if there can be reasonable style disagreements about exactly where to use mixed declarations, at least some uses of them are certainly beneficial. It's only a matter of getting used to reading them if you've only read old-style code before. I'm sure that if C had had mixed declarations from the beginning, nobody would come up with a coding style which declared that particular feature to be harmful. Given systemd's approach to features, I think it's pretty ironic if its coding style has a you can't expect me to get used to new features attitude to something that's been used for more than a decade. For a language with a garbage collection mechanism, it's easy to write declarations and forget about them... but for C the human is the one who will find them and do the job... Even if systemd uses GCC __attribute__ ((cleanup)) (this is a new feature) IMHO we still need that flag. -- Djalal Harouni http://opendz.org ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Wed, 19.02.14 21:54, Colin Guthrie (gm...@colin.guthr.ie) wrote: Thanks for that. I did remember reading some posts about compilers so figured they were all down to that but nice that an actual bug was found too. Here's the results with 8f61afd. Are you sure you updated this properly? The warnings include lines of codes that don't even look like that anymore... Hmm, fairly sure... although I do have some downsteam patches of course as this is just from our RPM which will be clouding some things. I'll attach a build log without patches as off dd8875f93 (the final RPM creation fails without the patches but the actual code compiles fine and should be purely upstream) YUpp, this one looks much more like it. All the warnings are gone now except the ppoll and static assert things. Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Thu, 20.02.14 01:21, Uoti Urpala (uoti.urp...@pp1.inet.fi) wrote: On Wed, 2014-02-19 at 17:53 +0100, Lennart Poettering wrote: Zbigniew suggest we should drop -Wdeclaration-after-statement. I am not convinced that that would be a good idea since generally declarations after statements are an abomination, and we should avoid them, and it is nice if gcc warns about that. Even if there can be reasonable style disagreements about exactly where to use mixed declarations, at least some uses of them are certainly beneficial. It's only a matter of getting used to reading them if you've only read old-style code before. I'm sure that if C had had mixed declarations from the beginning, nobody would come up with a coding style which declared that particular feature to be harmful. Given systemd's approach to features, I think it's pretty ironic if its coding style has a you can't expect me to get used to new features attitude to something that's been used for more than a decade. Oh, it's really not like that. We make use of a lot of newer language features all the time. We have have a lot of gccisms in our code, such as the gcc cleanup attribute. And there's already C11 bits in the code, too. However, there are certain language features that we consider obvious improvements and there are others where we are a lot more conservative. It's a matter of taste I figure, it's like tabs vs. spaces. We don't allow tabs either in our sources... And neither do we allow declaration after statements... We are apparently not alone on this btw, after all gcc *does* have this warning flag support even in C99 and C11 mode... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On 02/18/2014 05:03 AM, Zbigniew Jędrzejewski-Szmek wrote: A related question is wheter Fedora should get this release in rawhide: I think yes, but with --disable-kdbus --enable-compat-libs. It's nice thathttps://bugzilla.redhat.com/show_bug.cgi?id=1065572 got fixed just in time. Rawhide is the place for breakage and we want to catch any related bugs sooner rather then later so why disable kdbus? JBG ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, Feb 18, 2014 at 10:57:23AM +, Jóhann B. Guðmundsson wrote: On 02/18/2014 05:03 AM, Zbigniew Jędrzejewski-Szmek wrote: A related question is wheter Fedora should get this release in rawhide: I think yes, but with --disable-kdbus --enable-compat-libs. It's nice thathttps://bugzilla.redhat.com/show_bug.cgi?id=1065572 got fixed just in time. Rawhide is the place for breakage and we want to catch any related bugs sooner rather then later so why disable kdbus? Because it is not in upstream kernel, therefore not in rawhide. -- Tomasz .. oo o. oo o. .o .o o. o. oo o. .. Torcz.. .o .o .o .o oo oo .o .. .. oo oo o.o.o. .o .. o. o. o. o. o. o. oo .. .. o. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, Feb 18, 2014 at 6:03 AM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Tue, Feb 18, 2014 at 03:26:35AM +0100, Lennart Poettering wrote: It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Hi, please give it a week to mature. This is a great release and a lot of people are waiting for it. But there are certainly small bugs left... and a week of testing and bug-fix-only commits would be beneficial, imho. There will be more releases coming soon after release, I expect. :) Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, Feb 18, 2014 at 11:57 AM, Jóhann B. Guðmundsson johan...@gmail.com wrote: On 02/18/2014 05:03 AM, Zbigniew Jędrzejewski-Szmek wrote: A related question is wheter Fedora should get this release in rawhide: I think yes, but with --disable-kdbus --enable-compat-libs. It's nice thathttps://bugzilla.redhat.com/show_bug.cgi?id=1065572 got fixed just in time. Rawhide is the place for breakage and we want to catch any related bugs sooner rather then later so why disable kdbus? It is completely insecure and work-in-progress, the API is not finished, the kernel side not generally available. Kdbus in systemd is useless and cannot be tested without the kernel module. We will still change the kernel module API, so any change in a newer systemd, or the kernel, will render the machine using kdbus unbootable. It is really no stuff a distribution should ship at this moment. make install for systemd is as easy to do as the make install of the kernel module, for people who want to play with kdbus. Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On 02/18/2014 03:26 AM, Lennart Poettering wrote: It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Is there a way I can help with testing? I am not a systemd guru, but if there is a (simple) way I could help with testing, I would not mind. I work with openSUSE, but I could install other distributions in a VirtualBox. Met vriendelijke groet, Cecil Westerhof Engineer mobiel +31 - 6 - 25 00 38 81 -- Snow B.V. Unix Specialists De Ooyen 11 4191 PB Geldermalsen http://www.snow.nl tel. +31 - 345 - 65 66 66 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, Feb 18, 2014 at 1:20 PM, Jan Janssen medhe...@web.de wrote: the *.link files for networkd completely lack documentation. They are documented in udev(8). Let me know if anything is unclear or lacking. And in general, I would say that networkd could benefit from a more detailed man page before this gets released. Anything in particular you feel is unclear or lacking (I'm going through it now anyway, but more input is always better)? Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, 18.02.14 06:03, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Hi, please give it a week to mature. This is a great release and a lot of people are waiting for it. But there are certainly small bugs left... and a week of testing and bug-fix-only commits would be beneficial, imho. I think I'd prefer simply doing a release that we declare as one of those people shouldn't base their LTS distros on, and then quickly doing follow-up releases. We should try hard to get much faster with releases again. A related question is wheter Fedora should get this release in rawhide: I think yes, but with --disable-kdbus --enable-compat-libs. It's nice that https://bugzilla.redhat.com/show_bug.cgi?id=1065572 got fixed just in time. Hmm, I wonder if we should just do the work and rebuild all packages that use the old libraries and then disable the compat libs in the RPM. But then again, I am a very lazy person But yeah, it is definitely my intention to upload this to rawhide quickly with --disable-kdbus set. Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, 18.02.14 12:26, Cecil Westerhof (cecil.wester...@snow.nl) wrote: On 02/18/2014 03:26 AM, Lennart Poettering wrote: It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Is there a way I can help with testing? I am not a systemd guru, but if there is a (simple) way I could help with testing, I would not mind. You can build systemd from the git tree and just install it over your RPM supplied systemd version, but if you do that you really should know what you are doing, and if you are not sure, better step away. Other than that please wait for your distribution to provide RPMs for testing. For example, on Fedora there's Rawhide that provides these usually quickly. Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On 02/18/2014 02:00 PM, Lennart Poettering wrote: It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Is there a way I can help with testing? I am not a systemd guru, but if there is a (simple) way I could help with testing, I would not mind. You can build systemd from the git tree and just install it over your RPM supplied systemd version, but if you do that you really should know what you are doing, and if you are not sure, better step away. Then I should step away. But on the other hand, I could just create VM's. If they bomb out: no problem. Met vriendelijke groet, Cecil Westerhof Engineer mobiel +31 - 6 - 25 00 38 81 -- Snow B.V. Unix Specialists De Ooyen 11 4191 PB Geldermalsen http://www.snow.nl tel. +31 - 345 - 65 66 66 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
Gesendet: Dienstag, 18. Februar 2014 um 13:33 Uhr Von: Tom Gundersen t...@jklm.no An: Jan Janssen medhe...@web.de Cc: systemd Mailing List systemd-devel@lists.freedesktop.org Betreff: Re: [systemd-devel] [HEADS-UP] It's release time! On Tue, Feb 18, 2014 at 1:20 PM, Jan Janssen medhe...@web.de wrote: the *.link files for networkd completely lack documentation. They are documented in udev(8). Let me know if anything is unclear or lacking. Ah, thanks. This really needs a proper mention/link in systemd-networkd manpage or put there instead, the inexpressive udev(7) reference at the end is not enough. When poeple are reading up on networkd, they will not expect this information to be in the udev manpage, even though the implementation of this is (rightfully) located in udev. And in general, I would say that networkd could benefit from a more detailed man page before this gets released. Anything in particular you feel is unclear or lacking (I'm going through it now anyway, but more input is always better)? Nothing in particular. From reading it - and now that I know out about the .link files - I (and others in general) would be able to use it for my purposes right away. I was more thinking on the lines of a condensed down version of your G+ posts on networkd in its manpage. Mainly how it is supposed to work (the big picture), how it interacts with NetworkManager et.al., and also what it currently does not provide/is lacking. And maybe some examples on different set ups, since those are always nice in a manpage to know that you're not doing it wrongly and give you a warm fuzzy feeling :D Jan ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
Hi, On Tue, 2014-02-18 at 03:26 +0100, Lennart Poettering wrote: Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! I'm fine with the DHCP state of affairs and all the hard work from Tom. I (finally!) created an initial client side test case that should have hit the mailing list already. If that one still makes it to the release, I'm more than happy! Cheers, Patrik ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
2014-02-18 3:26 GMT+01:00 Lennart Poettering lenn...@poettering.net: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! I'm running into test-suite failures with current git master. I'm basically running git clean -xdf ./autogen.sh g make make check this results in .. ./build-aux/test-driver: line 107: 17839 Aborted $@ $log_file 21 FAIL: test-cgroup-mask .. Testsuite summary for systemd 208 # TOTAL: 74 # PASS: 68 # SKIP: 5 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 See ./test-suite.log Please report to http://bugs.freedesktop.org/enter_bug.cgi?product=systemd make[4]: *** [test-suite.log] Error 1 make[3]: *** [check-TESTS] Error 2 make[2]: *** [check-am] Error 2 make[1]: *** [check-recursive] Error 1 make: *** [check] Error 2 What's interesting, running (as root) sudo make check I get two failing tests: ./build-aux/test-driver: line 107: 18426 Aborted $@ $log_file 21 FAIL: test-unit-name ./build-aux/test-driver: line 107: 18519 Aborted $@ $log_file 21 FAIL: test-cgroup-mask and the test-suite gets stuck in /usr/bin/perl ./test/udev-test.pl -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
2014-02-18 18:36 GMT+01:00 Michael Biebl mbi...@gmail.com: What's interesting, running (as root) sudo make check I get two failing tests: ./build-aux/test-driver: line 107: 18426 Aborted $@ $log_file 21 FAIL: test-unit-name ./build-aux/test-driver: line 107: 18519 Aborted $@ $log_file 21 FAIL: test-cgroup-mask and the test-suite gets stuck in /usr/bin/perl ./test/udev-test.pl Small correction. Letting the test/udev-test.pl test run for a few minutes, it finally fails, leading to Testsuite summary for systemd 208 # TOTAL: 74 # PASS: 65 # SKIP: 6 # XFAIL: 0 # FAIL: 3 # XPASS: 0 # ERROR: 0 See ./test-suite.log Please report to http://bugs.freedesktop.org/enter_bug.cgi?product=systemd make[4]: *** [test-suite.log] Error 1 make[3]: *** [check-TESTS] Error 2 make[2]: *** [check-am] Error 2 make[1]: *** [check-recursive] Error 1 make: *** [check] Error 2 -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, 18.02.14 18:36, Michael Biebl (mbi...@gmail.com) wrote: 2014-02-18 3:26 GMT+01:00 Lennart Poettering lenn...@poettering.net: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! I'm running into test-suite failures with current git master. I'm basically running git clean -xdf ./autogen.sh g make make check this results in .. ./build-aux/test-driver: line 107: 17839 Aborted $@ $log_file 21 FAIL: test-cgroup-mask Hmm, the fialing tests all require write access to the cgroupfs, and if they don't get they get automatically skipped. Are you running this as root? If you run test-cgroup-mask on the command line, how does it fail, can you paste the output? Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [HEADS-UP] It's release time!
Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Thanks! Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [HEADS-UP] It's release time!
On Tue, Feb 18, 2014 at 03:26:35AM +0100, Lennart Poettering wrote: Heya! It's release time again! It has been more than 4 months now since the last release. That's kinda emberassing, since we actually intended to go for a 2-3 week cycle... The big dbus transition took some time however. Aynway, I just finished a review of the git history, marked backportable fixes, and put together the NEWS. Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a release? I'd like to roll the release tomorrow (tuesday) or wednesday. Please have a closer look and test! Hi, please give it a week to mature. This is a great release and a lot of people are waiting for it. But there are certainly small bugs left... and a week of testing and bug-fix-only commits would be beneficial, imho. I'd like to test seat hot-plugging and removal, but the necessary usb device at work, and I won't be able to do it before Wednesday. A related question is wheter Fedora should get this release in rawhide: I think yes, but with --disable-kdbus --enable-compat-libs. It's nice that https://bugzilla.redhat.com/show_bug.cgi?id=1065572 got fixed just in time. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
