Re: [systemd-devel] [PATCH] Report aa_change_onexec error code

2014-10-24 Thread Tom Gundersen 
Applied. Thanks!

Tom

On Sat, Oct 11, 2014 at 10:13 AM,  m...@zarb.org wrote:
 From: Michael Scherer m...@zarb.org

 Since aa_change_onexec return the error code in errno, and return
 -1, the current code do not give any useful information when
 something fail. This make apparmor easier to debug, as seen on
 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760526
 ---
  src/core/execute.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/core/execute.c b/src/core/execute.c
 index 8b9bb27..b165b33 100644
 --- a/src/core/execute.c
 +++ b/src/core/execute.c
 @@ -1698,7 +1698,7 @@ static int exec_child(ExecCommand *command,
  err = aa_change_onexec(context-apparmor_profile);
  if (err  0  !context-apparmor_profile_ignore) {
  *error = EXIT_APPARMOR_PROFILE;
 -return err;
 +return -errno;
  }
  }
  #endif
 --
 1.8.3.1

 ___
 systemd-devel mailing list
 systemd-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/systemd-devel
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] Report aa_change_onexec error code

2014-10-11 Thread misc 
From: Michael Scherer m...@zarb.org

Since aa_change_onexec return the error code in errno, and return
-1, the current code do not give any useful information when
something fail. This make apparmor easier to debug, as seen on
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=760526
---
 src/core/execute.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/execute.c b/src/core/execute.c
index 8b9bb27..b165b33 100644
--- a/src/core/execute.c
+++ b/src/core/execute.c
@@ -1698,7 +1698,7 @@ static int exec_child(ExecCommand *command,
 err = aa_change_onexec(context-apparmor_profile);
 if (err  0  !context-apparmor_profile_ignore) {
 *error = EXIT_APPARMOR_PROFILE;
-return err;
+return -errno;
 }
 }
 #endif
-- 
1.8.3.1

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel