[systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
Ensure to start getty programs on all essential system consoles on Linux on
System z. Add these essential devices to the list of virtualization_consoles
to always generate getty configurations.
For the sake of completion, the list of essential consoles is:
/dev/sclp_line0 - Operating system messages applet (LPAR)
/dev/ttysclp0 - Integrated ASCII console applet (z/VM and LPAR)
/dev/ttyS0 - Already handled by systemd (3215 console on z/VM)
/dev/hvc0 - Already handled by systemd (IUCV HVC terminal on z/VM)
Depending on the environment, z/VM or LPAR, only a subset of these terminals
are available.
See also RH BZ 860158[1] "Cannot login via Operating System Console into RHEL7
instance installed on a LPAR". This bugzilla actually blocks the installation
of Linux on System z instances in LPAR mode.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=860158
---
rules/99-systemd.rules.in |2 +-
src/getty-generator/getty-generator.c |4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/rules/99-systemd.rules.in b/rules/99-systemd.rules.in
index 0923de5..021359a 100644
--- a/rules/99-systemd.rules.in
+++ b/rules/99-systemd.rules.in
@@ -7,7 +7,7 @@
ACTION=="remove", GOTO="systemd_end"
-SUBSYSTEM=="tty", KERNEL=="tty[a-zA-Z]*|hvc*|xvc*|hvsi*", TAG+="systemd"
+SUBSYSTEM=="tty", KERNEL=="tty[a-zA-Z]*|hvc*|xvc*|hvsi*|ttysclp*|sclp_line*",
TAG+="systemd"
KERNEL=="vport*", TAG+="systemd"
diff --git a/src/getty-generator/getty-generator.c
b/src/getty-generator/getty-generator.c
index aeb6d71..f352a29 100644
--- a/src/getty-generator/getty-generator.c
+++ b/src/getty-generator/getty-generator.c
@@ -97,7 +97,9 @@ int main(int argc, char *argv[]) {
static const char virtualization_consoles[] =
"hvc0\0"
"xvc0\0"
-"hvsi0\0";
+"hvsi0\0"
+"sclp_line0\0"
+"ttysclp0\0";
_cleanup_free_ char *active = NULL;
const char *j;
--
1.7.5.4
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
Dne 31.1.2014 17:08, Hendrik Brueckner napsal(a):
Ensure to start getty programs on all essential system consoles on Linux on
System z. Add these essential devices to the list of virtualization_consoles
to always generate getty configurations.
For the sake of completion, the list of essential consoles is:
/dev/sclp_line0 - Operating system messages applet (LPAR)
/dev/ttysclp0 - Integrated ASCII console applet (z/VM and LPAR)
/dev/ttyS0 - Already handled by systemd (3215 console on z/VM)
/dev/hvc0 - Already handled by systemd (IUCV HVC terminal on z/VM)
Depending on the environment, z/VM or LPAR, only a subset of these terminals
are available.
See also RH BZ 860158[1] "Cannot login via Operating System Console into RHEL7
instance installed on a LPAR". This bugzilla actually blocks the installation
of Linux on System z instances in LPAR mode.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=860158
---
rules/99-systemd.rules.in |2 +-
src/getty-generator/getty-generator.c |4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/rules/99-systemd.rules.in b/rules/99-systemd.rules.in
index 0923de5..021359a 100644
--- a/rules/99-systemd.rules.in
+++ b/rules/99-systemd.rules.in
@@ -7,7 +7,7 @@
ACTION=="remove", GOTO="systemd_end"
-SUBSYSTEM=="tty", KERNEL=="tty[a-zA-Z]*|hvc*|xvc*|hvsi*", TAG+="systemd"
+SUBSYSTEM=="tty", KERNEL=="tty[a-zA-Z]*|hvc*|xvc*|hvsi*|ttysclp*|sclp_line*",
TAG+="systemd"
KERNEL=="vport*", TAG+="systemd"
diff --git a/src/getty-generator/getty-generator.c
b/src/getty-generator/getty-generator.c
index aeb6d71..f352a29 100644
--- a/src/getty-generator/getty-generator.c
+++ b/src/getty-generator/getty-generator.c
@@ -97,7 +97,9 @@ int main(int argc, char *argv[]) {
static const char virtualization_consoles[] =
"hvc0\0"
"xvc0\0"
-"hvsi0\0";
+"hvsi0\0"
+"sclp_line0\0"
+"ttysclp0\0";
_cleanup_free_ char *active = NULL;
const char *j;
Thanks! Applied.
Lukas
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Mon, Feb 03, 2014 at 03:07:04PM +0100, Hendrik Brueckner wrote: > On Mon, Feb 03, 2014 at 02:44:43PM +0100, Hannes Reinecke wrote: > > > But that's not a requirement anywhere in the console code. > > Quite the contrary; tty drivers have the 'first_minor' entry > > to explicit request an offset other than '0'. > > > > (And the console driver has an explict '->device' callback > > which allows the tty driver to return the correct index. > > Not that it's used here; would've been too easy). > > > > So how to fix this? > > Update the driver to adhere to the (broken) current behaviour? > > Or modify 'active' to return the corrent tty name? > > That's probably a good option but might break existing applications that rely > on what is in "active". Alternatively add a new sysfs attribute to display > console's associated terminal devices. > > ... or don't look at the console at all and start getty's on those terminal > devices that are available. Just to say it: there already is a /proc/consoles which does show the active devices of the system console. As the name of the console driver ans the index is not unique also the major and minor of the active decvices are shown. > > Or add a workaround to systemd? The /proc/consoles is not a sysfs attribute. Werner -- "Having a smoking section in a restaurant is like having a peeing section in a swimming pool." -- Edward Burr pgpv6gYWsZ42W.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On 01/31/2014 05:08 PM, Hendrik Brueckner wrote: > Ensure to start getty programs on all essential system consoles on Linux on > System z. Add these essential devices to the list of virtualization_consoles > to always generate getty configurations. > > For the sake of completion, the list of essential consoles is: > > /dev/sclp_line0 - Operating system messages applet (LPAR) > /dev/ttysclp0 - Integrated ASCII console applet (z/VM and LPAR) > /dev/ttyS0 - Already handled by systemd (3215 console on z/VM) > /dev/hvc0 - Already handled by systemd (IUCV HVC terminal on z/VM) > > Depending on the environment, z/VM or LPAR, only a subset of these terminals > are available. > > See also RH BZ 860158[1] "Cannot login via Operating System Console into RHEL7 > instance installed on a LPAR". This bugzilla actually blocks the installation > of Linux on System z instances in LPAR mode. > Hehe. Nice try, but sadly incomplete. When switching to a real 3270 console (try 'conmode=3270' on the kernel command line) systemd isn't able to open a console, either. Which opens up a can of worms: - The S/390 3270 tty device is using a device node /dev/3270/ttyX _and_ an offset '1' to the minor node. So the first tty here is in fact /dev/3270/tty1 - systemd is using the 'active' sysfs attribute in /sys/class/tty/console to figure out the active console; for the 3270 console this contains the string 'tty32700'. Which of course doesn't exist and confuses systemd getty-generator. The reason for the slightly weird string in 'active' is the way it's generated (check drivers/tty/tty_io.c:show_cons_active()): count += sprintf(buf + count, "%s%d%c", cs[i]->name, cs[i]->index, i ? ' ':'\n'); where 'cs' is the _console_ structure, not the tty structure. So we're getting the _console_ name plus the _console_ index here. And the console name for the 3270 console is 'tty3270', with the index '0'. Which raises the question: what exactly should be 'active' contain? The console name (which doesn't have any equivalent in sysfs), or the tty name (which has)? And, more importantly, how is one supposed to _find_ the corresponding sysfs entry for the current 'active' attribute? >From what I've seen most driver work by virtue of the happy accident that the console index equals the tty index. But that's not a requirement anywhere in the console code. Quite the contrary; tty drivers have the 'first_minor' entry to explicit request an offset other than '0'. (And the console driver has an explict '->device' callback which allows the tty driver to return the correct index. Not that it's used here; would've been too easy). So how to fix this? Update the driver to adhere to the (broken) current behaviour? Or modify 'active' to return the corrent tty name? Or add a workaround to systemd? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Mon, Feb 03, 2014 at 02:44:43PM +0100, Hannes Reinecke wrote: > On 01/31/2014 05:08 PM, Hendrik Brueckner wrote: > > Ensure to start getty programs on all essential system consoles on Linux on > > System z. Add these essential devices to the list of > > virtualization_consoles > > to always generate getty configurations. > > > > For the sake of completion, the list of essential consoles is: > > > > /dev/sclp_line0 - Operating system messages applet (LPAR) > > /dev/ttysclp0 - Integrated ASCII console applet (z/VM and LPAR) > > /dev/ttyS0 - Already handled by systemd (3215 console on z/VM) > > /dev/hvc0 - Already handled by systemd (IUCV HVC terminal on z/VM) > > > > Depending on the environment, z/VM or LPAR, only a subset of these terminals > > are available. > > > > See also RH BZ 860158[1] "Cannot login via Operating System Console into > > RHEL7 > > instance installed on a LPAR". This bugzilla actually blocks the > > installation > > of Linux on System z instances in LPAR mode. > > > Hehe. > > Nice try, but sadly incomplete. > > When switching to a real 3270 console (try 'conmode=3270' on the > kernel command line) systemd isn't able to open a console, either. You are right. This change is incomplete regarding support for the 3270 terminals. > Which opens up a can of worms: > > - The S/390 3270 tty device is using a device node > /dev/3270/ttyX _and_ an offset '1' to the minor node. > So the first tty here is in fact /dev/3270/tty1 So this requires yet another entry to the systemd rules file to tag 3270 terminal devices. > - systemd is using the 'active' sysfs attribute in > /sys/class/tty/console to figure out the active > console; for the 3270 console this contains the string > 'tty32700'. > Which of course doesn't exist and confuses systemd > getty-generator. > > The reason for the slightly weird string in 'active' is the way it's > generated (check drivers/tty/tty_io.c:show_cons_active()): > count += sprintf(buf + count, "%s%d%c", >cs[i]->name, cs[i]->index, i ? ' ':'\n'); > > where 'cs' is the _console_ structure, not the tty structure. > So we're getting the _console_ name plus the _console_ index here. > And the console name for the 3270 console is 'tty3270', with the > index '0'. >From the source code this simply states the name of the console device. The console device is not say *anything* about a potential associated terminal device. Console names (console= kernel parameter) are just identifiers. > > Which raises the question: what exactly should be 'active' contain? > The console name (which doesn't have any equivalent in sysfs), or > the tty name (which has)? > > And, more importantly, how is one supposed to _find_ the > corresponding sysfs entry for the current 'active' attribute? Perhaps it's time for a new sysfs attribute to display the associated terminal device (if any). > > From what I've seen most driver work by virtue of the happy accident > that the console index equals the tty index. This is just naming... you can also develop a console without any terminal device involved. > But that's not a requirement anywhere in the console code. > Quite the contrary; tty drivers have the 'first_minor' entry > to explicit request an offset other than '0'. > > (And the console driver has an explict '->device' callback > which allows the tty driver to return the correct index. > Not that it's used here; would've been too easy). > > So how to fix this? > Update the driver to adhere to the (broken) current behaviour? > Or modify 'active' to return the corrent tty name? That's probably a good option but might break existing applications that rely on what is in "active". Alternatively add a new sysfs attribute to display console's associated terminal devices. ... or don't look at the console at all and start getty's on those terminal devices that are available. > Or add a workaround to systemd? Kind regards, Hendrik ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Mon, Feb 3, 2014 at 2:44 PM, Hannes Reinecke wrote: > On 01/31/2014 05:08 PM, Hendrik Brueckner wrote: >> Ensure to start getty programs on all essential system consoles on Linux on >> System z. Add these essential devices to the list of virtualization_consoles >> to always generate getty configurations. >> >> For the sake of completion, the list of essential consoles is: >> >> /dev/sclp_line0 - Operating system messages applet (LPAR) >> /dev/ttysclp0 - Integrated ASCII console applet (z/VM and LPAR) >> /dev/ttyS0 - Already handled by systemd (3215 console on z/VM) >> /dev/hvc0 - Already handled by systemd (IUCV HVC terminal on z/VM) >> >> Depending on the environment, z/VM or LPAR, only a subset of these terminals >> are available. >> >> See also RH BZ 860158[1] "Cannot login via Operating System Console into >> RHEL7 >> instance installed on a LPAR". This bugzilla actually blocks the >> installation >> of Linux on System z instances in LPAR mode. >> > Hehe. > > Nice try, but sadly incomplete. > > When switching to a real 3270 console (try 'conmode=3270' on the > kernel command line) systemd isn't able to open a console, either. > > Which opens up a can of worms: > > - The S/390 3270 tty device is using a device node > /dev/3270/ttyX _and_ an offset '1' to the minor node. > So the first tty here is in fact /dev/3270/tty1 > - systemd is using the 'active' sysfs attribute in > /sys/class/tty/console to figure out the active > console; for the 3270 console this contains the string > 'tty32700'. > Which of course doesn't exist and confuses systemd > getty-generator. > > The reason for the slightly weird string in 'active' is the way it's > generated (check drivers/tty/tty_io.c:show_cons_active()): > count += sprintf(buf + count, "%s%d%c", > cs[i]->name, cs[i]->index, i ? ' ':'\n'); > > where 'cs' is the _console_ structure, not the tty structure. > So we're getting the _console_ name plus the _console_ index here. > And the console name for the 3270 console is 'tty3270', with the > index '0'. > > Which raises the question: what exactly should be 'active' contain? > The console name (which doesn't have any equivalent in sysfs), or > the tty name (which has)? > > And, more importantly, how is one supposed to _find_ the > corresponding sysfs entry for the current 'active' attribute? > > From what I've seen most driver work by virtue of the happy accident > that the console index equals the tty index. > But that's not a requirement anywhere in the console code. > Quite the contrary; tty drivers have the 'first_minor' entry > to explicit request an offset other than '0'. > > (And the console driver has an explict '->device' callback > which allows the tty driver to return the correct index. > Not that it's used here; would've been too easy). > > So how to fix this? > Update the driver to adhere to the (broken) current behaviour? > Or modify 'active' to return the corrent tty name? Sounds fine, if that does not break anything. Systemd should only care about the matching name on the kernel cmdline and the VTs /dev/ttyX. > Or add a workaround to systemd? Any fancier logic would need to go into a separate generator.. Generators can do anything they like, and extend the logic the same way the default systemd logic is shipped. Kay ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Mon, 03.02.14 14:44, Hannes Reinecke (h...@suse.de) wrote: > > Which raises the question: what exactly should be 'active' contain? > The console name (which doesn't have any equivalent in sysfs), or > the tty name (which has)? Userspace expects that /sys/class/tty/console/active refers to a valid tty name, and that /sys/class/tty/tty0/active refers to a valid VT tty name. Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Tue, Feb 04, 2014 at 02:25:06PM +0100, Lennart Poettering wrote: > On Mon, 03.02.14 14:44, Hannes Reinecke (h...@suse.de) wrote: > > > > > Which raises the question: what exactly should be 'active' contain? > > The console name (which doesn't have any equivalent in sysfs), or > > the tty name (which has)? > > Userspace expects that /sys/class/tty/console/active refers to a valid > tty name, and that /sys/class/tty/tty0/active refers to a valid VT tty > name. Even if the identifier string of tty3270.c becomes "3270/tty" it seems that something goes wrong as in show_cons_active() of drivers/tty/tty_io.c the name_base of the struct tty_driver is not honored. Also on s390 the device for "3270/tty" its self is not plugged: systemctl list-units | grep virtual-tty | sed 's/^/ /' sys-devices-virtual-tty-hvc0.device loaded active plugged /sys/devices/virtual/tty/hvc0 sys-devices-virtual-tty-hvc1.device loaded active plugged /sys/devices/virtual/tty/hvc1 sys-devices-virtual-tty-hvc2.device loaded active plugged /sys/devices/virtual/tty/hvc2 sys-devices-virtual-tty-hvc3.device loaded active plugged /sys/devices/virtual/tty/hvc3 sys-devices-virtual-tty-hvc4.device loaded active plugged /sys/devices/virtual/tty/hvc4 sys-devices-virtual-tty-hvc5.device loaded active plugged /sys/devices/virtual/tty/hvc5 sys-devices-virtual-tty-hvc6.device loaded active plugged /sys/devices/virtual/tty/hvc6 sys-devices-virtual-tty-hvc7.device loaded active plugged /sys/devices/virtual/tty/hvc7 sys-devices-virtual-tty-ttysclp0.device loaded active plugged /sys/devices/virtual/tty/ttysclp0 as the existing directory /sys/devices/virtual/tty/3270!tty1 is not listed at least with 208. Nevertheless the nodes are there ll /dev/3270/tty1 crw--w 1 root tty 227, 1 Feb 4 15:51 /dev/3270/tty1 but a `dev-3270-tty1.device' seems not to be usable. Werner -- "Having a smoking section in a restaurant is like having a peeing section in a swimming pool." -- Edward Burr pgpqW2pEFtvwk.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Tue, Feb 04, 2014 at 05:06:57PM +0100, Dr. Werner Fink wrote: > On Tue, Feb 04, 2014 at 02:25:06PM +0100, Lennart Poettering wrote: > > On Mon, 03.02.14 14:44, Hannes Reinecke (h...@suse.de) wrote: > > > > > > > > Which raises the question: what exactly should be 'active' contain? > > > The console name (which doesn't have any equivalent in sysfs), or > > > the tty name (which has)? > > > > Userspace expects that /sys/class/tty/console/active refers to a valid > > tty name, and that /sys/class/tty/tty0/active refers to a valid VT tty > > name. > > Even if the identifier string of tty3270.c becomes "3270/tty" it seems > that something goes wrong as in show_cons_active() of drivers/tty/tty_io.c > the name_base of the struct tty_driver is not honored. > > Also on s390 the device for "3270/tty" its self is not plugged: > > systemctl list-units | grep virtual-tty | sed 's/^/ /' > sys-devices-virtual-tty-hvc0.device loaded active plugged > /sys/devices/virtual/tty/hvc0 > sys-devices-virtual-tty-hvc1.device loaded active plugged > /sys/devices/virtual/tty/hvc1 > sys-devices-virtual-tty-hvc2.device loaded active plugged > /sys/devices/virtual/tty/hvc2 > sys-devices-virtual-tty-hvc3.device loaded active plugged > /sys/devices/virtual/tty/hvc3 > sys-devices-virtual-tty-hvc4.device loaded active plugged > /sys/devices/virtual/tty/hvc4 > sys-devices-virtual-tty-hvc5.device loaded active plugged > /sys/devices/virtual/tty/hvc5 > sys-devices-virtual-tty-hvc6.device loaded active plugged > /sys/devices/virtual/tty/hvc6 > sys-devices-virtual-tty-hvc7.device loaded active plugged > /sys/devices/virtual/tty/hvc7 > sys-devices-virtual-tty-ttysclp0.device loaded active plugged > /sys/devices/virtual/tty/ttysclp0 > > as the existing directory > > /sys/devices/virtual/tty/3270!tty1 > > is not listed at least with 208. Nevertheless the nodes are there The 3270 devices should be tagged for systemd in the 99-systemd.rules file. > > ll /dev/3270/tty1 > crw--w 1 root tty 227, 1 Feb 4 15:51 /dev/3270/tty1 > > but a `dev-3270-tty1.device' seems not to be usable. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] s390/getty-generator: initialize essential system terminals/consoles
On Wed, Feb 05, 2014 at 12:19:21PM +0100, Hendrik Brueckner wrote: > > > > is not listed at least with 208. Nevertheless the nodes are there > > The 3270 devices should be tagged for systemd in the 99-systemd.rules file. Thanks, just done a few minutes before and it works if I do a symlink serial-getty@3270-tty1.service below /etc/systemd/system/getty.target.wants to /usr/lib/systemd/system/serial-getty@.service. Also Hannes and I have send a patch to linux-kernel[1] to enable user space aka systemd to handle 3270 devices. Werner [1] http://lkml.indiana.edu/hypermail/linux/kernel/1402.0/02319.html -- "Having a smoking section in a restaurant is like having a peeing section in a swimming pool." -- Edward Burr pgpNESbUlPoQ9.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
