Re: [systemd-devel] [PATCH 0/2] Empty environment variables in unit files work

2014-11-20 Thread Koen Kooi 

> Op 19 nov. 2014, om 19:44 heeft Iago López Galeiras  het 
> volgende geschreven:
> 
> with this file:
> 
> [Unit]
> Description=Test empty variables
> 
> [Service]
> Environment=TEST= TEST2=
> ExecStart=/bin/bash -c "env"
> 
> [Install]
> WantedBy=default.target
> 
> I get this output:
> 
> Nov 19 16:59:07 arch-tree systemd[1]: Starting Test empty variables...
> Nov 19 16:59:07 arch-tree systemd[1]: Started Test empty variables.
> Nov 19 16:59:07 arch-tree bash[131]: 
> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
> Nov 19 16:59:07 arch-tree bash[131]: PWD=/
> Nov 19 16:59:07 arch-tree bash[131]: TEST=
> Nov 19 16:59:07 arch-tree bash[131]: SHLVL=1
> Nov 19 16:59:07 arch-tree bash[131]: TEST2=
> Nov 19 16:59:07 arch-tree bash[131]: _=/usr/sbin/env
> 
> 
> Iago López Galeiras (2):
>  test: empty environment variables in unit files

Nitpick: 'empty' looks like a verb there, changing it to 'test: support empty 
environment variables in unit files' (like the TODO entry) would avoid a lot of 
confusion.

regards,

Koen
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 0/2] Empty environment variables in unit files work

2014-11-19 Thread Iago López Galeiras 
with this file:

[Unit]
Description=Test empty variables

[Service]
Environment=TEST= TEST2=
ExecStart=/bin/bash -c "env"

[Install]
WantedBy=default.target

I get this output:

Nov 19 16:59:07 arch-tree systemd[1]: Starting Test empty variables...
Nov 19 16:59:07 arch-tree systemd[1]: Started Test empty variables.
Nov 19 16:59:07 arch-tree bash[131]: 
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
Nov 19 16:59:07 arch-tree bash[131]: PWD=/
Nov 19 16:59:07 arch-tree bash[131]: TEST=
Nov 19 16:59:07 arch-tree bash[131]: SHLVL=1
Nov 19 16:59:07 arch-tree bash[131]: TEST2=
Nov 19 16:59:07 arch-tree bash[131]: _=/usr/sbin/env


Iago López Galeiras (2):
  test: empty environment variables in unit files
  update TODO

 TODO  |  2 --
 src/test/test-unit-file.c | 22 ++
 2 files changed, 22 insertions(+), 2 deletions(-)

-- 
2.1.3

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel