Re: [systemd-devel] [PATCH 1/2] machine: machinectl, remove some dead code

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek 
On Wed, Dec 31, 2014 at 04:16:02PM +0200, Philippe De Swert wrote:
 The variable r is already checked one time before and the same error returned.
 So the second check is unneeded.
 ---
  src/machine/machinectl.c | 4 
  1 file changed, 4 deletions(-)
 
 diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c
 index 0abc251..951b3cc 100644
 --- a/src/machine/machinectl.c
 +++ b/src/machine/machinectl.c
 @@ -250,10 +250,6 @@ static int list_images(int argc, char *argv[], void 
 *userdata) {
 (int) max_mtime, strna(format_timestamp(mtime_buf, 
 sizeof(mtime_buf), images[j].mtime)));
  }
  
 -if (r  0)
 -return bus_log_parse_error(r);
 -
 -
David pushed the same change yesterday.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH 1/2] machine: machinectl, remove some dead code

2014-12-31 Thread Philippe De Swert 
The variable r is already checked one time before and the same error returned.
So the second check is unneeded.
---
 src/machine/machinectl.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c
index 0abc251..951b3cc 100644
--- a/src/machine/machinectl.c
+++ b/src/machine/machinectl.c
@@ -250,10 +250,6 @@ static int list_images(int argc, char *argv[], void 
*userdata) {
(int) max_mtime, strna(format_timestamp(mtime_buf, 
sizeof(mtime_buf), images[j].mtime)));
 }
 
-if (r  0)
-return bus_log_parse_error(r);
-
-
 if (arg_legend)
 printf(\n%zu images listed.\n, n_images);
 
-- 
2.1.3

___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel