Re: [systemd-devel] [PATCHv2] login: Don't stop a running user manager from garbage-collecting the user.
On Tue, Dec 24, 2013 at 1:14 PM, Ivan Shapovalov wrote: > > It seems that this patch has been applied to Arch's systemd-208-3, but it did > not fix > the issue for me. I'm still getting the timeout: > > "Dec 23 17:26:42 intelfx-laptop systemd[1]: user@1000.service stopping timed > out. Killing." > That's likely different problem. Timeout stopping user@.service was reported more than once. It seems that somehow user systemd instance does not get SIGTERM and so does not initiate service stop (at least that is as far as I could debug it). ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCHv2] login: Don't stop a running user manager from garbage-collecting the user.
On Wednesday 18 December 2013 at 11:03:05, Tom wrote: > On Sun, Dec 15, 2013 at 12:06 PM, Thomas Bächler wrote: > > With the current logic, a user will never be garbage-collected, since its > > manager will always be around. Change the logic such that a user is > > garbage-collected when it has no sessions and linger is disabled. > > --- > > > > src/login/logind-user.c | 6 -- > > 1 file changed, 6 deletions(-) > > > > diff --git a/src/login/logind-user.c b/src/login/logind-user.c > > index 6ba8d98..441e086 100644 > > --- a/src/login/logind-user.c > > +++ b/src/login/logind-user.c > > @@ -618,12 +618,6 @@ bool user_check_gc(User *u, bool drop_not_started) { > > > > if (u->service_job && manager_job_is_active(u->manager, > > u->service_job)) > > > > return true; > > > > -if (u->slice && manager_unit_is_active(u->manager, u->slice) != 0) > > -return true; > > - > > -if (u->service && manager_unit_is_active(u->manager, u->service) > > != 0) > > -return true; > > - > > > > return false; > > > > } > > > > -- > > Applied. > > Cheers, > > Tom > ___ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel It seems that this patch has been applied to Arch's systemd-208-3, but it did not fix the issue for me. I'm still getting the timeout: "Dec 23 17:26:42 intelfx-laptop systemd[1]: user@1000.service stopping timed out. Killing." -- Ivan Shapovalov / intelfx / ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCHv2] login: Don't stop a running user manager from garbage-collecting the user.
On Sun, Dec 15, 2013 at 12:06 PM, Thomas Bächler wrote: > With the current logic, a user will never be garbage-collected, since its > manager will always be around. Change the logic such that a user is > garbage-collected when it has no sessions and linger is disabled. > --- > src/login/logind-user.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/src/login/logind-user.c b/src/login/logind-user.c > index 6ba8d98..441e086 100644 > --- a/src/login/logind-user.c > +++ b/src/login/logind-user.c > @@ -618,12 +618,6 @@ bool user_check_gc(User *u, bool drop_not_started) { > if (u->service_job && manager_job_is_active(u->manager, > u->service_job)) > return true; > > -if (u->slice && manager_unit_is_active(u->manager, u->slice) != 0) > -return true; > - > -if (u->service && manager_unit_is_active(u->manager, u->service) != > 0) > -return true; > - > return false; > } > > -- Applied. Cheers, Tom ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCHv2] login: Don't stop a running user manager from garbage-collecting the user.
With the current logic, a user will never be garbage-collected, since its manager will always be around. Change the logic such that a user is garbage-collected when it has no sessions and linger is disabled. --- src/login/logind-user.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/login/logind-user.c b/src/login/logind-user.c index 6ba8d98..441e086 100644 --- a/src/login/logind-user.c +++ b/src/login/logind-user.c @@ -618,12 +618,6 @@ bool user_check_gc(User *u, bool drop_not_started) { if (u->service_job && manager_job_is_active(u->manager, u->service_job)) return true; -if (u->slice && manager_unit_is_active(u->manager, u->slice) != 0) -return true; - -if (u->service && manager_unit_is_active(u->manager, u->service) != 0) -return true; - return false; } -- 1.8.5.1 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel