Re: [systemd-devel] Adding a .device reload on udev change

[Jérémy Rosen]

On 05/11/2017 07:45, Lennart Poettering wrote:

Ah, sorry for not reviewing this more timely. I didn't look into this
again mostly out of time constraints... Because we just did a release
I am not focussing so much on reviews, but try to write new code
instead. And when I do reviews anyway right now I usually start from
the top of the PR list...
No problem, it's just that, because the concept was already tested and 
validated in a previous PR, I thought the review would go fast


And since I heard you complaining at least once that github 
notifications had problems, I was wondering if I hadn't fallen in one of 
those cases,


I'll simply wait for 236 then

As soon as we start preparing for the next release again I'll refocus
back on reviewing PRs, and unless I found the time to look at this one
earlier I'll definitely find it then.
Would it be possible to announce when you enter the "preparing for 
release" phase ?


I don't think anybody needs this info strictly speaking, but it would be 
handy for those of us that have PR waiting so we know there is a dealine 
and we should respond quickly...



Thx
Jérémy


Sorry for the delay. And yes, we have too foo reviewers. Reviewing is
time consuming, and not the most grateful of tasks I figure, and much
like most free software projects in systemd we have to few
reviewers for the amount of patches we get...

Lennart



--
SMILE 

20 rue des Jardins
92600 Asnières-sur-Seine


*Jérémy ROSEN*
Architecte technique
Responsable de l'expertise Smile-ECS

email jeremy.ro...@smile.fr 
phone +33141402967
url http://www.smile.eu

Twitter  Facebook 
 LinkedIn 
 Github 




Découvrez l’univers Smile, rendez-vous sur smile.eu 



eco Pour la planète, n'imprimez ce mail que si c'est nécessaire
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Adding a .device reload on udev change

[Lennart Poettering]

On Sa, 04.11.17 09:58, Jérémy Rosen (jeremy.ro...@smile.fr) wrote:

> Hello everybody
> 
> I have written PR https://github.com/systemd/systemd/pull/6850 (opened)
> and PR https://github.com/systemd/systemd/pull/6428 (closed)
> 
> Both of these PR were about having systemd generate a "reload" on .device
> units to propagate to real services.
> 
> The first one was accepted, the concept was valid, but it caused a
> regression and was partially reversed
> 
> I opened the second PR to track the regression and submit a version that
> worked. That version has been around for some time but I have not received
> any comment or no-go on it.
> 
> At this point  I was wondering if there is a problem in the github
> notification logic, or if my PR is being ignored because I originally asked
> it to not be merged (regression testing)
> 
> So, just to be sure, is there a particular reason systemd is not interested
> in the idea, or is this just a case of me being paranoid and the devs having
> other stuff on their radar ?

Ah, sorry for not reviewing this more timely. I didn't look into this
again mostly out of time constraints... Because we just did a release
I am not focussing so much on reviews, but try to write new code
instead. And when I do reviews anyway right now I usually start from
the top of the PR list...

As soon as we start preparing for the next release again I'll refocus
back on reviewing PRs, and unless I found the time to look at this one
earlier I'll definitely find it then.

Sorry for the delay. And yes, we have too foo reviewers. Reviewing is
time consuming, and not the most grateful of tasks I figure, and much
like most free software projects in systemd we have to few
reviewers for the amount of patches we get...

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] Adding a .device reload on udev change

[Jérémy Rosen]

Hello everybody

I have written PR https://github.com/systemd/systemd/pull/6850 (opened)
and PR https://github.com/systemd/systemd/pull/6428 (closed)

Both of these PR were about having systemd generate a "reload" on 
.device units to propagate to real services.


The first one was accepted, the concept was valid, but it caused a 
regression and was partially reversed


I opened the second PR to track the regression and submit a version that 
worked. That version has been around for some time but I have not 
received any comment or no-go on it.


At this point  I was wondering if there is a problem in the github 
notification logic, or if my PR is being ignored because I originally 
asked it to not be merged (regression testing)


So, just to be sure, is there a particular reason systemd is not 
interested in the idea, or is this just a case of me being paranoid and 
the devs having other stuff on their radar ?


Thx and sorry for the inconvinience
Jérémy
--
SMILE 

20 rue des Jardins
92600 Asnières-sur-Seine


*Jérémy ROSEN*
Architecte technique
Responsable de l'expertise Smile-ECS

email jeremy.ro...@smile.fr 
phone +33141402967
url http://www.smile.eu

Twitter  Facebook 
 LinkedIn 
 Github 




Découvrez l’univers Smile, rendez-vous sur smile.eu 



eco Pour la planète, n'imprimez ce mail que si c'est nécessaire
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/systemd-devel