Re: [systemd-devel] Problem when m-finish_timestamp is set before running manager_loop

2015-05-23 Thread cee1 
2015-05-22 3:36 GMT+08:00 Lennart Poettering lenn...@poettering.net:

 Should be fixed in git. Please verify!

Confirmed, thanks!



-- 
Regards,

- cee1
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Problem when m-finish_timestamp is set before running manager_loop

2015-05-21 Thread Lennart Poettering 
On Wed, 20.05.15 11:16, cee1 (fykc...@gmail.com) wrote:

 2015-05-20 1:27 GMT+08:00 Lennart Poettering lenn...@poettering.net:
  Hmm, can you provide a backtrace of the call chain when this happens,
  please?
 
 The call chain is:
 0xb6df1acc manager_check_finished+308: 0xe1a07000
 0xb6e9f744 job_finish_and_invalidate+936: 0xe3a0
 0xb6df4bb0 transaction_activate+3540: 0xe59a0004
 0xb6ded8e8 manager_add_job+364: 0xe2509000
 0xb6de6080 main+8896: 0xe371
 

Should be fixed in git. Please verify!

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] Problem when m-finish_timestamp is set before running manager_loop

2015-05-19 Thread cee1 
Hi all,

I found a Startup finished in 155ms (userspace) = 155ms(
which is of course incorrect) log on the board at hand, which is
caused by something likes:

Job cache.mount/stop finished, result=canceled

Following the code, I find m-finish_timestamp is set in
manager_check_finished(), which is in turn invoked in
job_finish_and_invalidate() -- All these happens before the
manager_loop running.


-- 
Regards,

- cee1
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Problem when m-finish_timestamp is set before running manager_loop

2015-05-19 Thread Lennart Poettering 
On Tue, 19.05.15 14:45, cee1 (fykc...@gmail.com) wrote:

 Hi all,
 
 I found a Startup finished in 155ms (userspace) = 155ms(
 which is of course incorrect) log on the board at hand, which is
 caused by something likes:
 
 Job cache.mount/stop finished, result=canceled
 
 Following the code, I find m-finish_timestamp is set in
 manager_check_finished(), which is in turn invoked in
 job_finish_and_invalidate() -- All these happens before the
 manager_loop running.

Hmm, can you provide a backtrace of the call chain when this happens,
please?

I have now commited a patch to git, that might fix the issue, but I am
not entirely sure, given the little information I have:

http://cgit.freedesktop.org/systemd/systemd/commit/?id=aad1976ffa25fa6901f72c300b5980ada0ef44c5

Would be cool if you could check if this patch already fixes the issue
for you.

Thanks,

Lennart

-- 
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel