Re: [systemd-devel] What does it take to make test-engine working again?
On Wed, Nov 21, 2012 at 2:26 PM, Holger Freyther hol...@freyther.de wrote: Koen pointed me to a jenkins but it doesn't run make check. I have it configured right now to run make test, which does nothing in systemd builds. I'm happy to update it to include a proper post-build test, but I'd like consensus on what it should be. -- David Strauss | da...@davidstrauss.net ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] What does it take to make test-engine working again?
On Fri, 23.11.12 04:31, David Strauss (da...@davidstrauss.net) wrote: On Wed, Nov 21, 2012 at 2:26 PM, Holger Freyther hol...@freyther.de wrote: Koen pointed me to a jenkins but it doesn't run make check. I have it configured right now to run make test, which does nothing in systemd builds. I'm happy to update it to include a proper post-build test, but I'd like consensus on what it should be. make check is the command to invoke, not make test. Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] What does it take to make test-engine working again?
Lennart Poettering lennart at poettering.net writes: That specific test is really old, and hasn't been used in a long time. I guess we should either remove it or make it work again. (Happy to take patches...) Okay, I will post a patch for the removal (it is broken beyond repair at this point, e.g. I need to inhibit the code of parsing /lib/...). More unit tests for parsing unit files would be very desirable though! The bigger question is how to avoid bitrot again? Koen pointed me to a jenkins but it doesn't run make check. The other part is that the output of the tests is very verbose and it is difficult to see the real error. In our Osmocom projects we are using the GNU autotest facility and it creates output like this: ## --- ## ## libosmocore UNKNOWN test suite. ## ## --- ## Regression tests. 1: a5 ok 2: bssgp-fc ok 3: bits ok cheers holger ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] What does it take to make test-engine working again?
On Wed, 21.11.12 20:26, Holger Freyther (hol...@freyther.de) wrote: More unit tests for parsing unit files would be very desirable though! The bigger question is how to avoid bitrot again? Koen pointed me to a jenkins but it doesn't run make check. The other part is that the output of the tests is very verbose and it is difficult to see the real error. In our Osmocom projects we are using the GNU autotest facility and it creates output like this: The tests are run as part of make distcheck which is what we use to prepare release tarballs. If something is in TESTS= it hence is unlikely to bitrot simply because we cannot release anything if it is broken. Also, given that a simple make will build all tests we have compile checks of these tests every single time somebody tries to build the thing. The problem with this one specific test though was that I wrote it in a style that doesn't make it useful as unit test, because I wasn't aware of automake's TESTS construct back then. ## --- ## ## libosmocore UNKNOWN test suite. ## ## --- ## Regression tests. 1: a5 ok 2: bssgp-fc ok 3: bits ok cheers holger ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel Lennart -- Lennart Poettering - Red Hat, Inc. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] What does it take to make test-engine working again?
Holger Freyther holger at freyther.de writes: I made a small change and wanted to add test coverage for the bug I was fixing. The only test that is loading units appears to be test-engine. Sadly this test is not executed as part of make check and executing it by hand results in an assertion when starting the first job. apparently something like manager_startup is missing to actually load the service files. Maybe one wants to omit the execution of generators. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] What does it take to make test-engine working again?
Hi, I made a small change and wanted to add test coverage for the bug I was fixing. The only test that is loading units appears to be test-engine. Sadly this test is not executed as part of make check and executing it by hand results in an assertion when starting the first job. Is there a preferred way to test loading of units? Does the test work for someone? holger ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
