[systemd-devel] bulid: linking order is irrelevant

2014-05-21 Thread Jan Engelhardt

commit ffcf82d250e95ea0a06a95d7adc72bfad6db51e3
Author: Kay Sievers k...@vrfy.org
Date:   Thu May 22 09:41:32 2014 +0900

build-sys: fix linking order

./.libs/libsystemd-network.a(libsystemd_network_la-network-internal.o):
  network-internal.c:function net_get_unique_predictable_data:
  error: undefined reference to 'udev_device_get_property_value'
collect2: error: ld returned 1 exit status


Linking order is not a problem with .la files, as .la files track
their dependencies -- just like .so files.

If libsystemd-network.la is relying on that udev function, it ought
to specify libudev(-internal).la in libsystemd_network_la_LIBADD.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Re: [systemd-devel] bulid: linking order is irrelevant

2014-05-21 Thread Kay Sievers
On Thu, May 22, 2014 at 9:53 AM, Jan Engelhardt jeng...@inai.de wrote:

 Linking order is not a problem with .la files, as .la files track
 their dependencies -- just like .so files.

It is a generally a problem that the build system tools do not solve.
We rely on gc-sections, platforms without support for it fail to build
without the explicily specified right order. Without this fix we fail
to build on ARM:
  
http://cgit.freedesktop.org/systemd/systemd/commit/?id=2fa495c8a4ea25cb96daebb8aa0d146b74353016

 If libsystemd-network.la is relying on that udev function, it ought
 to specify libudev(-internal).la in libsystemd_network_la_LIBADD.

Yeah, I moved that around.

Thanks,
Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel