Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
On Thu, 15.05.14 20:00, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: El 15/05/14 19:20, Lennart Poettering escribió: ilure. What's the precise error? Failed to listen to networkd events: No such file or directory) Ah, this is because /run/systemd/network/links doesn't exist when networkd never ran. I now changed git to make sure it is created via tmpfiles early in boot in all cases. Can you check if this makes things work for you? Tom, does this look right to you? Thanks, Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
On Fri, May 16, 2014 at 3:58 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 15.05.14 20:00, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: El 15/05/14 19:20, Lennart Poettering escribió: ilure. What's the precise error? Failed to listen to networkd events: No such file or directory) Ah, this is because /run/systemd/network/links doesn't exist when networkd never ran. I now changed git to make sure it is created via tmpfiles early in boot in all cases. Can you check if this makes things work for you? Tom, does this look right to you? Looks good. -t ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
El 15/05/14 18:23, Cristian Rodríguez escribió: timesyncd requires networkd running. --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 16b689e..a19ca24 100644 --- a/configure.ac +++ b/configure.ac @@ -830,6 +830,8 @@ AC_ARG_ENABLE(timesyncd, AS_HELP_STRING([--disable-timesyncd], [disable timesync if test x$enable_timesyncd != xno; then have_timesyncd=yes fi +AS_IF([test x$have_timesyncd = xyes -a x$have_networkd != xyes], + [AC_MSG_ERROR([timesyncd requires networkd at runtime])]) AM_CONDITIONAL(ENABLE_TIMESYNCD, [test $have_timesyncd = yes]) AC_ARG_WITH(ntp-servers, This patch is incorrect, have_networkd is not yet set when the test runs and returns a false result. ignore it for now. -- Cristian I don't know the key to success, but the key to failure is trying to please everybody. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
On Thu, 15.05.14 18:23, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: timesyncd requires networkd running. It doesn't really Should work either way... --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 16b689e..a19ca24 100644 --- a/configure.ac +++ b/configure.ac @@ -830,6 +830,8 @@ AC_ARG_ENABLE(timesyncd, AS_HELP_STRING([--disable-timesyncd], [disable timesync if test x$enable_timesyncd != xno; then have_timesyncd=yes fi +AS_IF([test x$have_timesyncd = xyes -a x$have_networkd != xyes], + [AC_MSG_ERROR([timesyncd requires networkd at runtime])]) AM_CONDITIONAL(ENABLE_TIMESYNCD, [test $have_timesyncd = yes]) AC_ARG_WITH(ntp-servers, Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
El 15/05/14 18:34, Lennart Poettering escribió:
On Thu, 15.05.14 18:23, Cristian Rodríguez
(crrodrig...@opensuse.org) wrote:
timesyncd requires networkd running.
It doesn't really Should work either way...
I tried that a few hours ago..
r = manager_network_monitor_listen(m);
if (r 0) {
log_error(Failed to listen to networkd events: %s,
strerror(-r));
goto out;
}
then it exits with failure.
--
Cristian
I don't know the key to success, but the key to failure is trying to
please everybody.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
On Thu, 15.05.14 19:02, Cristian Rodríguez (crrodrig...@opensuse.org) wrote:
El 15/05/14 18:34, Lennart Poettering escribió:
On Thu, 15.05.14 18:23, Cristian Rodríguez
(crrodrig...@opensuse.org) wrote:
timesyncd requires networkd running.
It doesn't really Should work either way...
I tried that a few hours ago..
r = manager_network_monitor_listen(m);
if (r 0) {
log_error(Failed to listen to networkd events: %s,
strerror(-r));
goto out;
}
then it exits with failure.
What's the precise error?
Seems to work fine on my laptop that still has NetworkManager...
Lennart
--
Lennart Poettering, Red Hat
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
On Fri, May 16, 2014 at 1:20 AM, Lennart Poettering
lenn...@poettering.net wrote:
On Thu, 15.05.14 19:02, Cristian Rodríguez (crrodrig...@opensuse.org) wrote:
El 15/05/14 18:34, Lennart Poettering escribió:
On Thu, 15.05.14 18:23, Cristian Rodríguez
(crrodrig...@opensuse.org) wrote:
timesyncd requires networkd running.
It doesn't really Should work either way...
I tried that a few hours ago..
r = manager_network_monitor_listen(m);
if (r 0) {
log_error(Failed to listen to networkd events: %s,
strerror(-r));
goto out;
}
then it exits with failure.
What's the precise error?
Seems to work fine on my laptop that still has NetworkManager...
But networkd runs on your machine and exports state.
We need to make timesyncd gracefully accepting that no networkd
around, or we should just make it depend on it.
Kay
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] build: --disable-networkd --enable-timesyncd should throw error
El 15/05/14 19:20, Lennart Poettering escribió: ilure. What's the precise error? Failed to listen to networkd events: No such file or directory) -- Cristian I don't know the key to success, but the key to failure is trying to please everybody. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
