Re: [systemd-devel] [PATCH 2/3 RFC] systemd: use structured logging for unit changes

2012-10-18 Thread Marius Tolzmann 

Hi..

On 10/18/12 16:12, Zbigniew Jędrzejewski-Szmek wrote:
 Information which unit a log entry pertains to enables systemctl
 status to display more log messages.
 ---
 @@ -1022,7 +1024,11 @@ int exec_spawn(ExecCommand *command,
  
  r = exec_context_load_environment(context, files_env);
  if (r  0) {
 -log_error(Failed to load environment files: %s, 
 strerror(-r));
 +log_struct(LOG_ERR,
 +   UNIT=%s, unit_id,
 +   MESSAGE=Failed to load environment files: %s, 
 strerror(-r),
 +   ERRNO=%d, errno,

shouldn't that be ERRNO=%d, (-r), ?

I did not check the rest. It just hit my eyes 8)

Bye marius..


-- 
Dipl.-Inf. Marius Tolzmann marius.tolzm...@molgen.mpg.de
--.--
MPI f. molekulare Genetik |
Ihnestrasse 63-73, D-14195 Berlin |   == MarIuX GNU/Linux ==
Phone: +49 (0)30 8413 1709|
--^--
God put me on earth to accomplish a certain number of things.
Right now I am so far behind..
   ..I will never die. by calvin from calvinhobbes ;)



smime.p7s
Description: S/MIME Cryptographic Signature
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 2/3 RFC] systemd: use structured logging for unit changes

2012-10-18 Thread Zbigniew Jędrzejewski-Szmek 
On Thu, Oct 18, 2012 at 04:44:39PM +0200, Marius Tolzmann wrote:
 
 Hi..
 
 On 10/18/12 16:12, Zbigniew Jędrzejewski-Szmek wrote:
  Information which unit a log entry pertains to enables systemctl
  status to display more log messages.
  ---
  @@ -1022,7 +1024,11 @@ int exec_spawn(ExecCommand *command,
   
   r = exec_context_load_environment(context, files_env);
   if (r  0) {
  -log_error(Failed to load environment files: %s, 
  strerror(-r));
  +log_struct(LOG_ERR,
  +   UNIT=%s, unit_id,
  +   MESSAGE=Failed to load environment files: %s, 
  strerror(-r),
  +   ERRNO=%d, errno,
 
 shouldn't that be ERRNO=%d, (-r), ?
Yeah, obviously. Thanks for catching that.

Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH 2/3 RFC] systemd: use structured logging for unit changes

2012-10-18 Thread Lennart Poettering 
On Thu, 18.10.12 16:12, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:

 Information which unit a log entry pertains to enables systemctl
 status to display more log messages.

The first two patches really look good, please go ahead and commit.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel