Re: [systemd-devel] remove duplicate includes
On Wed, Nov 20, 2013 at 10:54:15PM +0100, Lennart Poettering wrote: On Tue, 19.11.13 02:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Nov 18, 2013 at 02:48:14PM +0100, Karel Zak wrote: A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Wow. Applied in one big fell swoop. I'd be happy to also apply a patch that adds that tool to our tree so that we can easily rerun it again... Do you want the script in the top level directory? .. in util-linux we usually use tools/ subdirectory for such things. It seems that in systemd source tree it would be possible to move things like make-directive-index.py, make-man-index.py, make-man-rules.py and xml_helper.py to the subdirectory too. Karel -- Karel Zak k...@redhat.com http://karelzak.blogspot.com ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] remove duplicate includes
On Tue, Jan 21, 2014 at 04:50:24PM +0100, Karel Zak wrote: On Wed, Nov 20, 2013 at 10:54:15PM +0100, Lennart Poettering wrote: On Tue, 19.11.13 02:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Nov 18, 2013 at 02:48:14PM +0100, Karel Zak wrote: A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Wow. Applied in one big fell swoop. I'd be happy to also apply a patch that adds that tool to our tree so that we can easily rerun it again... Do you want the script in the top level directory? .. in util-linux we usually use tools/ subdirectory for such things. It seems that in systemd source tree it would be possible to move things like make-directive-index.py, make-man-index.py, make-man-rules.py and xml_helper.py to the subdirectory too. I don't have particular feeling either way. They are not called directly, so the location is an implementation detail. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] remove duplicate includes
On Tue, 19.11.13 02:33, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Nov 18, 2013 at 02:48:14PM +0100, Karel Zak wrote: A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Wow. Applied in one big fell swoop. I'd be happy to also apply a patch that adds that tool to our tree so that we can easily rerun it again... Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] remove duplicate includes
On Mon, Nov 18, 2013 at 02:48:14PM +0100, Karel Zak wrote: A few trivial patches... the duplications found by https://raw.github.com/karelzak/util-linux/master/tools/checkincludes.pl Wow. Applied in one big fell swoop. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
