Re: [Tails-dev] Please review and merge feature/liveusb_ui_improvement

2013-09-29 Thread intrigeri
Hi,

merged into devel, *but* not 100% done yet:

 - https://labs.riseup.net/code/issues/6292

- marked as needs more dev (I'm thinking of the devices menu UI bug;
   I don't remember if my review exposed other blockers)

 - https://labs.riseup.net/code/issues/6293

- Alright, marked as Fix committed

And the bonus one (https://labs.riseup.net/code/issues/6258)

- Reassigned to you for the review of the bugfixes I've pushed on top
   of master.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) :
 Please merge this branch in experimental, devel, stable, testing and
 feature/wheezy if happy with it.

I'd be happy too, but the branch is based on devel, so I can't merge
it into stable. Please rebase on stable, and reassign the ticket
to me.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) :
 This change goes together with two changes in our puppet modules:

 A new one has been created to deploy the gnupg keyring in our autobuilder
 VM on lizard, and has been reviewed already by intrigeri.

I've had a look to the newest changes that I hadn't reviewed yet.

I think commit 433fa5cf (Move the /mnt/crypt mount operation in
a more appropriate place) in lizard's Puppet manifests, and the
corresponding commit 2b71c6c6 in tails_secrets_jenkins, are a mistake,
and can be dangerous in the future.

Let me explain why.

This dummy mount really belongs to an individual node's manifest.
This declaration is the only way a sysadmin deploying the
tails_secrets_jenkins module can state that they have taken care of
the storage security pre-requisites of that module. This statement
unblocks the deployment of the module.

Moving this dummy mount into tails_secrets_jenkins really means
pretend my storage security pre-requisites are satisfied, regardless
of where and how I'm deployed, which kinda defeats the purpose of
having any such safe-guard in place.

Please revert both commits. A nicer solution has to be found.
I'm happy to help a bit, but for this I need more information than If
not it seems to raise a chicken and egg problem :)

I'm thus re-opening #6266.

 Ticket : #6268 - Adapt the Jenkins artifacts rotation script

ACK, marking as resolved!

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review and merge feature/liveusb_ui_improvement

2013-09-29 Thread intrigeri
Hi,

another test pass:

when running the installer on a ThinkPad X60s, and plugging a SD card
into the (SDIO-wired) reader, the target device appears this way in
the list:

  0 (Tails)

Perhaps we shouldn't only display the brand and model, but also
reintroduce the device name (such as /dev/sdb1)?

Same in the confirmation dialog, that actually now has less relevant
information than it used to.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread bertagaz
On Sun, Sep 29, 2013 at 01:36:28PM +0200, intrigeri wrote:
 berta...@ptitcanardnoir.org wrote (28 Sep 2013 09:22:16 GMT) :
  Please merge this branch in experimental, devel, stable, testing and
  feature/wheezy if happy with it.
 
 I'd be happy too, but the branch is based on devel, so I can't merge
 it into stable. Please rebase on stable, and reassign the ticket
 to me.

Oooch, you're right. I've just force updated the branch for it to be
based on the stable one. Thanks for the reminder.

bert.
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review and merge feature/keepassx_launcher

2013-09-29 Thread intrigeri
Alan wrote (25 Sep 2013 13:47:33 GMT) :
 I believe the feature/keepassx_launcher is now ready.
 ticket: https://labs.riseup.net/code/issues/5686

Looks good, but the documentation needs to be updated accordingly:
doc/first_steps/introduction_to_gnome_and_the_tails_desktop

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review'n'merge feature/Sign_jenkins_builds_artifacts

2013-09-29 Thread intrigeri
berta...@ptitcanardnoir.org wrote (29 Sep 2013 12:13:24 GMT) :
 Oooch, you're right. I've just force updated the branch for it to be
 based on the stable one. Thanks for the reminder.

merged, pushed to origin + lizard, thanks.
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


Re: [Tails-dev] Please review and merge feature/keepassx_launcher

2013-09-29 Thread sajolida
On 29/09/13 14:42, intrigeri wrote:
 Alan wrote (25 Sep 2013 13:47:33 GMT) :
 I believe the feature/keepassx_launcher is now ready.
 ticket: https://labs.riseup.net/code/issues/5686

I built the branch and it works fine.

 Looks good, but the documentation needs to be updated accordingly:
 doc/first_steps/introduction_to_gnome_and_the_tails_desktop

I just did that with commit 943a44f. So I merged it into devel, and
marked the ticket as Fix committed.




signature.asc
Description: OpenPGP digital signature
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev


[Tails-dev] Please test and review feature/sdio

2013-09-29 Thread intrigeri
Hi,

feature/sdio adds support for SD cards plugged into a reader that's
wired as SDIO. Please test and review.

Tickets:
  - parent: #6324
  - liveusb-creator: #5744
  - persistence setup: #6325

The branch is called feature/sdio in the main Tails repo.
Same in our liveusb-creator and tails-persistence-setup ones.
These three branches are all that needs to be reviewed.

Merged into experimental, but I've not tested it there yet. I don't
expect any incompatibility with other changes sitting there,
but still.

One may try this feature with the latest nightly experimental ISO:

  http://nightly.tails.boum.org/build_Tails_ISO_experimental/

If you are waiting for Tails to support this kind of SD cards,
please test and report back ASAP. The idea is to merge this branch
mid-October to the latest, in time for the 0.21 freeze.

Documentation is left to be done (#6326), that's why I'm not
requesting a merge yet, but in short:

 - The installation  upgrade instructions now work as-is with SD cards.

 - The persistence setup  usage instructions now work as-is for SD cards.

 - The only SD card -specific quirk is booting from them: they're
   sometimes not exposed as removable, so by default Tails won't boot
   (safety measure), so there's a trick: if Tails fails to boot from
   a SD card, try removing live-media=removable to the kernel
   command-line (the same warnings that we added about this to the
   startup troubleshooting page apply). For improved security, instead
   of removing live-media=removable, append live-media=/dev/mmcblk0p1
   or similar (that one should be correct in the huge majority of
   cases). If either works, then edit the bootloader configuration
   accordingly (must be done after upgrades too) in
   syslinux/live{4,6}86.cfg on the system partition.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev