Re: [Tails-dev] About SquashFS default compression setting

2017-05-12 Thread anonym
intrigeri:
> anonym:
>> This change will require some coordination with our infra's sysadmins,
>> though, so it might take a while for it to be applied.
> 
> … unless "defaultcomp" remains unofficially supported for a little
> while, with a mere warning displayed, so that everyone learns about
> the transition they have to go through. I prefer such approaches to
> the flag day one that assumes everyone is on top of their tails-dev@
> backlog etc. :)

Right, that's much better!

Cheers!

___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] About SquashFS default compression setting

2017-05-12 Thread intrigeri
anonym:
> a ticket and patches renaming them to `fastcomp` and `releasecomp` (or 
> similar) would
> be welcome.

These names look OK to me.

> This change will require some coordination with our infra's sysadmins,
> though, so it might take a while for it to be applied.

… unless "defaultcomp" remains unofficially supported for a little
while, with a mere warning displayed, so that everyone learns about
the transition they have to go through. I prefer such approaches to
the flag day one that assumes everyone is on top of their tails-dev@
backlog etc. :)

Cheers!
-- 
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] About SquashFS default compression setting

2017-05-12 Thread anonym
Arnaud:
> Dear Tails,
> 
> this is just a detail I'd like to discuss.
> 
> When I did my first Tails build a while ago, I didn't specify any
> SquashFS compression setting. So I expected the compression to be the
> default. And amazingly, there's a setting called 'defaultcomp', which
> correspond to xz compression. So I was a bit surprised to see in the
> logs that I ended up with gzip compression instead.
> 
> What I'm trying to say is that, from the point of view of the person who
> builds Tails, there's no 'default' compression. The compression is
> automatically chosen by the build system: xz for release, gzip otherwise
> (tell me if I'm mistaken).
> 
> So I think it's a bit misleading to have a setting named 'defaultcomp',
> and it would be better named 'xzcomp'.
> 
> What do you think ? I can open an issue and provide a patch if you agree
> with me.

Yeah, and it even used to be even worse, cause we hadn't unambiguously defined 
when a "release build" should occur before, but since the recent rework of the 
build system this is well-defined (build a release if and only if HEAD is 
tagged). Any way, a ticket and patches renaming them to `fastcomp` and 
`releasecomp` (or similar) would be welcome. This change will require some 
coordination with our infra's sysadmins, though, so it might take a while for 
it to be applied.

Cheers!

___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

[Tails-dev] About SquashFS default compression setting

2017-05-11 Thread Arnaud
Dear Tails,

this is just a detail I'd like to discuss.

When I did my first Tails build a while ago, I didn't specify any
SquashFS compression setting. So I expected the compression to be the
default. And amazingly, there's a setting called 'defaultcomp', which
correspond to xz compression. So I was a bit surprised to see in the
logs that I ended up with gzip compression instead.

What I'm trying to say is that, from the point of view of the person who
builds Tails, there's no 'default' compression. The compression is
automatically chosen by the build system: xz for release, gzip otherwise
(tell me if I'm mistaken).

So I think it's a bit misleading to have a setting named 'defaultcomp',
and it would be better named 'xzcomp'.

What do you think ? I can open an issue and provide a patch if you agree
with me.

Cheers !


___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.