Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hi, applied, tested, released as Tails Greeter 0.8 (the migration to Wheezy deserves a version bump), and moved GdmGreeter_remove_media=removable.patch from the main Git repo to the Greeter's one. Merged into testing, devel and experimental. Congrats! Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hi, On Tue, 3 Jun 2014 20:47:18 + Andres Gomez Ramirez andres.go...@cern.ch wrote: However, I fail to understand the need of these changes: -builder.connect_signals(self.dialog) +builder.connect_signals(self) I made this change because in the current way (self.dialog) you obtain an error: handler cb_langdialog_button_press not found, OK. - why do you use self instead of data (use of data is advised in callbacks as far as I know)? I think that self.dialog should be replaced by data.dialog. Here it is the same as before if you use data.anything, then you have an error. Maybe there is a better way, but I failed to find how to do it in gtk3. Strange. But given your answers, I think this in not a blocker. Cheers ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hi, Alan, may we now consider that you've done a review (without tests) of Andres branch, and it passes? If so, then I'll try to test and merge this in time for 1.1. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hi, On Thu, 05 Jun 2014 15:27:59 +0200 intrigeri intrig...@boum.org wrote: Alan, may we now consider that you've done a review (without tests) of Andres branch, and it passes? If so, then I'll try to test and merge this in time for 1.1. Yes ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Alan wrote (05 Jun 2014 14:30:26 GMT) : intrigeri intrig...@boum.org wrote: Alan, may we now consider that you've done a review (without tests) of Andres branch, and it passes? If so, then I'll try to test and merge this in time for 1.1. Yes Thanks! Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hi, On Mon, 2 Jun 2014 20:11:51 + Andres Gomez Ramirez andres.go...@cern.ch wrote: I attached a patch for https://labs.riseup.net/code/issues/7344, Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough. Thanks for the patch. However, I fail to understand the need of these changes: -if isinstance(data, Gtk.Dialog): -data.response(True) +self.dialog.response(True) - why do you drop the check for a dialog? - why do you use self instead of data (use of data is advised in callbacks as far as I know)? I think that self.dialog should be replaced by data.dialog. The same questions applies for the next change. Cheers ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hi, However, I fail to understand the need of these changes: -builder.connect_signals(self.dialog) +builder.connect_signals(self) I made this change because in the current way (self.dialog) you obtain an error: handler cb_langdialog_button_press not found, -if isinstance(data, Gtk.Dialog): -data.response(True) +self.dialog.response(True) - why do you drop the check for a dialog? now, when the handler receives the data, it is empty (None), so the validation is always false. - why do you use self instead of data (use of data is advised in callbacks as far as I know)? I think that self.dialog should be replaced by data.dialog. Here it is the same as before if you use data.anything, then you have an error. Maybe there is a better way, but I failed to find how to do it in gtk3. Cheers, Kurono. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
[Tails-dev] FIx Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough
Hello, I attached a patch for https://labs.riseup.net/code/issues/7344, Bug #7344 Double-clicking on an entry in the language or keyboard layout lists is not enough. I also could try with this: https://labs.riseup.net/code/issues/5387 cheers, KuronoFrom 02444dae1b626c03d435551176f0baea18ada43a Mon Sep 17 00:00:00 2001 From: kurono andres.go...@cern.ch Date: Mon, 2 Jun 2014 22:00:17 +0200 Subject: [PATCH] Fix to Bug #7344: Double-clicking on an entry in the language or keyboard layout lists is not enough --- tailsgreeter/langpanel.py | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tailsgreeter/langpanel.py b/tailsgreeter/langpanel.py index df0eea7..b1cbfc9 100644 --- a/tailsgreeter/langpanel.py +++ b/tailsgreeter/langpanel.py @@ -38,7 +38,7 @@ class LangDialog(TranslatableWindow): self.dialog = builder.get_object(languages_dialog) self.treeview = builder.get_object(languages_treeview) self.liststore = builder.get_object(languages_liststore) -builder.connect_signals(self.dialog) +builder.connect_signals(self) tvcolumn = Gtk.TreeViewColumn(_(Language)) self.treeview.append_column(tvcolumn) @@ -51,15 +51,13 @@ class LangDialog(TranslatableWindow): def cb_langdialog_key_press(self, widget, event, data=None): Handle key press in langdialog if event.keyval in [ Gdk.KEY_Return, Gdk.KEY_KP_Enter ]: -if isinstance(data, Gtk.Dialog): -data.response(True) +self.dialog.response(True) def cb_langdialog_button_press(self, widget, event, data=None): Handle mouse click in langdialog -if (event.type == Gdk._2BUTTON_PRESS or -event.type == Gdk._3BUTTON_PRESS): -if isinstance(data, Gtk.Dialog): -data.response(True) +if (event.type == Gdk.EventType._2BUTTON_PRESS or +event.type == Gdk.EventType._3BUTTON_PRESS): +self.dialog.response(True) class LangPanel(TranslatableWindow): Display language and layout selection panel -- 1.8.3.2 ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
