Re: [Tails-dev] Fix: persistence: clearer warning at delete step
Andres Gomez Ramirez wrote (10 Nov 2013 20:24:28 GMT) : Andres, would you please have a look at what the GNOME HIG says (if you like formal specs), or more easily, just copy what `zenity --warning' does (it's likely that it just applies the specs)? Oh, you are right, I have fixed it according to GNOME HIG :) Much better! However, I think the icon should be left-aligned with the title and the rest of the text, instead of protruding in the left-margin. Do you think you can fix this? Long term wise, best would even be to fully follow the HIG regarding alert windows [1], but IMHO this can be kept for a later iteration, once the addition of the icon is merged. Besides, the way t-p-s is implemented doesn't make it very easy: among all steps (create, configure, delete), only deletion should be an alert window, but in practice they share the same basic window. So well, just adding the relevant icon in the right place will be good enough for now, and a very useful improvement :) [1] https://developer.gnome.org/hig-book/stable/windows-alert.html.en Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Fix: persistence: clearer warning at delete step
Andres Gomez Ramirez wrote (10 Nov 2013 20:24:28 GMT) : I've quickly tried it, and it works fine *but* [...] I also see a regression in the last version of the patch: the icon stays displayed even in the Finished screen. I doubt it was intended, and it doesn't look too good. Likely it should be hidden in some callback, perhaps in the operation_finished one. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Fix: persistence: clearer warning at delete step
Hi, Andres Gomez Ramirez wrote (09 Nov 2013 23:25:26 GMT) : Meanwhile I get how to deal with feature #5917, I send a patch for the feature #5888 persistence: clearer warning at delete step https://labs.riseup.net/code/issues/5888 Great! I've quickly tried it, and it works fine *but* the placement of the icon (centered, alone on top of the window) looks quite weird to me. Andres, would you please have a look at what the GNOME HIG says (if you like formal specs), or more easily, just copy what `zenity --warning' does (it's likely that it just applies the specs)? Note to other reviewers: bugfix/persistence-cleanups has to be merged first anyway (hint ;) and I'll take a look of https://labs.riseup.net/code/issues/5311. Good :) Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Fix: persistence: clearer warning at delete step
I've quickly tried it, and it works fine *but* the placement of the
icon (centered, alone on top of the window) looks quite weird to me.
Andres, would you please have a look at what the GNOME HIG says (if
you like formal specs), or more easily, just copy what
`zenity --warning' does (it's likely that it just applies the specs)?
Oh, you are right, I have fixed it according to GNOME HIG :)
Oh, BTW: if you want more privs on Redmine, so that e.g. you could
have marked the relevant ticket as ready for QA, and assign it to the
current RM (me), just tell me what's your login there.
ok great, my user is kurono.
Cheers,
Andres
From 9b061467b7485187639cc62f2a926eb368c613d8 Mon Sep 17 00:00:00 2001
From: kurono andres.go...@cern.ch
Date: Sun, 10 Nov 2013 21:00:45 +0100
Subject: [PATCH] persistence: clearer warning at delete step
---
lib/Tails/Persistence/Step/Delete.pm |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/Tails/Persistence/Step/Delete.pm b/lib/Tails/Persistence/Step/Delete.pm
index 1a7cfd5..a3cee87 100644
--- a/lib/Tails/Persistence/Step/Delete.pm
+++ b/lib/Tails/Persistence/Step/Delete.pm
@@ -58,9 +58,14 @@ sub _build_main_box {
my $self = shift;
my $box = Gtk2::VBox-new();
+my $hbox = Gtk2::HBox-new();
+my $image = Gtk2::Image-new_from_stock(gtk-dialog-warning, GTK_ICON_SIZE_DIALOG);
$box-set_spacing(6);
+
$box-pack_start($self-title, FALSE, FALSE, 0);
-$box-pack_start($self-subtitle, FALSE, FALSE, 0);
+$hbox-pack_start($image, FALSE, FALSE, 0);
+$hbox-pack_start($self-subtitle, FALSE, FALSE, 0);
+$box-pack_start($hbox, FALSE, FALSE, 0);
$box-pack_start($self-description, FALSE, FALSE, 0);
$box-pack_start($self-status_area, FALSE, FALSE, 0);
--
1.7.9.5
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
[Tails-dev] Fix: persistence: clearer warning at delete step
Hi,
Meanwhile I get how to deal with feature #5917, I send a patch for the feature
#5888 persistence: clearer warning at delete step
https://labs.riseup.net/code/issues/5888 and I'll take a look of
https://labs.riseup.net/code/issues/5311.
Cheers,
AndresFrom ce7b1451052f86f340fb5ca42a297bc1eba8e060 Mon Sep 17 00:00:00 2001
From: kurono andres.go...@cern.ch
Date: Sun, 10 Nov 2013 00:15:35 +0100
Subject: [PATCH] persistence: clearer warning at delete step
---
lib/Tails/Persistence/Step/Delete.pm |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/Tails/Persistence/Step/Delete.pm b/lib/Tails/Persistence/Step/Delete.pm
index 1a7cfd5..5ddfa4e 100644
--- a/lib/Tails/Persistence/Step/Delete.pm
+++ b/lib/Tails/Persistence/Step/Delete.pm
@@ -58,7 +58,9 @@ sub _build_main_box {
my $self = shift;
my $box = Gtk2::VBox-new();
+my $image = Gtk2::Image-new_from_stock(gtk-dialog-warning, GTK_ICON_SIZE_DIALOG);
$box-set_spacing(6);
+$box-pack_start($image, FALSE, FALSE, 0);
$box-pack_start($self-title, FALSE, FALSE, 0);
$box-pack_start($self-subtitle, FALSE, FALSE, 0);
$box-pack_start($self-description, FALSE, FALSE, 0);
--
1.7.9.5
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
