Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
21/02/14 11:41, intrigeri wrote: > anonym wrote (21 Feb 2014 03:20:36 GMT) : >> I want to merge this, but I'm tempted to delay it until some of the >> other Tails Greeter merges are also in, to avoid some of the packaging >> overhead. Therefore I also leave the ticket as is until I actually merge >> it. Does this make sense? > > Why not. I'm not fond of delaying this 2 months old merge request any > longer, but well, I see what you mean. Practically speaking, this > means that the one who will review and merge the bridges or MAC > spoofing branch (whichever is ready first) will need to merge that one > at the same time, right? Actually I was only talking about branches that *I* was about to potentially merge. I thought there were a couple, but apparently there was only one (#5594) which maybe won't even make it. Oh well, the seeing as you have merged the branch (in both repos) and made a new t-g release, we can just forget about this. Sorry for the inconvenience! Cheers! ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
Hi, FTR, I've merged this branch at the same time as I was merging feature/spoof-mac. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
anonym wrote (21 Feb 2014 03:20:36 GMT) : > I want to merge this, but I'm tempted to delay it until some of the > other Tails Greeter merges are also in, to avoid some of the packaging > overhead. Therefore I also leave the ticket as is until I actually merge > it. Does this make sense? Why not. I'm not fond of delaying this 2 months old merge request any longer, but well, I see what you mean. Practically speaking, this means that the one who will review and merge the bridges or MAC spoofing branch (whichever is ready first) will need to merge that one at the same time, right? If I'm correct, then please mark the ticket as blocked by the one, among bridges support and MAC spoofing, that you believe will be ready for merging first, and please add a note to the blocking ticket so that the reviewer remembers they should do it. ... or just decide that the organization overhead would actually take more time than just releasing a new t-g with that branch in :P Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
22/12/13 20:09, intrigeri wrote:
> Hi,
>
> please review feature/5588-no-autologin-consoles and merge it into
> devel, candidate for 0.23. Ticket = #5588.
>
> There's a branch in our main repo + another one (same name) with
> a snapshot version in the greeter repo, so the merge implies to
> release tails-greeter 0.7.23.
Code review passed without comment.
Everything seemed to work as intended during testing. (I had to build a
new t-g snapshot with master merged into it (just for testing purposes,
not uploaded or pushed) since the one in the APT suite is so old (based
on 0.23) that t-g 0.24 is pulled instead.)
Great work!
> Note that there's one potentially non-consensual in there:
[...]
> * Seriously, the intended users (debugging for developers or
> power-users) can
>as well `loadkeys' their preferred layout.
I agree. However, typing `sudo loadkeys ${keymap}` and perhaps in
particular the password, which have no visual feedback, may be pretty
awkward even for power users that are used to some particularly non-us
layouts. :) Short of a way to change the keymap without root privileges
I suppose we're stuck with this.
Given that two months have passed without objection, I think we have
consensus.
I want to merge this, but I'm tempted to delay it until some of the
other Tails Greeter merges are also in, to avoid some of the packaging
overhead. Therefore I also leave the ticket as is until I actually merge
it. Does this make sense?
Cheers!
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to
tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
intrigeri wrote (22 Dec 2013 19:09:23 GMT) : > please review feature/5588-no-autologin-consoles and merge it into > devel, candidate for 0.23. Ticket = #5588. > There's a branch in our main repo + another one (same name) with > a snapshot version in the greeter repo, so the merge implies to > release tails-greeter 0.7.23. > Assigned to the 0.23 RM for review, but I bet anonym would not mind if > someone beat him to it. > Note that there's one potentially non-consensual in there: > commit 1337104f82a6c6aa03eb7f5ed995761ce07fdf92 > Author: Tails developers > Date: Sun Dec 22 18:03:16 2013 + > Drop console localization profile.d snippet. > We don't autologin the consoles anymore, so we don't need something this > complicated anymore. I could not bother myself to adapt and simplify it > as: > * It's broken on feature/wheezy (#5583) and I see little use in spending > any >time on this feature at this point. > * Seriously, the intended users (debugging for developers or > power-users) can >as well `loadkeys' their preferred layout. > * The removed snippet required tails-greeter to give the "amnesia" user > the >right to run "setupcon" as root. Ping? Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
[Tails-dev] Please review'n'merge feature/5588-no-autologin-consoles
Hi, please review feature/5588-no-autologin-consoles and merge it into devel, candidate for 0.23. Ticket = #5588. There's a branch in our main repo + another one (same name) with a snapshot version in the greeter repo, so the merge implies to release tails-greeter 0.7.23. Assigned to the 0.23 RM for review, but I bet anonym would not mind if someone beat him to it. Note that there's one potentially non-consensual in there: commit 1337104f82a6c6aa03eb7f5ed995761ce07fdf92 Author: Tails developers Date: Sun Dec 22 18:03:16 2013 + Drop console localization profile.d snippet. We don't autologin the consoles anymore, so we don't need something this complicated anymore. I could not bother myself to adapt and simplify it as: * It's broken on feature/wheezy (#5583) and I see little use in spending any time on this feature at this point. * Seriously, the intended users (debugging for developers or power-users) can as well `loadkeys' their preferred layout. * The removed snippet required tails-greeter to give the "amnesia" user the right to run "setupcon" as root. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
