Re: [Tails-dev] Please review'n'merge test/rjb-migration
On Fri, Dec 27, 2013 at 07:36:15PM +0100, intrigeri wrote: berta...@ptitcanardnoir.org wrote (27 Dec 2013 09:36:32 GMT) : Just one word to sum up my feelings: hurray! :) :) The test suite is now entirely green for me, with the two known exceptions that are documented (git grep XXX -- features). Please review my changes and merge it into devel if it looks good! Tickets that will go away: #6314, #6399. Done, merged into devel, haven't seen the test suite in such a good shape since a long time, congrats! The parent ticket (#5731) is still blocked by #6400, as nobody commited to either upstream our stuff into the ruby-sikuli Gem, or to maintain our own adapter on the long term. I'm unsure what conclusion we should draw of it. Admitedly, the new setup is way less scary than the previous one, and our adapter is 85 lines long, but still, I'm concerned we might happily be replacing it with another kind of technical debt. Shall we just forget about it and close #6400 as rejected? Thoughts? I've had a quick look at a way to implement that upstream. Using the RUBY_ENGINE variable, it seems easy to have the gem selecting the right handler depending on which interpreter is used. Still there are some subtilities in our code that I'm not sure to understand, this is quite low level, and I'm not sure to be able to handle this upstreaming myself alone. In particular, I'd like to hear what anonym thinks of it. Me too. :) bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
On Fri, Dec 27, 2013 at 01:16:05AM +0100, intrigeri wrote: intrigeri wrote (26 Dec 2013 18:17:21 GMT) : I don't want to merge this branch with so many failing tests, as one expected failure (e.g. due to a missing image update) may very well hide other issues that might be caused by the migration to RJB. So, I've started fixing every test case I could. Doing this in the test/rjb-migration branch too, even if it doesn't 100% belong here, because IMO this goes with merging this branch. In the state where I've brought test/rjb-migration today, all tests now pass but: * the USB -related tests. Reported as #6537. I'm going to try and fix those now. I believe I've done what #6537 was about, but this feature still fails for me a bit later (#6539). I'll try re-running it entirely, but well, seeing the installer stuck at various stages of the process is no news, and that's why we have never removed these steps from the manual test suite yet. So IMO this is not a blocker. * the Windows should appear like those in Microsoft Windows XP scenario: in 0.22, the browser's title bar displays the Iceweasel icon, instead of the IE one, so it looks like the Windows camouflage script misses an update for FF24. Reported as #6536, will try to fix in time for 0.22.1 as it's a regression. I'm testing a fix for this. Once I'm done with validating this part of the test suite, I'll ask bertagaz to review all the commits I've added on top of what he submitted, and to merge the branch. Stay tuned, we're getting close :) /me is very happy to be able to run this test suite in good conditions, finally! I am too, and find it is running quicker than when using Jruby. I intended to start to fix the outdated scenarios in another branch, as when I asked for the merge, the rjb test suite was running as good (or bad, depends how we see) as the previous Jruby implementation, failing at the same places. So I thought there were no regressions, and the branch was ok for a merge. But you spend time doing it (and having fun hacking it seems), and it's great. I'll reserve some time to test it when you'll send your review'n'merge. Just one word to sum up my feelings: hurray! :) bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
berta...@ptitcanardnoir.org wrote (27 Dec 2013 09:36:32 GMT) : Just one word to sum up my feelings: hurray! :) :) The test suite is now entirely green for me, with the two known exceptions that are documented (git grep XXX -- features). Please review my changes and merge it into devel if it looks good! Tickets that will go away: #6314, #6399. The parent ticket (#5731) is still blocked by #6400, as nobody commited to either upstream our stuff into the ruby-sikuli Gem, or to maintain our own adapter on the long term. I'm unsure what conclusion we should draw of it. Admitedly, the new setup is way less scary than the previous one, and our adapter is 85 lines long, but still, I'm concerned we might happily be replacing it with another kind of technical debt. Shall we just forget about it and close #6400 as rejected? Thoughts? In particular, I'd like to hear what anonym thinks of it. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
On Wed, Dec 25, 2013 at 08:36:57PM +0100, intrigeri wrote: berta...@ptitcanardnoir.org wrote (24 Dec 2013 11:39:27 GMT) : and then run the test suite. I get the same error you had a week ago or so: Call to virDomainCreateWithFlags failed: unsupported configuration: ich9-usb-ehci1 not supported in this QEMU binary (Libvirt::Error) How did you fix this? If I'm the second one to hit it, perhaps this should be documented? To be honest, it did get fixed almost by itself. I just played a bit manually with virsh to create the VM while trying to understand the issue, and at some point it did worked. As I didn't changed anything really, in the host configuration nor in the VM one, I assumed I did something wrong at first and there were in fact no issue at all. I also did a search on Debian's BTS and qemu/libvirt sources to find reports or changes that might be related, but found nothing. Did you restart the computer/VM where you installed the test suite after having done so? I remember I did, that might be why I had it to work. If you get this issue too, sure it needs to be documented. But we have to understand it first. :) bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
berta...@ptitcanardnoir.org wrote (26 Dec 2013 10:03:06 GMT) : How did you fix this? If I'm the second one to hit it, perhaps this should be documented? To be honest, it did get fixed almost by itself. [...] Did you restart the computer/VM where you installed the test suite after having done so? I remember I did, that might be why I had it to work. I've rebooted the system and it now works! If you get this issue too, sure it needs to be documented. But we have to understand it first. :) Added `service libvirt-bin restart' to the documentation. Hopefully this will be enough. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
intrigeri wrote (25 Dec 2013 19:57:34 GMT) : I've merged devel into this branch, and pushed a few minor improvements on top. Once the issue reported in my other mail is solved and I can run the test suite, I'll look further. I'm looking further. I don't want to merge this branch with so many failing tests, as one expected failure (e.g. due to a missing image update) may very well hide other issues that might be caused by the migration to RJB. So, I've started fixing every test case I could. Doing this in the test/rjb-migration branch too, even if it doesn't 100% belong here, because IMO this goes with merging this branch. In the state where I've brought test/rjb-migration today, all tests now pass but: * the USB -related tests. Reported as #6537. I'm going to try and fix those now. * the Windows should appear like those in Microsoft Windows XP scenario: in 0.22, the browser's title bar displays the Iceweasel icon, instead of the IE one, so it looks like the Windows camouflage script misses an update for FF24. Reported as #6536, will try to fix in time for 0.22.1 as it's a regression. Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
intrigeri wrote (26 Dec 2013 18:17:21 GMT) : I don't want to merge this branch with so many failing tests, as one expected failure (e.g. due to a missing image update) may very well hide other issues that might be caused by the migration to RJB. So, I've started fixing every test case I could. Doing this in the test/rjb-migration branch too, even if it doesn't 100% belong here, because IMO this goes with merging this branch. In the state where I've brought test/rjb-migration today, all tests now pass but: * the USB -related tests. Reported as #6537. I'm going to try and fix those now. I believe I've done what #6537 was about, but this feature still fails for me a bit later (#6539). I'll try re-running it entirely, but well, seeing the installer stuck at various stages of the process is no news, and that's why we have never removed these steps from the manual test suite yet. So IMO this is not a blocker. * the Windows should appear like those in Microsoft Windows XP scenario: in 0.22, the browser's title bar displays the Iceweasel icon, instead of the IE one, so it looks like the Windows camouflage script misses an update for FF24. Reported as #6536, will try to fix in time for 0.22.1 as it's a regression. I'm testing a fix for this. Once I'm done with validating this part of the test suite, I'll ask bertagaz to review all the commits I've added on top of what he submitted, and to merge the branch. Stay tuned, we're getting close :) /me is very happy to be able to run this test suite in good conditions, finally! Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review'n'merge test/rjb-migration
berta...@ptitcanardnoir.org wrote (24 Dec 2013 11:39:27 GMT) : Test process of this branch should be to start from a fresh Wheezy installation (on bare metal or in a VM), and install all the necessary packages, Done. and then run the test suite. I get the same error you had a week ago or so: Call to virDomainCreateWithFlags failed: unsupported configuration: ich9-usb-ehci1 not supported in this QEMU binary (Libvirt::Error) How did you fix this? If I'm the second one to hit it, perhaps this should be documented? Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
[Tails-dev] Please review'n'merge test/rjb-migration
Hi, Now that a more recent libvirt containing patches to support the removable flag for USB devices has been uploaded to Wheezy-backports, I've updated the test/rjb-migration feature branch so that installation now is easy for anyone running Wheezy. Test process of this branch should be to start from a fresh Wheezy installation (on bare metal or in a VM), and install all the necessary packages, following https://tails.boum.org/contribute/release_process/test/setup, and then run the test suite. Failures that might appear should be related to outdated scenarios or steps rather than libvirt or rjb problems. If happy with it, please merge it into devel and experimental. Tickets to take care of should be #6399 and #6314. Congrats goes to anonym, who did great work for this migration. I just tested it works and updated the documentation. bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
