Re: [Tails-dev] [review'n'merge] grammar correction for whisperback

2018-05-22 Thread sajolida
intrigeri:
> intrigeri:
>> emma peel:
>>> please review this patch with a grammar correction for WhisperBack.
> 
>> Thanks, this looks good to me. I'll apply this once bertagaz has
>> pushed […]
> 
> I've now applied this patch even though it's debatable whether this is
> a grammar correction:
> 
>   https://en.wikipedia.org/wiki/Serial_comma
> 
> (I've not found any guidance about it in our doc style guide.)

I've used serial commas consistently for years. See the many commits
referring to 'serial comma'.

I now added it to our style guide with 3037353da0 :)

In some cases a serial comma can change the meaning of a sentence so I
think it's grammar.

-- 
sajolida
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] [review'n'merge] grammar correction for whisperback

2018-05-22 Thread Austin English
On Tue, May 22, 2018, 02:00 emma peel  wrote:

> intrigeri:
> > intrigeri:
> >> emma peel:
> >>> please review this patch with a grammar correction for WhisperBack.
> >
> >> Thanks, this looks good to me. I'll apply this once bertagaz has
> >> pushed […]
> >
> > I've now applied this patch even though it's debatable whether this is
> > a grammar correction:
> >
> >   https://en.wikipedia.org/wiki/Serial_comma
>
> Any native speakers around? I want to add the 'or' but I have no
> preferences regarding the comma...
>
> ___
> Tails-dev mailing list
> Tails-dev@boum.org
> https://mailman.boum.org/listinfo/tails-dev
> To unsubscribe from this list, send an empty email to
> tails-dev-unsubscr...@boum.org.


Native (American) speaker. I typically use the Oxford comma. To me this
change is fine, though I can't speak for British English.
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] [review'n'merge] grammar correction for whisperback

2018-05-22 Thread emma peel
intrigeri:
> intrigeri:
>> emma peel:
>>> please review this patch with a grammar correction for WhisperBack.
> 
>> Thanks, this looks good to me. I'll apply this once bertagaz has
>> pushed […]
> 
> I've now applied this patch even though it's debatable whether this is
> a grammar correction:
> 
>   https://en.wikipedia.org/wiki/Serial_comma

Any native speakers around? I want to add the 'or' but I have no preferences 
regarding the comma...



signature.asc
Description: OpenPGP digital signature
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] [review'n'merge] grammar correction for whisperback

2018-05-21 Thread intrigeri
intrigeri:
> emma peel:
>> please review this patch with a grammar correction for WhisperBack.

> Thanks, this looks good to me. I'll apply this once bertagaz has
> pushed […]

I've now applied this patch even though it's debatable whether this is
a grammar correction:

  https://en.wikipedia.org/wiki/Serial_comma

(I've not found any guidance about it in our doc style guide.)

Cheers,
-- 
intrigeri
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] [review'n'merge] grammar correction for whisperback

2018-04-29 Thread intrigeri
emma peel:
> please review this patch with a grammar correction for WhisperBack.

Thanks, this looks good to me. I'll apply this once bertagaz has
pushed to whisperback.git the changes he made during the 3.6 release
(#15440).
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.