Re: [Tails-dev] Please review bugfix/default_search_engines
Hi, Ague Mill wrote (28 Sep 2012 10:12:33 GMT) : Done. Have a look at commit d3ebdba5. Static review: I like it, but the use of LANG as a loop variable name, which seems to be an unecessary risk to me, when a variable that causes less side-effects could be used just as well. I'll change the name, build a test ISO and merge soon :) Added to the branch, then (commit 5ba8642). That did not work without another changes (commit 966f639). Oops, sorry. Thanks a lot for catching my mistake. Cheers! -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review bugfix/default_search_engines
Merged into devel and stable :) ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review bugfix/default_search_engines
On Thu, Sep 27, 2012 at 10:27:34AM +0200, intrigeri wrote: Ague Mill wrote (26 Sep 2012 10:43:31 GMT) : Do you have any idea of how to do it better? The only one that comes up to my mind is that we move all search plugins somewhere else in the chroot tree and use a local hook to add links in directories corresponding to given the installed localization package set. It feels unnecessarily complicated. I agree it is a bit complicated, but I disagree on the unnecessarily part: I think it's the only way to fix this bug in a robust way, that is, to avoid seeing this bug re-appear, without us noticing, as soon as the list of iceweasel localization packages changes (e.g. if fr_BE appears, or if es_MX disappears). We don't want to test every language setting at release time for such regressions. Done. Have a look at commit d3ebdba5. f9d73a5 Be consistent when giving a locale to check.torproject.org OK, great. (FTR, the previous setting made sense when our syslinux menu allowed to pick Portuguese, and that's all -- considering there are many more Portuguese speakers in Brasil than in Portugal.) I have a feeling that this commit is too much or too little, and causes a tiny regression for Brasilian users -- while we're at it, we should add support for pt-BR in our branding extension. Yes, that'd be the way to go. Added to the branch, then (commit 5ba8642). That did not work without another changes (commit 966f639). -- Ague pgpY9dkqtH4hM.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review bugfix/default_search_engines
Hi, Ague Mill wrote (25 Sep 2012 22:06:33 GMT) : The branch bugfix/default_search_engines fixes the default search engine selected for Portugese and Spanish. Great! Short log: 46a7885 Fix localized search plugins for 'es' and 'pt' I quite dislike the file duplication. Can't the copying be done in a chroot_local-hook? Also, by reading the commit message, it's unclear why only these specific locales are supported, instead of all Spanish-speaking and Portuguese-speaking countries. I think there are something like two dozens countries that speak mainly Spanish, rather than 4. So, perhaps the file copying should happen quite more heavily (one more reason to automate it :) f9d73a5 Be consistent when giving a locale to check.torproject.org OK, great. (FTR, the previous setting made sense when our syslinux menu allowed to pick Portuguese, and that's all -- considering there are many more Portuguese speakers in Brasil than in Portugal.) I have a feeling that this commit is too much or too little, and causes a tiny regression for Brasilian users -- while we're at it, we should add support for pt-BR in our branding extension. But this is only a remark in passing, and clearly no blocker for merging IMHO. 47629ce Update bug status and known issues Candidate for next release (point or major). Cheers, -- intrigeri | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review bugfix/default_search_engines
On Wed, Sep 26, 2012 at 12:22:30PM +0200, intrigeri wrote: Ague Mill wrote (25 Sep 2012 22:06:33 GMT) : The branch bugfix/default_search_engines fixes the default search engine selected for Portugese and Spanish. Great! Short log: 46a7885 Fix localized search plugins for 'es' and 'pt' I quite dislike the file duplication. Can't the copying be done in a chroot_local-hook? Also, by reading the commit message, it's unclear why only these specific locales are supported, instead of all Spanish-speaking and Portuguese-speaking countries. I think there are something like two dozens countries that speak mainly Spanish, rather than 4. So, perhaps the file copying should happen quite more heavily (one more reason to automate it :) These directories match Iceweasel localization packages. For 'es': * iceweasel-l10n-es-ar * iceweasel-l10n-es-cl * iceweasel-l10n-es-es * iceweasel-l10n-es-mx For 'pt': * iceweasel-l10n-pt-br * iceweasel-l10n-pt-pt Do you have any idea of how to do it better? The only one that comes up to my mind is that we move all search plugins somewhere else in the chroot tree and use a local hook to add links in directories corresponding to given the installed localization package set. It feels unnecessarily complicated. f9d73a5 Be consistent when giving a locale to check.torproject.org OK, great. (FTR, the previous setting made sense when our syslinux menu allowed to pick Portuguese, and that's all -- considering there are many more Portuguese speakers in Brasil than in Portugal.) I have a feeling that this commit is too much or too little, and causes a tiny regression for Brasilian users -- while we're at it, we should add support for pt-BR in our branding extension. Yes, that'd be the way to go. -- Ague pgpT28P71ZLwX.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
