Re: [Tails-dev] Please review web/8213-call-for-donations
Hi, sajolida wrote (28 Nov 2014 12:22:55 GMT) : > So I moved it to wiki/src/news/who_are_you_helping/include.html. There > it can be translated and it's not inlined in the News feed. Good. Pushed, with commits 99091ac and ebd21786 on top, otherwise I fear that translators don't get it right (and without it, I couldn't test that the inline + translate actually worked). Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review web/8213-call-for-donations
intrigeri: > sajolida wrote (27 Nov 2014 11:14:29 GMT) : >> So problem solved with 66f4311. > >>> On the News page, I see the highlight twice: once on top, and a second >>> time with a "who are you helping.include" title, as the first >>> news item. > >> Fixed as well with fd8d477. > > I see two problems with putting it at the root of the srcdir: > > 1. It needlessly clutters this namespace. We have the wiki/src/inc/ >directory for this kind of things. > 2. It's not translatable anymore. (Granted, inc/* isn't, only some >specific files in there are.) > > I think both are blockers. OK, it's only temporary, so I could > probably be convinced to look elsewhere and ignore the first one. > But #2 is more annoying, especially since we've done the work to make > the "Donate" page translatable. So I moved it to wiki/src/news/who_are_you_helping/include.html. There it can be translated and it's not inlined in the News feed. >> So please do a final review and merge this branch, ideally today or >> tomorrow. Then it will be up on the week-end and until Tuesday when we >> release. > > Maybe call for translations, then? I always forget that kind of stuff :( It's done now. I would still like to have this publish today or tomorrow because of the proximity with the release coming up on Tuesday... If you think that's fine to not have it translated from the beginning. -- sajolida ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review web/8213-call-for-donations
hi, sajolida wrote (27 Nov 2014 11:14:29 GMT) : > So problem solved with 66f4311. >> On the News page, I see the highlight twice: once on top, and a second >> time with a "who are you helping.include" title, as the first >> news item. > Fixed as well with fd8d477. I see two problems with putting it at the root of the srcdir: 1. It needlessly clutters this namespace. We have the wiki/src/inc/ directory for this kind of things. 2. It's not translatable anymore. (Granted, inc/* isn't, only some specific files in there are.) I think both are blockers. OK, it's only temporary, so I could probably be convinced to look elsewhere and ignore the first one. But #2 is more annoying, especially since we've done the work to make the "Donate" page translatable. >> Also, s/share them with us/share it with us/ (one should ask a native >> speaker, but I don't think that "them" applies to things). > I searched wiktionary and The Chicago Manual of Style for that and > couldn't find anything going in your direction. "It" is the singular > third person, and "them" the plural third person. Thanks for correcting me! :) > So please do a final review and merge this branch, ideally today or > tomorrow. Then it will be up on the week-end and until Tuesday when we > release. Maybe call for translations, then? Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review web/8213-call-for-donations
intrigeri: > What's the plan regarding the version of the website that we ship in > the ISO? Do we want to display the same highlights? If so, then the > "Discover who you are helping around the world when donating to Tails" > on the homepage should be fixed. (Wouldn't an ikiwiki link work, by > the way?) Hmm... I really thought that ikiwiki links didn't work from inside HTML code. But I tried again and yes it works. Now I realize that probably markdown (links) don't work from inside HTML which makes sense. So problem solved with 66f4311. > On the News page, I see the highlight twice: once on top, and a second > time with a "who are you helping.include" title, as the first > news item. Fixed as well with fd8d477. > Also, s/share them with us/share it with us/ (one should ask a native > speaker, but I don't think that "them" applies to things). I searched wiktionary and The Chicago Manual of Style for that and couldn't find anything going in your direction. "It" is the singular third person, and "them" the plural third person. In the CMOS I also found this example: "the cargo tanks were inerted by introducing carbon dioxide into them" which goes in my direction. So please do a final review and merge this branch, ideally today or tomorrow. Then it will be up on the week-end and until Tuesday when we release. I'll pop it on top again in two weeks or so. We haven't heard back from the people mentioned in the post but I wrote them on Sunday so I think it is fine to go forward. -- sajolida ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review web/8213-call-for-donations
> I like the solution as is. It fits well with the current website layout > and is not too intrusive imho. Good. > Concerning the text, there should be no comma after "But". Fixed in a34f7cd. -- sajolida ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review web/8213-call-for-donations
Hi, Great work! What's the plan regarding the version of the website that we ship in the ISO? Do we want to display the same highlights? If so, then the "Discover who you are helping around the world when donating to Tails" on the homepage should be fixed. (Wouldn't an ikiwiki link work, by the way?) On the News page, I see the highlight twice: once on top, and a second time with a "who are you helping.include" title, as the first news item. So, in the end the only way I've found to read the news on a local copy of the website was to manually navigate through the filesystem. Also, s/share them with us/share it with us/ (one should ask a native speaker, but I don't think that "them" applies to things). Cheers, -- intrigeri ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
Re: [Tails-dev] Please review web/8213-call-for-donations
Hi, sajolida wrote: > People from Tails, also have a look at the screenshots in attachment for > the highlights that I propose to add to the website on the index and > news pages. I like the solution as is. It fits well with the current website layout and is not too intrusive imho. Concerning the text, there should be no comma after "But". Thanks for working on it! Cheers, u. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.
