Re: [Talk-us] buggy buildings in Maryland
+1 to Elliot Plack's proposal to use Simplify to remove the redundant nodes from the poor quality imported buildings. In fact, I did this myself for another massive import: User "jumbanho" imported buildings for the large city of Raleigh, NC back in January 2010. There were lots of degenerate nodes, which I cleaned up in batches using JOSM's simplify. I did most of the cleanup in 2015. -Ben On Mon, Aug 20, 2018 at 5:30 AM Elliott Plack wrote: > > Here's a potential fix: use the SimplifyArea JOSM Plugin. > https://wiki.openstreetmap.org/wiki/JOSM/Plugins/SimplifyArea > > The plugin is built for fixing over-noded and buggy imports. > > As a test, I downloaded the plugin and then downloaded some of Annapolis > sailor's buildings. > > This building should only contain four nodes: > https://www.openstreetmap.org/way/525751797 > > This building should only contain eight nodes: > https://www.openstreetmap.org/way/526209538 > > The plugin successfully reduced the nodes for both buildings without > affecting the shape, unlike the simplify way tool. > > I tested it on a larger swath of 500 buildings and it took less than a second > to run. > > I haven't uploaded any of the changes yet, but I think this would be a good > path forward. > > On Thu, Aug 16, 2018 at 8:02 PM Frederik Ramm wrote: >> >> Hi, >> >> On 08/16/2018 08:08 PM, Elliott Plack wrote: >> > I'd say go ahead and remove the extraneous nodes >> >> This has now been done. >> >> > and also any buildings >> > that are either version 0 or do not have any new tags (like names or >> > addresses) >> >> It appears that of the 177,151 buildings still there, only 29,513 have >> tags other than building=*. In most cases, these other tags are >> addr:street and addr:housenumber. >> >> I'll let this rest for a bit to give others a chance to chime in. >> >> Bye >> Frederik >> >> -- >> Frederik Ramm ## eMail frede...@remote.org ## N49°00'09" E008°23'33" >> >> ___ >> Talk-us mailing list >> Talk-us@openstreetmap.org >> https://lists.openstreetmap.org/listinfo/talk-us > > -- > Elliott Plack > http://elliottplack.me > ___ > Talk-us mailing list > Talk-us@openstreetmap.org > https://lists.openstreetmap.org/listinfo/talk-us ___ Talk-us mailing list Talk-us@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-us
Re: [Talk-us] buggy buildings in Maryland
Here's a potential fix: use the SimplifyArea JOSM Plugin. https://wiki.openstreetmap.org/wiki/JOSM/Plugins/SimplifyArea The plugin is built for fixing over-noded and buggy imports. As a test, I downloaded the plugin and then downloaded some of Annapolis sailor's buildings. This building should only contain four nodes: https://www.openstreetmap.org/way/525751797 This building should only contain eight nodes: https://www.openstreetmap.org/way/526209538 The plugin successfully reduced the nodes for both buildings without affecting the shape, unlike the simplify way tool. I tested it on a larger swath of 500 buildings and it took less than a second to run. I haven't uploaded any of the changes yet, but I think this would be a good path forward. On Thu, Aug 16, 2018 at 8:02 PM Frederik Ramm wrote: > Hi, > > On 08/16/2018 08:08 PM, Elliott Plack wrote: > > I'd say go ahead and remove the extraneous nodes > > This has now been done. > > > and also any buildings > > that are either version 0 or do not have any new tags (like names or > > addresses) > > It appears that of the 177,151 buildings still there, only 29,513 have > tags other than building=*. In most cases, these other tags are > addr:street and addr:housenumber. > > I'll let this rest for a bit to give others a chance to chime in. > > Bye > Frederik > > -- > Frederik Ramm ## eMail frede...@remote.org ## N49°00'09" E008°23'33" > > ___ > Talk-us mailing list > Talk-us@openstreetmap.org > https://lists.openstreetmap.org/listinfo/talk-us > -- Elliott Plack http://elliottplack.me ___ Talk-us mailing list Talk-us@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-us
Re: [Talk-us] buggy buildings in Maryland
Hi, On 08/16/2018 08:08 PM, Elliott Plack wrote: > I'd say go ahead and remove the extraneous nodes This has now been done. > and also any buildings > that are either version 0 or do not have any new tags (like names or > addresses) It appears that of the 177,151 buildings still there, only 29,513 have tags other than building=*. In most cases, these other tags are addr:street and addr:housenumber. I'll let this rest for a bit to give others a chance to chime in. Bye Frederik -- Frederik Ramm ## eMail frede...@remote.org ## N49°00'09" E008°23'33" ___ Talk-us mailing list Talk-us@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-us
Re: [Talk-us] buggy buildings in Maryland
Thanks for bringing this up, Frederik. I reached out to the user in a changeset and a mail thread (links below) and was under the impression that they would fix the problem. Was that really two years ago? https://www.openstreetmap.org/changeset/41375854 - changeset https://gist.github.com/talllguy/7d813ece238f359317786a18f7b7bbcb - message thread copy I'd say go ahead and remove the extraneous nodes and also any buildings that are either version 0 or do not have any new tags (like names or addresses). The Microsoft buildings could replace any buildings that are only footprints. If you can cull this down to those with some information besides the geometry alone, the community can fill in the blanks. On Thu, Aug 16, 2018 at 8:10 AM Frederik Ramm wrote: > Hi, > > over the last 2 years, DWG has had a three different complaints about a > buggy building import that has been run on and off by the user > "annapolissailor". > > The import was problematic in many ways, most obviously because huge > batches of un-used nodes were uploaded and later it was attempted to > connect them, which sometimes failed, leaving lots of un-used nodes in > the database; also, almost all buildings are over-noded, taking 10 or > more nodes for a simple rectangular building (eg > https://www.openstreetmap.org/way/435663194). Buildings that were in the > area before have been deleted outright, and the data source and legal > situation is unclear (many buildings are much too precise to have come > from aerial imagery). > > (Needless to say, had the import been discussed up front as is > customary, all these issues could have been avoided.) > > I have tried to work with the importer but they seem to be ultimately > unable or unwilling to fix the problems even though they did seem to > understand the issue at some point > (https://www.openstreetmap.org/user_blocks/1587). They asked me a couple > of times to "hold off reverting data until next steps are discussed on > the imports list" but never followed up on the promise. They claimed to > have spent hundreds of hours on the JOSM validator improving problems > they had introduced. > > I am at the moment deleting about 70,000 untagged and un-used nodes that > have been left over from this import, which is the uncontroversial part. > > The total amount of buildings created and still visible is 177,151, with > a total of 1,980,336 nodes, in the general area "East of Washington DC, > South of Baltimore, North of Chesapeake Beach". > > I think these buildings need to be deleted too, given their technical > (over-noding) and legal (we don't know where the data came from and what > license it is under) issues. > > However, given how much work the mapper claims to have invested in this, > I wonder if there's maybe a way to salvage the data. That would first > require us to clear up the legal situation, and if it turns out the > source is legal, then we'd have to go about killing the extra nodes in > buildings. > > I'm basically looking for volunteers here. Other mappers have tried to > discuss the issue with the mapper himself and never got far either, but > of course if someone wanted to try and enlist annapolissailor's support, > fair enough (perhaps agree here on the list who's doing it though, so > that we don't have 10 people spamming him...) > > I have prepared a file that contains all the buildings in question: > > http://www.remote.org/frederik/tmp/annapolis.osm.gz > > Bye > Frederik > > -- > Frederik Ramm ## eMail frede...@remote.org ## N49°00'09" E008°23'33" > > ___ > Talk-us mailing list > Talk-us@openstreetmap.org > https://lists.openstreetmap.org/listinfo/talk-us > -- Elliott Plack http://elliottplack.me ___ Talk-us mailing list Talk-us@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-us
[Talk-us] buggy buildings in Maryland
Hi, over the last 2 years, DWG has had a three different complaints about a buggy building import that has been run on and off by the user "annapolissailor". The import was problematic in many ways, most obviously because huge batches of un-used nodes were uploaded and later it was attempted to connect them, which sometimes failed, leaving lots of un-used nodes in the database; also, almost all buildings are over-noded, taking 10 or more nodes for a simple rectangular building (eg https://www.openstreetmap.org/way/435663194). Buildings that were in the area before have been deleted outright, and the data source and legal situation is unclear (many buildings are much too precise to have come from aerial imagery). (Needless to say, had the import been discussed up front as is customary, all these issues could have been avoided.) I have tried to work with the importer but they seem to be ultimately unable or unwilling to fix the problems even though they did seem to understand the issue at some point (https://www.openstreetmap.org/user_blocks/1587). They asked me a couple of times to "hold off reverting data until next steps are discussed on the imports list" but never followed up on the promise. They claimed to have spent hundreds of hours on the JOSM validator improving problems they had introduced. I am at the moment deleting about 70,000 untagged and un-used nodes that have been left over from this import, which is the uncontroversial part. The total amount of buildings created and still visible is 177,151, with a total of 1,980,336 nodes, in the general area "East of Washington DC, South of Baltimore, North of Chesapeake Beach". I think these buildings need to be deleted too, given their technical (over-noding) and legal (we don't know where the data came from and what license it is under) issues. However, given how much work the mapper claims to have invested in this, I wonder if there's maybe a way to salvage the data. That would first require us to clear up the legal situation, and if it turns out the source is legal, then we'd have to go about killing the extra nodes in buildings. I'm basically looking for volunteers here. Other mappers have tried to discuss the issue with the mapper himself and never got far either, but of course if someone wanted to try and enlist annapolissailor's support, fair enough (perhaps agree here on the list who's doing it though, so that we don't have 10 people spamming him...) I have prepared a file that contains all the buildings in question: http://www.remote.org/frederik/tmp/annapolis.osm.gz Bye Frederik -- Frederik Ramm ## eMail frede...@remote.org ## N49°00'09" E008°23'33" ___ Talk-us mailing list Talk-us@openstreetmap.org https://lists.openstreetmap.org/listinfo/talk-us
