Re: [tcpdump-workers] strlcpy() in tcpslice
--- Begin Message --- On 25/08/2020 19:44, Denis Ovsienko via tcpdump-workers wrote: > +[missing/strlcpy.c:46]: (style) The function 'strlcpy' is never used. > > (Which is true, but neither GCC nor Clang complain about that.) > > LBL code never used strlcpy(), it appeared in TTG code in 2001 via > commit fc7de60. Considering long-term maintenance, would it be better > to lose the unused missing/strlcpy.c now, or to wait a bit, or to keep > it around for as long as it compiles? Hello Denis, strlcpy is used here: tcpslice.c:999: strlcpy(buf, asctime(t), 128); With my build: gcc [...] -g -O2 -o strlcpy.o -c ./missing/strlcpy.c -- Francois-Xavier --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
[tcpdump-workers] strlcpy() in tcpslice
--- Begin Message --- Hello list. The most recent commit to tcpslice (e3d63a6) has traded one cppcheck warning to another: -[tcpslice.c:999]: (style) Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. +[missing/strlcpy.c:46]: (style) The function 'strlcpy' is never used. (Which is true, but neither GCC nor Clang complain about that.) LBL code never used strlcpy(), it appeared in TTG code in 2001 via commit fc7de60. Considering long-term maintenance, would it be better to lose the unused missing/strlcpy.c now, or to wait a bit, or to keep it around for as long as it compiles? -- Denis Ovsienko --- End Message --- ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
