Re: [tcpdump-workers] GUE (UDP encapsulation) pull request
Hello Denis, On 3 July 2016 at 12:46, Denis Ovsienkowrote: > > You can speed it up a bit by squashing the changes in the pull request > into a single pretty commit on top of the current master branch. I have > also left a couple other comments in the pull request. > > Thank you for the comments! I'll address them and squash the PR back into a single (hopefully pretty!) commit. Cheers, -- Wilmer van der Gaast, London Traffic SRE. ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
Re: [tcpdump-workers] GUE (UDP encapsulation) pull request
On Wed, 29 Jun 2016 13:54:07 +0100 Wilmer van der Gaast wrote >I've just re-synced my pull request for adding GUE (UDP encapsulation) >dissection support to tcpdump: >https://github.com/the-tcpdump-group/tcpdump/pull/510 > >I've had no comments on it so far though (having submitted it in March). >What's the usual procedure of getting PRs merged? Hello Wilmer. You can speed it up a bit by squashing the changes in the pull request into a single pretty commit on top of the current master branch. I have also left a couple other comments in the pull request. Cheers! -- Denis Ovsienko ___ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers