Re: usb wireless detach
I will test this patch with my Linksys rum(4) AP tonight and report back
to you.
-luis
On 12/22/10 18:36, Jacob Meuser wrote:
no feedback yet. anyone care to comment on this?
On Thu, Dec 16, 2010 at 12:28:56AM +, Jacob Meuser wrote:
the following diff tries to make sure that no other processes/threads
are or will be using the drivers software context when the driver is
detached.
this diff covers rum(4), run(4), ural(4) and urtw(4). without the
diff, I can get the kernel to crash by starting a scan with
the deice, then ejecting it while the scan is running. with this
diff, I cannot get a crash.
normally, usb device detach happens in the usb_task thread. the sole
exception is when the usb bus itself is being detached. this happens
with cardbus devices, and in that case, the usb device detach happens
in the generic workq thread.
this adds a simple reference counting/waiting mechanism. this is
definitely needed for ioctl(2), which can sleep then start using the
driver again. it may not be needed for timeout(9)s now, but maybe
someday it will. another possible process using the device is the
usb_task thread. in the normal case, this is the same process that
is detaching, so there is no concurrency issue. there is already
usb_rem_wait_task() to deal with detaches from other processes,
because the bus driver needs it.
this also adds more uses of usbd_is_dying() to check if the device
has been detached:
* before adding timeouts
* when entering timeouts, usb_tasks, and ioctl
also of note is the order things are done in the detach routines:
1) remove pending timeouts
2) remove (and possibly wait for) pending usb_tasks
3) wait for other processes
4) detach from the network stack
5) cleanup/free usb resources
thoughts? ok?
--
jake...@sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org
Index: if_ral.c
===
RCS file: /cvs/src/sys/dev/usb/if_ral.c,v
retrieving revision 1.117
diff -u -p -r1.117 if_ral.c
--- if_ral.c6 Dec 2010 04:41:39 - 1.117
+++ if_ral.c15 Dec 2010 02:58:35 -
@@ -363,17 +363,20 @@ ural_detach(struct device *self, int fla
s = splusb();
- if (ifp->if_softc != NULL) {
- ieee80211_ifdetach(ifp);/* free all nodes */
- if_detach(ifp);
- }
-
- usb_rem_task(sc->sc_udev,&sc->sc_task);
if (timeout_initialized(&sc->scan_to))
timeout_del(&sc->scan_to);
if (timeout_initialized(&sc->amrr_to))
timeout_del(&sc->amrr_to);
+ usb_rem_wait_task(sc->sc_udev,&sc->sc_task);
+
+ usbd_ref_wait(sc->sc_udev);
+
+ if (ifp->if_softc != NULL) {
+ ieee80211_ifdetach(ifp);/* free all nodes */
+ if_detach(ifp);
+ }
+
if (sc->amrr_xfer != NULL) {
usbd_free_xfer(sc->amrr_xfer);
sc->amrr_xfer = NULL;
@@ -547,8 +550,15 @@ ural_next_scan(void *arg)
struct ieee80211com *ic =&sc->sc_ic;
struct ifnet *ifp =&ic->ic_if;
+ if (usbd_is_dying(sc->sc_udev))
+ return;
+
+ usbd_ref_incr(sc->sc_udev);
+
if (ic->ic_state == IEEE80211_S_SCAN)
ieee80211_next_scan(ifp);
+
+ usbd_ref_decr(sc->sc_udev);
}
void
@@ -559,6 +569,9 @@ ural_task(void *arg)
enum ieee80211_state ostate;
struct ieee80211_node *ni;
+ if (usbd_is_dying(sc->sc_udev))
+ return;
+
ostate = ic->ic_state;
switch (sc->sc_state) {
@@ -574,7 +587,8 @@ ural_task(void *arg)
case IEEE80211_S_SCAN:
ural_set_chan(sc, ic->ic_bss->ni_chan);
- timeout_add_msec(&sc->scan_to, 200);
+ if (!usbd_is_dying(sc->sc_udev))
+ timeout_add_msec(&sc->scan_to, 200);
break;
case IEEE80211_S_AUTH:
@@ -1324,6 +1338,11 @@ ural_ioctl(struct ifnet *ifp, u_long cmd
struct ifreq *ifr;
int s, error = 0;
+ if (usbd_is_dying(sc->sc_udev))
+ return ENXIO;
+
+ usbd_ref_incr(sc->sc_udev);
+
s = splnet();
switch (cmd) {
@@ -1387,6 +1406,8 @@ ural_ioctl(struct ifnet *ifp, u_long cmd
splx(s);
+ usbd_ref_decr(sc->sc_udev);
+
return error;
}
@@ -2147,7 +2168,8 @@ ural_amrr_start(struct ural_softc *sc, s
i--);
ni->ni_txrate = i;
- timeout_add_sec(&sc->amrr_to, 1);
+ if (!usbd_is_dying(sc->sc_udev))
+ timeout_add_sec(&sc->amrr_to, 1);
}
void
@@ -2157,6 +2179,11 @@ ural_amrr_timeout(void *arg)
usb_device_request_t req;
int s;
+ if (usbd_is_dying(sc->sc_udev))
+ return;
+
+ usbd_ref_incr(sc->sc_udev);
+
s = splusb();
/*
@@ -2174,6 +2201,8 @@ ural_amrr_timeout(void *arg)
(void)usbd_transfer(sc->amrr_xfer);
splx(s);
+
+ usbd_ref_decr(sc->sc_udev);
}
Re: Tracking What it's changing in current
On 02/15/11 10:54, Orestes Leal R. wrote: I need to see (with a tool or whatever) what changes have occured between current, let's say between current 4.9 from february 9 and current dated february 14. They are logged in some place? cvs
Diff for www:FAQ ports/ports
Hi, Here a diff for www page: FAQ ports/ports Hi, see this typo error on the page. Right? Index: faq/ports/ports.html === RCS file: /cvs/www/faq/ports/ports.html,v retrieving revision 1.57 diff -u -r1.57 ports.html --- faq/ports/ports.html4 Dec 2020 17:08:16 - 1.57 +++ faq/ports/ports.html2 May 2021 13:42:42 - @@ -759,7 +759,7 @@ available (for example, if the main port is neomutt-20201127, the debug package will be debug-neomutt-20201127). These contain debug symbols which have been separated into a different -ile; GDB knows how to load it automatically. +file; GDB knows how to load it automatically. The debug package must match the main package. If you are using snapshots, you may need to reinstall to ensure that they are from the same build.
Diff for www:OpenBSD/powerpc64
Hi, Here a diff for www page: OpenBSD/powerpc64 Hi. According to page 68, 6.8 was the first version for the platform. Right? Index: powerpc64.html === RCS file: /cvs/www/powerpc64.html,v retrieving revision 1.7 diff -u -r1.7 powerpc64.html --- powerpc64.html 30 Apr 2021 16:14:12 - 1.7 +++ powerpc64.html 2 May 2021 18:10:32 - @@ -39,7 +39,7 @@ History: -OpenBSD 6.9 was the first official release of OpenBSD/powerpc64. +OpenBSD 6.8 was the first official release of OpenBSD/powerpc64. And since there are always little bits missing, work is continuing...
Diff for www:FAQ>PF:Getting started
Hi, Here a diff for www page: FAQ>PF:Getting started Just some typos Right? Index: faq/pf/config.html === RCS file: /cvs/www/faq/pf/config.html,v retrieving revision 1.66 diff -u -r1.66 config.html --- faq/pf/config.html 5 May 2021 21:49:29 - 1.66 +++ faq/pf/config.html 10 May 2021 16:34:12 - @@ -50,7 +50,7 @@ Activation PF is enabled by default. -If can be disabled at boot with the +It can be disabled at boot with the https://man.openbsd.org/rcctl";>rcctl(8) tool: @@ -107,8 +107,8 @@ Some example commands are: -# pfctl -f /etc/pf.confLoad the pf.conf file -# pfctl -nf /etc/pf.confParse the file, but don't load it +# pfctl -f /etc/pf.conf# Load the pf.conf file +# pfctl -nf /etc/pf.conf# Parse the file, but don't load it # pfctl -sr # Show the current ruleset # pfctl -ss # Show the current state table # pfctl -si # Show filter stats and counters
Diff for www:FAQ>PF: Packet Filtering
Hi, Here a diff for www page: FAQ>PF: Packet Filtering Just one typo. Right? Index: faq/pf/filter.html === RCS file: /cvs/www/faq/pf/filter.html,v retrieving revision 1.97 diff -u -r1.97 filter.html --- faq/pf/filter.html 5 May 2021 21:49:29 - 1.97 +++ faq/pf/filter.html 10 May 2021 17:58:11 - @@ -695,7 +695,7 @@ in transmitted packets in order to either hide the real address or to impersonate another node on the network. Once the address has been spoofed, a network attack can be launched without -revealing the true source of the attack, +revealing the true source of the attack. An attacker can also attempt to gain access to network services that are restricted to certain IP addresses.
Diff for www:FAQ > PF:perf
Hi, Here a diff for www page: FAQ > PF:perf Just a typo. Right? Index: faq/pf/perf.html === RCS file: /cvs/www/faq/pf/perf.html,v retrieving revision 1.45 diff -u -r1.45 perf.html --- faq/pf/perf.html5 May 2021 21:49:29 - 1.45 +++ faq/pf/perf.html13 May 2021 16:31:10 - @@ -74,7 +74,7 @@ Barely worth mentioning: CPU and RAM. As PF is a kernel-based process, it will not use swap space. So, if the system enough RAM, it runs. - if not, it panics due to + If not, it panics due to https://man.openbsd.org/pool";>pool(9) exhaustion. Huge amounts of RAM are not needed.
Diff for www:OpenBSD/plus69
Hi, Here a diff for www page: OpenBSD/plus69 Isn't it a typo? (I'm not sure) Right? Index: plus69.html === RCS file: /cvs/www/plus69.html,v retrieving revision 1.3 diff -u -r1.3 plus69.html --- plus69.html 5 May 2021 23:58:34 - 1.3 +++ plus69.html 15 May 2021 12:55:06 - @@ -186,7 +186,7 @@ Added a "batch" mode to https://man.openbsd.org/mg.1";>mg(1) via the "-b" command line option which will initialize a pty, run the specified file of mg commands and then exit. Added https://man.openbsd.org/rpki-client.8";>rpki-client(8) -V option to show version. -Removed https://man.openbsd.org/vmd.8";>vwm(8) booting from kernels in raw/qcow2 images. +Removed https://man.openbsd.org/vmd.8";>vmd(8) booting from kernels in raw/qcow2 images. Unlocked https://man.openbsd.org/sendsyslog.2";>sendsyslog(2).
Diff for www:mail
Hi, Here a diff for www page: mail Please, review this diff to add French ML Right? Index: mail.html === RCS file: /cvs/www/mail.html,v retrieving revision 1.170 diff -u -r1.170 mail.html --- mail.html 24 Apr 2020 21:51:21 - 1.170 +++ mail.html 4 May 2020 13:38:21 - @@ -423,6 +423,14 @@ PLEASE KEEP THIS LIST SORTED, EXCEPT FOR TRANSLATIONS, WHERE YOU SHOULD PUT THE LIST IN YOUR LANGUAGE, IF ONE EXISTS, HEAD OF LIST. --> + +French: +bla...@openbsd.fr.eu.org +To subscribe, send a message to +mailto:blabla+subscr...@openbsd.fr.eu.org";> +blabla+subscr...@openbsd.fr.eu.org + +(https://openbsd.fr.eu.org/blabla/";>Archive) Spanish: -- " Fully Basic System Distinguish Life! " ~ " Libre as a BSD " +=<<< Stephane HUC as PengouinBSD or CIOTBSD b...@stephane-huc.net
Diff for www:FAQ4
Hi, Here a diff for www page: FAQ4 Do you accept to modify this FAQ4 to add the SHA256 URL? Right? Index: faq/faq4.html === RCS file: /cvs/www/faq/faq4.html,v retrieving revision 1.535 diff -u -r1.535 faq4.html --- faq/faq4.html 19 May 2020 02:02:10 - 1.535 +++ faq/faq4.html 20 May 2020 12:25:05 - @@ -236,6 +236,19 @@ You can confirm that none of the downloaded files were mangled in transit using the https://man.openbsd.org/sha256";>sha256(1) command. +[https://cdn.openbsd.org/pub/OpenBSD/6.7/alpha/SHA256";>alpha] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/amd64/SHA256";>amd64] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/arm64/SHA256";>arm64] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/armv7/SHA256";>armv7] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/hppa/SHA256";>hppa] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/i386/SHA256";>i386] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/landisk/SHA256";>landisk] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/loongson/SHA256";>loongson] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/luna88k/SHA256";>luna88k] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/macppc/SHA256";>macppc] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/octeon/SHA256";>octeon] +[https://cdn.openbsd.org/pub/OpenBSD/6.7/sparc64/SHA256";>sparc64] + $ sha256 -C SHA256 miniroot*.fs (SHA256) minirootXX.fs: OK
Diff for www:openssh/security.html
Hi, Here a diff for www page: openssh/security.html Change some URLs to those on archive.org (and other site) Right? Index: openssh/security.html === RCS file: /cvs/www/openssh/security.html,v retrieving revision 1.64 diff -u -r1.64 security.html --- openssh/security.html 25 Apr 2020 17:17:28 - 1.64 +++ openssh/security.html 9 Jun 2020 23:00:35 - @@ -121,7 +121,7 @@ February 23, 2009: OpenSSH prior to version 5.2 is vulnerable to the protocol weakness described in -http://www.cpni.gov.uk/Docs/Vulnerability_Advisory_SSH.txt";>CPNI-957037 "Plaintext Recovery Attack Against SSH". +https://web.archive.org/web/20101221213113/http://www.cpni.gov.uk/Docs/Vulnerability_Advisory_SSH.txt";>CPNI-957037 "Plaintext Recovery Attack Against SSH". However, based on the limited information available it appears that this described attack is infeasible in most circumstances. For more information please refer to the @@ -197,7 +197,7 @@ "September 16, 2003: OpenSSH Buffer Management bug", https://www.openssh.com/txt/buffer.adv";>OpenSSH Security Advisory and CERT Advisory -http://www.cert.org/advisories/CA-2003-24.html";>CA-2003-24. +https://resources.sei.cmu.edu/asset_files/WhitePaper/2003_019_001_496200.pdf#%5B%7B%22num%22%3A327%2C%22gen%22%3A0%7D%2C%7B%22name%22%3A%22XYZ%22%7D%2C106%2C701%2C0%5D";>CA-2003-24. August 1, 2002: OpenSSH version 3.2.2p1, 3.4p1 and 3.4 were trojaned on the @@ -277,7 +277,7 @@ September 2, 2000: OpenSSH 2.2.0 and newer are not vulnerable to the "Feb 7, 2001: SSH-1 Session Key Recovery Vulnerability", -CORE-SDI Advisory CORE-20010116. OpenSSH imposes limits on the +https://web.archive.org/web/20010214092544/http://www.core-sdi.com/advisories/ssh1_sessionkey_recovery.htm";>CORE-SDI Advisory CORE-20010116. OpenSSH imposes limits on the connection rate, making the attack unfeasible. Additionally, the Bleichenbacher oracle has been closed completely since January 29, 2001. @@ -291,7 +291,7 @@ OpenSSH was never vulnerable to the "Feb 5, 2001: SSH-1 Brute Force Password Vulnerability", -http://www.crimelabs.net/";>Crimelabs Security Note CLABS200101. +https://web.archive.org/web/20010308153603/http://www.crimelabs.net/docs/sshd1-logging.txt";>Crimelabs Security Note CLABS200101. OpenSSH was not vulnerable to the RC4 cipher http://www.kb.cert.org/vuls/id/565052";>password cracking, @@ -323,7 +323,7 @@ OpenSSH has the SSH 1 protocol deficiency that might make an insertion attack difficult but possible. The CORE-SDI -http://www2.corest.com/common/showdoc.php?idx=131&idxseccion=10";>deattack mechanism +https://web.archive.org/web/20070814045200/http://www2.corest.com/common/showdoc.php?idx=131&idxseccion=10";>deattack mechanism is used to eliminate the common case. SSH 1 protocol support is disabled by default.
Diff for www:openssh/users.html
Hi, Here a diff for www page: openssh/users.html Change URLs to those on archive.org (and others sites) Right? Index: openssh/users.html === RCS file: /cvs/www/openssh/users.html,v retrieving revision 1.66 diff -u -r1.66 users.html --- openssh/users.html 12 Jun 2019 07:49:48 - 1.66 +++ openssh/users.html 10 Jun 2020 01:16:52 - @@ -33,7 +33,7 @@ https://www.cygwin.com/";>Cygwin https://www.apple.com/macos/";>Mac OS X Version 10.1 and later https://www.hpe.com/us/en/networking/switches.html";>HP Procurve Switch 4108GL and 2524/2512 -https://www-01.ibm.com/support/docview.wss?uid=isg1fileset2031326864";>IBM AIX +https://www.ibm.com/support/pages/node/5766531";>IBM AIX https://www.oracle.com/sun/";>Sun Solaris 9 and later (named https://docs.oracle.com/cd/E23824_01/html/821-1456/sshuser-6.html";>SunSSH) http://www.smoothwall.org/";>SmoothWall https://web.archive.org/web/20060117215707/http://www.sgi.com/products/software/irix/releases/irix6521.html";>SGI Irix @@ -47,14 +47,14 @@ https://www.networktechinc.com/srvsw-term-ssh.html";>NTI SSH Serial Port Switch https://www.symantec.com/products/proxy-sg-and-advanced-secure-gateway";>Bluecoat (formerly Cacheflow) Proxy SG http://www.novell.com/documentation/oes2/oes_implement_lx_nw/index.html?page=/documentation/oes2/oes_implement_lx_nw/data/manage-ssh.html";>Novell NetWare -http://www.digi.com/products/consolemanagement/digicm.jsp";>Digi CM Console Servers -http://www.alcatel.com/enterprise/en/technologies/technology_ip_networking/security/ssh.html";>Alcatel OmniSwitch -http://www1.us.dell.com/content/products/category.aspx/networking?c=us&cs=555&l=en&s=biz";>Dell PowerConnect L2 and L3 Switches +https://www.digi.com/products/networking/infrastructure-management/console-servers/digicm";>Digi CM Console Servers +https://web.archive.org/web/20070402044409/http://www1.alcatel-lucent.com/enterprise/en/technologies/technology_ip_networking/security/ssh.html";>Alcatel OmniSwitch +https://web.archive.org/web/20060426115544/http://www1.us.dell.com/content/products/category.aspx/networking?c=us&cs=555&l=en&s=biz";>Dell PowerConnect L2 and L3 Switches http://www.hp.com/products1/unix/operating/index.html";>HP-UX (known as http://www.docs.hp.com/en/T1471-90015/index.html";>HP-UX Secure Shell) http://www.packeteer.com/prod-sol/products/packetshaper.cfm";>Packeteer PacketShaper 6.0 and above. http://www.juniper.net/products/junos/";>Juniper Networks JUNOS All Linux systems, such as Red Hat. -https://opensource.microsoft.com/?tag=openssh";>Microsoft Windows +https://web.archive.org/web/20180604101036/https://opensource.microsoft.com/?tag=openssh";>Microsoft Windows
Diff for www:macppc
Hi, Here a diff for www page: macppc I suggest to use the HTML kbd tag instead Right? Index: macppc.html === RCS file: /cvs/www/macppc.html,v retrieving revision 1.274 diff -u -r1.274 macppc.html --- macppc.html 18 Oct 2020 02:37:42 - 1.274 +++ macppc.html 21 Oct 2020 07:08:35 - @@ -535,7 +535,7 @@ while running from battery. Older iMacs can have a problem with the USB keyboard driver where the first key pressed after boot will repeat endlessly. The workaround - is to pressfirst or to disconnect and reconnect the USB mouse + is to press SHIFT first or to disconnect and reconnect the USB mouse after the problem has occurred. @@ -544,6 +544,6 @@ Other Features - on ADB (not USB) keyboards + CTRL+CMD+POWER on ADB (not USB) keyboards will reset the computer.
Re: X41 ACPI suspend hints
> Unfortunately, it shows the same behavior also with this patch applied: > it immediately wakes up after zzz. > > Cheers, > David > The same on my Dell Latitude D620. -luis
smtpd.conf(5): comma in filter chains
After quite some debugging of why the heck my smtpd.conf was not working after upgrading to 5.9 and substituting clamsmtp and dkim- signer by smtpd(8) filters: smtpd.conf(5) states: filter name chain filter [, ...] but should say: filter name chain filter [...] Index: smtpd.conf.5 === RCS file: /cvs/src/usr.sbin/smtpd/smtpd.conf.5,v retrieving revision 1.156 diff -u -p -r1.156 smtpd.conf.5 --- smtpd.conf.57 Mar 2016 16:21:48 - 1.156 +++ smtpd.conf.59 Apr 2016 09:32:23 - @@ -612,7 +612,7 @@ using the given filter Filters are used to hook into the SMTP dialog and provide additional filtering options for .Xr smtpd 8 . -.It Ic filter Ar name Ic chain Ar filter Op , Ar ... +.It Ic filter Ar name Ic chain Ar filter Op Ar ... Specify a filter chain with the given .Ar name and filters.
Re: smtpd.conf(5): comma in filter chains
> On 10 Apr 2016, at 08:49, Jason McIntyre wrote: > > fair enough. but since "..." already means optional i went further and > removed the []: > >filter name chain filter ... Ack. Thanks. David
