Incorrect comment after changing value in another place

2021-05-31 Thread Reuven Plevinsky
There is an old fix of SB_MAX, increasing it to 2MB (instead of 256k) makes
TCP scaling factor 6 (instead of 3).
But the comment in the shifting remained with the old values.

Although it's just a comment, it might be very confusing.

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index cd0c12dcd3ba..74ce2621f762 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -3832,8 +3832,8 @@ syn_cache_add(struct sockaddr *src, struct sockaddr
*dst, struct tcphdr *th,
 * leading to serious problems when traversing these
 * broken firewalls.
 *
-* With the default sbmax of 256K, a scale factor
-* of 3 will be chosen by this algorithm.  Those who
+* With the default sbmax of 2MB, a scale factor
+* of 6 will be chosen by this algorithm.  Those who
 * choose a larger sbmax should watch out
 * for the compatibility problems mentioned above.
 *


Diff

2021-05-31 Thread Reuven Plevinsky
Hi,
Here is my diff:
https://github.com/reuvenP/src/commit/db909be68a3b03e68787de55d218388f33c4c4c6
There is an old fix of SB_MAX, increasing of it to 2MB (instead of 256k)
makes TCP scaling factor 6 (instead of 3).
But the comment in the shifting remained with the old values.


Pull Request

2021-05-31 Thread Reuven Plevinsky
https://github.com/reuvenP/src/commit/db909be68a3b03e68787de55d218388f33c4c4c6