Re: Completely disable 2D acceleration on Broadwell

2015-12-02 Thread Peter Hessler
On 2015 Dec 02 (Wed) at 17:13:32 +1100 (+1100), Jonathan Gray wrote:
:On Tue, Dec 01, 2015 at 04:44:39PM +0100, Mark Kettenis wrote:
:> As tedu@ reported (and some pople on misc@ confirmed) partly disabling
:> 2D acceleration on Broadwell made X unstable.  It really looks like
:> the alternative BLT path isn't well tested and therefore buggy.  So
:> here is a diff that disables 2D acceleration completely.  Those who
:> don't care about suspend/resume can still enable it if they want.  3D
:> acceleration should continue to work.
:> 
:> ok?
:
:chrome and mplayer seem basically unuseable with this.  Perhaps it
:should be those who want to suspend/resume can run the modesetting
:driver or disable acceleration via xorg.conf.
:

mplayer with vo=gl or with vo=xv?


:> 
:> 
:> Index: sna_accel.c
:> ===
:> RCS file: /home/cvs/xenocara/driver/xf86-video-intel/src/sna/sna_accel.c,v
:> retrieving revision 1.6
:> diff -u -p -r1.6 sna_accel.c
:> --- sna_accel.c  15 Nov 2015 15:33:57 -  1.6
:> +++ sna_accel.c  1 Dec 2015 15:37:44 -
:> @@ -17659,6 +17659,9 @@ static bool sna_option_accel_none(struct
:>  return true;
:>  
:>  s = xf86GetOptValString(sna->Options, OPTION_ACCEL_METHOD);
:> +/* XXX avoid render ring since it gets stuck after resume */
:> +if (s == NULL && sna->info->gen >= 0100)
:> +return true;
:>  if (s == NULL)
:>  return IS_DEFAULT_ACCEL_METHOD(NOACCEL);
:>  
:> @@ -17670,9 +17673,6 @@ static bool sna_option_accel_blt(struct 
:>  const char *s;
:>  
:>  s = xf86GetOptValString(sna->Options, OPTION_ACCEL_METHOD);
:> -/* XXX avoid render ring since it gets stuck after resume */
:> -if (s == NULL && sna->info->gen >= 0100)
:> -return true;
:>  if (s == NULL)
:>  return false;
:>  
:> 
:



Re: Completely disable 2D acceleration on Broadwell

2015-12-02 Thread Jonathan Gray
On Wed, Dec 02, 2015 at 10:16:21AM +0100, Peter Hessler wrote:
> On 2015 Dec 02 (Wed) at 17:13:32 +1100 (+1100), Jonathan Gray wrote:
> :On Tue, Dec 01, 2015 at 04:44:39PM +0100, Mark Kettenis wrote:
> :> As tedu@ reported (and some pople on misc@ confirmed) partly disabling
> :> 2D acceleration on Broadwell made X unstable.  It really looks like
> :> the alternative BLT path isn't well tested and therefore buggy.  So
> :> here is a diff that disables 2D acceleration completely.  Those who
> :> don't care about suspend/resume can still enable it if they want.  3D
> :> acceleration should continue to work.
> :> 
> :> ok?
> :
> :chrome and mplayer seem basically unuseable with this.  Perhaps it
> :should be those who want to suspend/resume can run the modesetting
> :driver or disable acceleration via xorg.conf.
> :
> 
> mplayer with vo=gl or with vo=xv?

Both, no scaling with xv either.



Re: Completely disable 2D acceleration on Broadwell

2015-12-02 Thread Ted Unangst
Peter Hessler wrote:
> On 2015 Dec 02 (Wed) at 17:13:32 +1100 (+1100), Jonathan Gray wrote:
> :On Tue, Dec 01, 2015 at 04:44:39PM +0100, Mark Kettenis wrote:
> :> As tedu@ reported (and some pople on misc@ confirmed) partly disabling
> :> 2D acceleration on Broadwell made X unstable.  It really looks like
> :> the alternative BLT path isn't well tested and therefore buggy.  So
> :> here is a diff that disables 2D acceleration completely.  Those who
> :> don't care about suspend/resume can still enable it if they want.  3D
> :> acceleration should continue to work.
> :> 
> :> ok?
> :
> :chrome and mplayer seem basically unuseable with this.  Perhaps it
> :should be those who want to suspend/resume can run the modesetting
> :driver or disable acceleration via xorg.conf.
> :
> 
> mplayer with vo=gl or with vo=xv?

the previous diff that supposedly left 3d accel enabled actually made glxgears
and vo=gl hang immediately and display nothing for me.



Completely disable 2D acceleration on Broadwell

2015-12-01 Thread Mark Kettenis
As tedu@ reported (and some pople on misc@ confirmed) partly disabling
2D acceleration on Broadwell made X unstable.  It really looks like
the alternative BLT path isn't well tested and therefore buggy.  So
here is a diff that disables 2D acceleration completely.  Those who
don't care about suspend/resume can still enable it if they want.  3D
acceleration should continue to work.

ok?


Index: sna_accel.c
===
RCS file: /home/cvs/xenocara/driver/xf86-video-intel/src/sna/sna_accel.c,v
retrieving revision 1.6
diff -u -p -r1.6 sna_accel.c
--- sna_accel.c 15 Nov 2015 15:33:57 -  1.6
+++ sna_accel.c 1 Dec 2015 15:37:44 -
@@ -17659,6 +17659,9 @@ static bool sna_option_accel_none(struct
return true;
 
s = xf86GetOptValString(sna->Options, OPTION_ACCEL_METHOD);
+   /* XXX avoid render ring since it gets stuck after resume */
+   if (s == NULL && sna->info->gen >= 0100)
+   return true;
if (s == NULL)
return IS_DEFAULT_ACCEL_METHOD(NOACCEL);
 
@@ -17670,9 +17673,6 @@ static bool sna_option_accel_blt(struct 
const char *s;
 
s = xf86GetOptValString(sna->Options, OPTION_ACCEL_METHOD);
-   /* XXX avoid render ring since it gets stuck after resume */
-   if (s == NULL && sna->info->gen >= 0100)
-   return true;
if (s == NULL)
return false;