On 18/01/22(Tue) 04:38, Klemens Nanni wrote:
> While intended for more architectures, DDBPROF is strictly amd64 and
> i386 only, so the machine-independent sys/conf/GENERIC does not seem fit
> (until all architectures are supported).
This define should die. There's no need to polish this turd. Somebody
has to stand up and turn this into a "#if NDT > 0" with the audit that
goes with it.
> Index: conf/GENERIC
> ===
> RCS file: /cvs/src/sys/conf/GENERIC,v
> retrieving revision 1.281
> diff -u -p -r1.281 GENERIC
> --- conf/GENERIC 23 Dec 2021 10:04:14 - 1.281
> +++ conf/GENERIC 18 Jan 2022 04:28:29 -
> @@ -4,7 +4,6 @@
> #GENERIC kernel
>
> option DDB # in-kernel debugger
> -#option DDBPROF # ddb(4) based profiling
> #option DDB_SAFE_CONSOLE # allow break into ddb during boot
> #makeoptions DEBUG=""# do not compile full symbol table
> #makeoptions PROF="-pg" # build profiled kernel
> Index: arch/amd64/conf/GENERIC
> ===
> RCS file: /cvs/src/sys/arch/amd64/conf/GENERIC,v
> retrieving revision 1.510
> diff -u -p -r1.510 GENERIC
> --- arch/amd64/conf/GENERIC 4 Jan 2022 05:50:43 - 1.510
> +++ arch/amd64/conf/GENERIC 18 Jan 2022 04:28:04 -
> @@ -13,6 +13,8 @@ machine amd64
> include "../../../conf/GENERIC"
> maxusers 80 # estimated number of users
>
> +#option DDBPROF # ddb(4) based profiling
> +
> option USER_PCICONF# user-space PCI configuration
>
> option APERTURE# in-kernel aperture driver for XFree86
> Index: arch/i386/conf/GENERIC
> ===
> RCS file: /cvs/src/sys/arch/i386/conf/GENERIC,v
> retrieving revision 1.860
> diff -u -p -r1.860 GENERIC
> --- arch/i386/conf/GENERIC2 Jan 2022 23:14:27 - 1.860
> +++ arch/i386/conf/GENERIC18 Jan 2022 04:28:26 -
> @@ -13,6 +13,8 @@ machine i386
> include "../../../conf/GENERIC"
> maxusers 80 # estimated number of users
>
> +#option DDBPROF # ddb(4) based profiling
> +
> option USER_PCICONF# user-space PCI configuration
>
> option APERTURE# in-kernel aperture driver for XFree86
>
