Re: Documentation fix for cwmrc(5)

2015-05-17 Thread Mike Burns
On 2015-05-16 23.49.34 -0500, Kent R. Spillner wrote:
 On Sat, May 16, 2015 at 05:48:24PM -0400, Okan Demirmen wrote:
  Ah, I suspect if you looked at the errors, it would show a syntax
  error with the above. Like the example in the man page, use:
  
  autogroup 4 xterm,UXTerm
  
  and see if that works.

Thanks for pointing that out, Okan; that was indeed the issue. Apologies
for the noise.

 Okan reminded me I had an old diff that fixes this so the quotes are no
 longer necessary.  If you follow -current you can checkout the latest
 xenocara and rebuild cwm to use it.

Thanks for this change, Kent; it works beautifully.

-Mike



Re: Documentation fix for cwmrc(5)

2015-05-16 Thread Okan Demirmen
On Fri, May 15, 2015 at 3:11 AM, Mike Burns mike+open...@mike-burns.com wrote:
 This is essentially the opposite of this fix by Holger Mikolon, which
 was never merged: http://marc.info/?l=openbsd-techm=127765978812199

For a reason

 cwmrc(5) autogroup takes the windowname and windowclass in the opposite
 order than specified in the man page. Fix the man page.

The man page should be accurate; how are you determining that it is wrong?

Take the example from cwmrc(5) and try it:

 # Autogroup definitions
 autogroup 3 aterm,XTerm
 autogroup 3 xterm,XTerm

The current logic comes from the fact that xprop(1) displays name then
class. That said, I do want to reverse the logic in cwm(1) along with
other config format changes, so I prefer to do that all at once.

Please let me know how/why you've come to the below conclusion.

Thanks.

 Index: app/cwm/cwmrc.5
 ===
 RCS file: /cvs/xenocara/app/cwm/cwmrc.5,v
 retrieving revision 1.59
 diff -u -p -r1.59 cwmrc.5
 --- app/cwm/cwmrc.5 25 Aug 2014 12:49:19 -  1.59
 +++ app/cwm/cwmrc.5 15 May 2015 07:08:45 -
 @@ -40,7 +40,7 @@ The following options are accepted:
  .Pp
  .Bl -tag -width Ds -compact
  .It Ic autogroup Ar group windowclass
 -.It Ic autogroup Ar group windowname,windowclass
 +.It Ic autogroup Ar group windowclass,windowname
  Automatically add new windows to
  .Ar group
  if their class property matches




Re: Documentation fix for cwmrc(5)

2015-05-16 Thread Okan Demirmen
On Sat, May 16, 2015 at 5:22 PM, Mike Burns mike+open...@mike-burns.com wrote:
 On 2015-05-16 16.54.18 -0400, Okan Demirmen wrote:
 On Fri, May 15, 2015 at 3:11 AM, Mike Burns mike+open...@mike-burns.com 
 wrote:
  cwmrc(5) autogroup takes the windowname and windowclass in the opposite
  order than specified in the man page. Fix the man page.

 The man page should be accurate; how are you determining that it is wrong?

 Perhaps I am misunderstanding the output from xprop(1). I see:

 $ xprop | grep CLASS
 WM_CLASS(STRING) = xterm, UXTerm

 I added the following to my cwmrc(5):

 autogroup 4 xterm,UXTerm
 autogroup 5 UXTerm,xterm

 I then opened a new uxterm, and when I grouponly4 I see nothing, but on
 a grouponly5 I see the new uxterm.

 Is that what the man page is describing?

Ah, I suspect if you looked at the errors, it would show a syntax
error with the above. Like the example in the man page, use:

autogroup 4 xterm,UXTerm

and see if that works.

Thanks.

 Take the example from cwmrc(5) and try it:

  # Autogroup definitions
  autogroup 3 aterm,XTerm
  autogroup 3 xterm,XTerm

 The current logic comes from the fact that xprop(1) displays name then
 class. That said, I do want to reverse the logic in cwm(1) along with
 other config format changes, so I prefer to do that all at once.

 Please let me know how/why you've come to the below conclusion.

 Thanks.

  Index: app/cwm/cwmrc.5
  ===
  RCS file: /cvs/xenocara/app/cwm/cwmrc.5,v
  retrieving revision 1.59
  diff -u -p -r1.59 cwmrc.5
  --- app/cwm/cwmrc.5 25 Aug 2014 12:49:19 -  1.59
  +++ app/cwm/cwmrc.5 15 May 2015 07:08:45 -
  @@ -40,7 +40,7 @@ The following options are accepted:
   .Pp
   .Bl -tag -width Ds -compact
   .It Ic autogroup Ar group windowclass
  -.It Ic autogroup Ar group windowname,windowclass
  +.It Ic autogroup Ar group windowclass,windowname
   Automatically add new windows to
   .Ar group
   if their class property matches
 




Re: Documentation fix for cwmrc(5)

2015-05-16 Thread Mike Burns
On 2015-05-16 16.54.18 -0400, Okan Demirmen wrote:
 On Fri, May 15, 2015 at 3:11 AM, Mike Burns mike+open...@mike-burns.com 
 wrote:
  cwmrc(5) autogroup takes the windowname and windowclass in the opposite
  order than specified in the man page. Fix the man page.
 
 The man page should be accurate; how are you determining that it is wrong?

Perhaps I am misunderstanding the output from xprop(1). I see:

$ xprop | grep CLASS
WM_CLASS(STRING) = xterm, UXTerm

I added the following to my cwmrc(5):

autogroup 4 xterm,UXTerm
autogroup 5 UXTerm,xterm

I then opened a new uxterm, and when I grouponly4 I see nothing, but on
a grouponly5 I see the new uxterm.

Is that what the man page is describing?

 Take the example from cwmrc(5) and try it:
 
  # Autogroup definitions
  autogroup 3 aterm,XTerm
  autogroup 3 xterm,XTerm
 
 The current logic comes from the fact that xprop(1) displays name then
 class. That said, I do want to reverse the logic in cwm(1) along with
 other config format changes, so I prefer to do that all at once.
 
 Please let me know how/why you've come to the below conclusion.

 Thanks.
 
  Index: app/cwm/cwmrc.5
  ===
  RCS file: /cvs/xenocara/app/cwm/cwmrc.5,v
  retrieving revision 1.59
  diff -u -p -r1.59 cwmrc.5
  --- app/cwm/cwmrc.5 25 Aug 2014 12:49:19 -  1.59
  +++ app/cwm/cwmrc.5 15 May 2015 07:08:45 -
  @@ -40,7 +40,7 @@ The following options are accepted:
   .Pp
   .Bl -tag -width Ds -compact
   .It Ic autogroup Ar group windowclass
  -.It Ic autogroup Ar group windowname,windowclass
  +.It Ic autogroup Ar group windowclass,windowname
   Automatically add new windows to
   .Ar group
   if their class property matches
 



Documentation fix for cwmrc(5)

2015-05-15 Thread Mike Burns
This is essentially the opposite of this fix by Holger Mikolon, which
was never merged: http://marc.info/?l=openbsd-techm=127765978812199

cwmrc(5) autogroup takes the windowname and windowclass in the opposite
order than specified in the man page. Fix the man page.

Index: app/cwm/cwmrc.5
===
RCS file: /cvs/xenocara/app/cwm/cwmrc.5,v
retrieving revision 1.59
diff -u -p -r1.59 cwmrc.5
--- app/cwm/cwmrc.5 25 Aug 2014 12:49:19 -  1.59
+++ app/cwm/cwmrc.5 15 May 2015 07:08:45 -
@@ -40,7 +40,7 @@ The following options are accepted:
 .Pp
 .Bl -tag -width Ds -compact
 .It Ic autogroup Ar group windowclass
-.It Ic autogroup Ar group windowname,windowclass
+.It Ic autogroup Ar group windowclass,windowname
 Automatically add new windows to
 .Ar group
 if their class property matches