On Tue, Dec 4, 2012 at 2:38 PM, Alexandre Ratchov <a...@caoua.org> wrote: > On Sat, Dec 01, 2012 at 05:14:46PM +0800, Ray Lai wrote: >> I'm not sure why jakemsr's diff[1] has AZ_QRK_GPIO_UNMUTE_1, my MBA >> works fine without it. I've tested both left and right channels on both >> speakers and headphones. >> >> -Ray- >> >> [1]: http://marc.info/?l=openbsd-misc&m=128919130029011&w=2 >> >> Index: dev/pci/azalia_codec.c >> =================================================================== >> RCS file: /home/cvs/src/sys/dev/pci/azalia_codec.c,v >> retrieving revision 1.152 >> diff -u -p -r1.152 azalia_codec.c >> --- dev/pci/azalia_codec.c 30 Nov 2012 12:05:45 -0000 1.152 >> +++ dev/pci/azalia_codec.c 1 Dec 2012 08:27:31 -0000 >> @@ -67,8 +67,7 @@ azalia_codec_init_vtbl(codec_t *this) >> case 0x10134206: >> this->name = "Cirrus Logic CS4206"; >> if (this->subid == 0xcb8910de) { /* APPLE_MBA3_1 */ >> - this->qrks |= AZ_QRK_GPIO_UNMUTE_1 | >> - AZ_QRK_GPIO_UNMUTE_3; >> + this->qrks |= AZ_QRK_GPIO_UNMUTE_3; >> } >> break; >> case 0x10ec0260: > > > Hey, > > Linux hda driver seems to use gpio 1 and 3 by default for most > apple products. Does the gpio 1 quirk hurts in any way? If it > doesn't, I'd leave it unless I'm missing the reason why it's not > needed. > > BTW, did you get any test reports? > > -- Alexandre
I agree. Other models/codecs/wiring may require both 1 and 3 gpio, so more general case is preferred here. Cheers, Alexey
