Re: Proposed small change for ping(8) -- updated diff

2015-04-06 Thread Gregory Edigarov


On 04/06/2015 07:02 AM, Philip Guenther wrote:

On Mon, Mar 30, 2015 at 9:19 AM, Gregory Edigarov ediga...@qarea.com wrote:

After discussing with Sven Falempin changed the message to Packet timed
out to be more exact
updated diff:

What's the output when ping packets or their replies are reordered?

Well, it should at first output the packet timed out but then it will 
show the normal output.. And this is the intended behaviour.


--
With best regards,
Gregory Edigarov



Re: Proposed small change for ping(8) -- updated diff

2015-04-05 Thread Philip Guenther
On Mon, Mar 30, 2015 at 9:19 AM, Gregory Edigarov ediga...@qarea.com wrote:
 After discussing with Sven Falempin changed the message to Packet timed
 out to be more exact
 updated diff:

What's the output when ping packets or their replies are reordered?


Philip Guenther



Re: Proposed small change for ping(8)

2015-03-30 Thread Gregory Edigarov

ping?
or no interest in this?

On 03/26/2015 02:34 PM, Gregory Edigarov wrote:

Hello,

This makes ping -v really verbose, telling about lost packets as they 
progress.


Index: ping.8
===
RCS file: /cvs/src/sbin/ping/ping.8,v
retrieving revision 1.52
diff -u -p -u -r1.52 ping.8
--- ping.8  24 Mar 2014 11:11:49 -  1.52
+++ ping.8  26 Mar 2015 12:28:44 -
@@ -199,7 +199,7 @@ Set the routing table to be used for out
 Verbose output.
 ICMP packets other than
 .Dv ECHO_REPLY
-that are received are listed.
+that are received are listed. Also reports lost packets as they go.
 .It Fl w Ar maxwait
 Specifies the maximum number of seconds to wait for responses
 after the last request has been sent.

Index: ping.c
===
RCS file: /cvs/src/sbin/ping/ping.c,v
retrieving revision 1.118
diff -u -p -u -r1.118 ping.c
--- ping.c  23 Mar 2015 09:36:25 -  1.118
+++ ping.c  26 Mar 2015 12:28:44 -
@@ -576,6 +576,8 @@ catcher(int signo)
nmissedmax = ntransmitted - nreceived - 1;
if (!(options  F_FLOOD)  (options  F_AUD_MISS))
write(STDERR_FILENO, \a, 1);
+   if (!(options  F_FLOOD)  (options  F_VERBOSE))
+   write(STDOUT_FILENO, Lost packet\n,12);
}
errno = save_errno;
 }





Proposed small change for ping(8)

2015-03-26 Thread Gregory Edigarov

Hello,

This makes ping -v really verbose, telling about lost packets as they 
progress.


Index: ping.8
===
RCS file: /cvs/src/sbin/ping/ping.8,v
retrieving revision 1.52
diff -u -p -u -r1.52 ping.8
--- ping.8  24 Mar 2014 11:11:49 -  1.52
+++ ping.8  26 Mar 2015 12:28:44 -
@@ -199,7 +199,7 @@ Set the routing table to be used for out
 Verbose output.
 ICMP packets other than
 .Dv ECHO_REPLY
-that are received are listed.
+that are received are listed. Also reports lost packets as they go.
 .It Fl w Ar maxwait
 Specifies the maximum number of seconds to wait for responses
 after the last request has been sent.

Index: ping.c
===
RCS file: /cvs/src/sbin/ping/ping.c,v
retrieving revision 1.118
diff -u -p -u -r1.118 ping.c
--- ping.c  23 Mar 2015 09:36:25 -  1.118
+++ ping.c  26 Mar 2015 12:28:44 -
@@ -576,6 +576,8 @@ catcher(int signo)
nmissedmax = ntransmitted - nreceived - 1;
if (!(options  F_FLOOD)  (options  F_AUD_MISS))
write(STDERR_FILENO, \a, 1);
+   if (!(options  F_FLOOD)  (options  F_VERBOSE))
+   write(STDOUT_FILENO, Lost packet\n,12);
}
errno = save_errno;
 }