On Thu, May 26, 2011 8:55 pm, Joe Gidi wrote:
Last week I picked up another Radeon HD 4350 card, expecting it to just
work like another 4350 I own. For whatever reason, the new card (same
manufacturer, same part number) has a different PCI ID and didn't work
until I patched in support for it.
I wasn't exactly sure what to call this new card; both Xenocara's
ati_pciids.csv file and the latest ati_pciids.csv from upstream call this
product ID an ATI Mobility Radeon 4300 Series.I went with Mobility
Radeon HD 4350, although my particular card is a regular PCI-E card for a
desktop PC.
In any case, the card is tested and works fine once the PCI ID is added,
and Xenocara already knows about it. Any developers willing to take a look
at this? I believe the flags are correct, though I can see it might be
misleading to call it a Mobility and not have RADEON_IS_MOBILITY in
the flags.
Index: sys/dev/pci/pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1602
diff -u -r1.1602 pcidevs
--- sys/dev/pci/pcidevs 22 May 2011 18:34:42 - 1.1602
+++ sys/dev/pci/pcidevs 27 May 2011 00:36:43 -
@@ -1338,6 +1338,7 @@
product ATI RADEON_HD38500x9505 Radeon HD 3850
product ATI RADEON_HD45500x9540 Radeon HD 4550
product ATI RADEON_HD43500x954f Radeon HD 4350
+product ATI RADEON_HD4350_M 0x9552 Mobility Radeon HD 4350
product ATI RADEON_HD4500_M 0x9553 Mobility Radeon HD 4500
product ATI RADEON_HD2600_M760x9581 Mobility Radeon HD 2600
product ATI RADEON_HD2600PROAGP 0x9587 Radeon HD 2600 Pro AGP
Index: sys/dev/pci/drm/radeon_drv.c
===
RCS file: /cvs/src/sys/dev/pci/drm/radeon_drv.c,v
retrieving revision 1.53
diff -u -r1.53 radeon_drv.c
--- sys/dev/pci/drm/radeon_drv.c 2 May 2011 10:22:13 - 1.53
+++ sys/dev/pci/drm/radeon_drv.c 27 May 2011 00:36:43 -
@@ -510,6 +510,8 @@
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP},
{PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4350,
CHIP_RV710|RADEON_NEW_MEMMAP},
+ {PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4350_M,
+ CHIP_RV710|RADEON_NEW_MEMMAP},
{PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4500_M,
CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP},
{PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4650,
--
Joe Gidi
j...@entropicblur.com
You cannot buy skill. -- Ross Seyfried
Apparently this should be a Mobility Radeon HD 4330; correct diff follows.
I have no idea why this HD 4350 PCI-E card thinks it belongs in a laptop,
but hardware makers do strange things...
Index: src/sys/dev/pci/pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1609
diff -u -r1.1609 pcidevs
--- src/sys/dev/pci/pcidevs 29 May 2011 20:24:21 - 1.1609
+++ src/sys/dev/pci/pcidevs 30 May 2011 21:06:19 -
@@ -1358,6 +1358,7 @@
product ATI RADEON_HD3850 0x9505 Radeon HD 3850
product ATI RADEON_HD4550 0x9540 Radeon HD 4550
product ATI RADEON_HD4350 0x954f Radeon HD 4350
+product ATI RADEON_HD4330_M0x9552 Mobility Radeon HD 4330
product ATI RADEON_HD4500_M0x9553 Mobility Radeon HD 4500
product ATI RADEON_HD2600_M76 0x9581 Mobility Radeon HD 2600
product ATI RADEON_HD2600PROAGP0x9587 Radeon HD 2600 Pro AGP
Index: src/sys/dev/pci/drm/radeon_drv.c
===
RCS file: /cvs/src/sys/dev/pci/drm/radeon_drv.c,v
retrieving revision 1.53
diff -u -r1.53 radeon_drv.c
--- src/sys/dev/pci/drm/radeon_drv.c2 May 2011 10:22:13 - 1.53
+++ src/sys/dev/pci/drm/radeon_drv.c30 May 2011 21:06:19 -
@@ -510,6 +510,8 @@
CHIP_RS780|RADEON_NEW_MEMMAP|RADEON_IS_IGP},
{PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4350,
CHIP_RV710|RADEON_NEW_MEMMAP},
+ {PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4330_M,
+ CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP},
{PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4500_M,
CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP},
{PCI_VENDOR_ATI, PCI_PRODUCT_ATI_RADEON_HD4650,
--
Joe Gidi
j...@entropicblur.com
You cannot buy skill. -- Ross Seyfried
