Re: A step towards support for Message Signaled Interrupts

2011-05-15 Thread Mark Kettenis 
> Date: Sun, 15 May 2011 07:31:46 +0200
> From: LEVAI Daniel 
> 
> > This diff completes the implementation of PCI "flags", making sure
> [...]
> 
> Hi!
> 
> Forgive my ignorance, but is PR 6523 related to this? Should I try this
> with that machine?
> 
> (http://marc.info/?l=openbsd-misc&m=126840264605078&w=2)

No

Re: A step towards support for Message Signaled Interrupts

2011-05-14 Thread Brad 

On 15/05/11 1:31 AM, LEVAI Daniel wrote:

This diff completes the implementation of PCI "flags", making sure

[...]

Hi!

Forgive my ignorance, but is PR 6523 related to this? Should I try this
with that machine?

(http://marc.info/?l=openbsd-misc&m=126840264605078&w=2)


Daniel


The PR has no relevance for this diff.


--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: A step towards support for Message Signaled Interrupts

2011-05-14 Thread LEVAI Daniel 
> This diff completes the implementation of PCI "flags", making sure
[...]

Hi!

Forgive my ignorance, but is PR 6523 related to this? Should I try this
with that machine?

(http://marc.info/?l=openbsd-misc&m=126840264605078&w=2)


Daniel

-- 
LIVAI Daniel
PGP key ID = 0x83B63A8F
Key fingerprint = DBEC C66B A47A DFA2 792D  650C C69B BE4C 83B6 3A8F

Re: A step towards support for Message Signaled Interrupts

2011-05-14 Thread Remco 
Mark Kettenis wrote:

> Index: pci.c
> ===
> RCS file: /cvs/src/sys/dev/pci/pci.c,v
> retrieving revision 1.89
> diff -u -p -r1.89 pci.c
> --- pci.c 12 Apr 2011 20:29:35 -  1.89
> +++ pci.c 13 May 2011 21:05:11 -
> @@ -167,6 +167,7 @@ pciattach(struct device *parent, struct
>  sc->sc_memt = pba->pba_memt;
>  sc->sc_dmat = pba->pba_dmat;
>  sc->sc_pc = pba->pba_pc;
> + sc->sc_flags = sc->sc_flags;
>  sc->sc_ioex = pba->pba_ioex;
>  sc->sc_memex = pba->pba_memex;
>  sc->sc_pmemex = pba->pba_pmemex;

This looks weird (assigning a value to oneself):
sc->sc_flags = sc->sc_flags;

Were you trying to do something like ?
sc->sc_flags = pba->pba_flags;

Or maybe I just don't have a clue.