Re: AIX patches to 'portable' maybe libressl-2.1.4 (2015-02-25 git)

2015-02-25 Thread Philip Guenther 
On Wed, Feb 25, 2015 at 8:38 AM, Todd C. Miller
 wrote:
> On Wed, 25 Feb 2015 14:57:56 +0100, Michael Felt wrote:
>
>> Lastly, the app certhash.c does not compile. AIX does not have O_DIRECTORY
>> defined, nor do I expect it is an acceptable argument to open (".",...)
>
> You should be able to just use O_RDONLY in the open.  There's not
> much point in using O_DIRECTORY here as "." can never be a file.
> The current code's omitting of O_RDONLY is not really correct.

Oops, yeah, I agree completely.  ok guenther@ for changing O_DIRECTORY
to O_RDONLY there.

Re: AIX patches to 'portable' maybe libressl-2.1.4 (2015-02-25 git)

2015-02-25 Thread Todd C. Miller 
On Wed, 25 Feb 2015 14:57:56 +0100, Michael Felt wrote:

> Lastly, the app certhash.c does not compile. AIX does not have O_DIRECTORY
> defined, nor do I expect it is an acceptable argument to open (".",...)

You should be able to just use O_RDONLY in the open.  There's not
much point in using O_DIRECTORY here as "." can never be a file.
The current code's omitting of O_RDONLY is not really correct.

 - todd