Re: pcidevs + azalia: patch for new intel audio
Jonathan Gray writes: > I can't find 0xf0c8 in the datasheets either. > > I've committed this but moved the added line in pcidevs to maintain > ordering by device id. Thanks for the patch. Great, thank you!
Re: pcidevs + azalia: patch for new intel audio
On Fri, Jun 11, 2021 at 10:03:07AM -0400, Ashton Fagg wrote:
> Friendly ping.
>
> Ashton Fagg writes:
>
> > My new Intel Z590-based machine seems to have some different kind of
> > Intel audio device onboard.
> >
> > I couldn't find very much online about it (all the usual pci id
> > databases don't seem to have it yet). The only really useful thing I
> > found was this:
> >
> > https://github.com/torvalds/linux/commit/f84d3a1ec375e46a55cc3ba85c04272b24bd3921#diff-bfe681fff464a07274400d493ba696cc6e10649a993ae7c1cfc1c29a106feda0
> >
> > This doesn't give much info but seems to indicate that it's a variant of
> > some existing chip.
I can't find 0xf0c8 in the datasheets either.
I've committed this but moved the added line in pcidevs to maintain
ordering by device id. Thanks for the patch.
> >
> > I gave this the not very descriptive name of
> > "PCI_PRODUCT_INTEL_500SERIES_HDA_2", since that's about all I could come
> > up with, since I'm assuming it's a variant of
> > "PCI_PRODUCT_INTEL_500SERIES_HDA".
> >
> > Patch which defines device in pcidevs and tells azalia how to
> > configure it is attached. Playback was the only thing I could readily
> > test and that's working - so my itch here has been scratched.
> >
> > I've also attached a dmesg output and a pcidump output (dmesg has also
> > been sent to dmesg@).
> >
> > Feedback greatly welcomed.
> >
> > Before:
> >
> > azalia0 at pci0 dev 31 function 3 vendor "Intel", unknown product 0xf0c8
> > rev 0x11: msi
> > azalia0: codecs: Realtek/0x0897, 0x/0x, using Realtek/0x0897
> > audio0 at azalia0
> >
> > After:
> >
> > azalia0 at pci0 dev 31 function 3 "Intel 500 Series HD Audio" rev 0x11: msi
> > azalia0: codecs: Realtek/0x0897, 0x/0x, using Realtek/0x0897
> > audio0 at azalia0
>
> Index: sys/dev/pci/azalia.c
> ===
> RCS file: /cvs/src/sys/dev/pci/azalia.c,v
> retrieving revision 1.262
> diff -u -p -u -p -r1.262 azalia.c
> --- sys/dev/pci/azalia.c 30 May 2021 02:54:36 - 1.262
> +++ sys/dev/pci/azalia.c 1 Jun 2021 01:20:42 -
> @@ -470,6 +470,7 @@ azalia_configure_pci(azalia_t *az)
> case PCI_PRODUCT_INTEL_400SERIES_LP_HDA:
> case PCI_PRODUCT_INTEL_495SERIES_LP_HDA:
> case PCI_PRODUCT_INTEL_500SERIES_HDA:
> + case PCI_PRODUCT_INTEL_500SERIES_HDA_2:
> case PCI_PRODUCT_INTEL_500SERIES_LP_HDA:
> case PCI_PRODUCT_INTEL_C600_HDA:
> case PCI_PRODUCT_INTEL_C610_HDA_1:
> Index: sys/dev/pci/pcidevs
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1970
> diff -u -p -u -p -r1.1970 pcidevs
> --- sys/dev/pci/pcidevs 19 May 2021 05:20:48 - 1.1970
> +++ sys/dev/pci/pcidevs 1 Jun 2021 01:20:42 -
> @@ -5371,6 +5371,7 @@ product INTEL 500SERIES_PCIE_22 0x43c5 5
> product INTEL 500SERIES_PCIE_23 0x43c6 500 Series PCIE
> product INTEL 500SERIES_PCIE_24 0x43c7 500 Series PCIE
> product INTEL 500SERIES_HDA 0x43c8 500 Series HD Audio
> +product INTEL 500SERIES_HDA_20xf0c8 500 Series HD Audio
> product INTEL 500SERIES_THC_00x43d0 500 Series THC
> product INTEL 500SERIES_THC_10x43d1 500 Series THC
> product INTEL 500SERIES_AHCI_1 0x43d2 500 Series AHCI
> Index: sys/dev/pci/pcidevs.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
> retrieving revision 1.1964
> diff -u -p -u -p -r1.1964 pcidevs.h
> --- sys/dev/pci/pcidevs.h 19 May 2021 05:21:24 - 1.1964
> +++ sys/dev/pci/pcidevs.h 1 Jun 2021 01:20:42 -
> @@ -5376,6 +5376,7 @@
> #define PCI_PRODUCT_INTEL_500SERIES_PCIE_23 0x43c6 /* 500
> Series PCIE */
> #define PCI_PRODUCT_INTEL_500SERIES_PCIE_24 0x43c7 /* 500
> Series PCIE */
> #define PCI_PRODUCT_INTEL_500SERIES_HDA 0x43c8 /* 500 Series
> HD Audio */
> +#define PCI_PRODUCT_INTEL_500SERIES_HDA_2 0xf0c8 /* 500
> Series HD Audio */
> #define PCI_PRODUCT_INTEL_500SERIES_THC_0 0x43d0 /* 500
> Series THC */
> #define PCI_PRODUCT_INTEL_500SERIES_THC_1 0x43d1 /* 500
> Series THC */
> #define PCI_PRODUCT_INTEL_500SERIES_AHCI_1 0x43d2 /* 500
> Series AHCI */
> Index: sys/dev/pci/pcidevs_data.h
> ===
> RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
> retrieving revision 1.1959
> diff -u -p -u -p -r1.1959 pcidevs_data.h
> --- sys/dev/pci/pcidevs_data.h19 May 2021 05:21:24 - 1.1959
> +++ sys/dev/pci/pcidevs_data.h1 Jun 2021 01:20:43 -
> @@ -18912,6 +18912,10 @@ static const struct pci_known_product pc
> "500 Series HD Audio",
> },
> {
> + PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_500SERIES_HDA_2,
> + "500 Series HD Audio",
> +
Re: pcidevs + azalia: patch for new intel audio
Friendly ping.
Ashton Fagg writes:
> My new Intel Z590-based machine seems to have some different kind of
> Intel audio device onboard.
>
> I couldn't find very much online about it (all the usual pci id
> databases don't seem to have it yet). The only really useful thing I
> found was this:
>
> https://github.com/torvalds/linux/commit/f84d3a1ec375e46a55cc3ba85c04272b24bd3921#diff-bfe681fff464a07274400d493ba696cc6e10649a993ae7c1cfc1c29a106feda0
>
> This doesn't give much info but seems to indicate that it's a variant of
> some existing chip.
>
> I gave this the not very descriptive name of
> "PCI_PRODUCT_INTEL_500SERIES_HDA_2", since that's about all I could come
> up with, since I'm assuming it's a variant of
> "PCI_PRODUCT_INTEL_500SERIES_HDA".
>
> Patch which defines device in pcidevs and tells azalia how to
> configure it is attached. Playback was the only thing I could readily
> test and that's working - so my itch here has been scratched.
>
> I've also attached a dmesg output and a pcidump output (dmesg has also
> been sent to dmesg@).
>
> Feedback greatly welcomed.
>
> Before:
>
> azalia0 at pci0 dev 31 function 3 vendor "Intel", unknown product 0xf0c8 rev
> 0x11: msi
> azalia0: codecs: Realtek/0x0897, 0x/0x, using Realtek/0x0897
> audio0 at azalia0
>
> After:
>
> azalia0 at pci0 dev 31 function 3 "Intel 500 Series HD Audio" rev 0x11: msi
> azalia0: codecs: Realtek/0x0897, 0x/0x, using Realtek/0x0897
> audio0 at azalia0
Index: sys/dev/pci/azalia.c
===
RCS file: /cvs/src/sys/dev/pci/azalia.c,v
retrieving revision 1.262
diff -u -p -u -p -r1.262 azalia.c
--- sys/dev/pci/azalia.c 30 May 2021 02:54:36 - 1.262
+++ sys/dev/pci/azalia.c 1 Jun 2021 01:20:42 -
@@ -470,6 +470,7 @@ azalia_configure_pci(azalia_t *az)
case PCI_PRODUCT_INTEL_400SERIES_LP_HDA:
case PCI_PRODUCT_INTEL_495SERIES_LP_HDA:
case PCI_PRODUCT_INTEL_500SERIES_HDA:
+ case PCI_PRODUCT_INTEL_500SERIES_HDA_2:
case PCI_PRODUCT_INTEL_500SERIES_LP_HDA:
case PCI_PRODUCT_INTEL_C600_HDA:
case PCI_PRODUCT_INTEL_C610_HDA_1:
Index: sys/dev/pci/pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1970
diff -u -p -u -p -r1.1970 pcidevs
--- sys/dev/pci/pcidevs 19 May 2021 05:20:48 - 1.1970
+++ sys/dev/pci/pcidevs 1 Jun 2021 01:20:42 -
@@ -5371,6 +5371,7 @@ product INTEL 500SERIES_PCIE_22 0x43c5 5
product INTEL 500SERIES_PCIE_23 0x43c6 500 Series PCIE
product INTEL 500SERIES_PCIE_24 0x43c7 500 Series PCIE
product INTEL 500SERIES_HDA 0x43c8 500 Series HD Audio
+product INTEL 500SERIES_HDA_2 0xf0c8 500 Series HD Audio
product INTEL 500SERIES_THC_0 0x43d0 500 Series THC
product INTEL 500SERIES_THC_1 0x43d1 500 Series THC
product INTEL 500SERIES_AHCI_1 0x43d2 500 Series AHCI
Index: sys/dev/pci/pcidevs.h
===
RCS file: /cvs/src/sys/dev/pci/pcidevs.h,v
retrieving revision 1.1964
diff -u -p -u -p -r1.1964 pcidevs.h
--- sys/dev/pci/pcidevs.h 19 May 2021 05:21:24 - 1.1964
+++ sys/dev/pci/pcidevs.h 1 Jun 2021 01:20:42 -
@@ -5376,6 +5376,7 @@
#define PCI_PRODUCT_INTEL_500SERIES_PCIE_23 0x43c6 /* 500 Series PCIE */
#define PCI_PRODUCT_INTEL_500SERIES_PCIE_24 0x43c7 /* 500 Series PCIE */
#define PCI_PRODUCT_INTEL_500SERIES_HDA 0x43c8 /* 500 Series HD Audio */
+#define PCI_PRODUCT_INTEL_500SERIES_HDA_2 0xf0c8 /* 500 Series HD Audio */
#define PCI_PRODUCT_INTEL_500SERIES_THC_0 0x43d0 /* 500 Series THC */
#define PCI_PRODUCT_INTEL_500SERIES_THC_1 0x43d1 /* 500 Series THC */
#define PCI_PRODUCT_INTEL_500SERIES_AHCI_1 0x43d2 /* 500 Series AHCI */
Index: sys/dev/pci/pcidevs_data.h
===
RCS file: /cvs/src/sys/dev/pci/pcidevs_data.h,v
retrieving revision 1.1959
diff -u -p -u -p -r1.1959 pcidevs_data.h
--- sys/dev/pci/pcidevs_data.h 19 May 2021 05:21:24 - 1.1959
+++ sys/dev/pci/pcidevs_data.h 1 Jun 2021 01:20:43 -
@@ -18912,6 +18912,10 @@ static const struct pci_known_product pc
"500 Series HD Audio",
},
{
+ PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_500SERIES_HDA_2,
+ "500 Series HD Audio",
+ },
+ {
PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_500SERIES_THC_0,
"500 Series THC",
},
