Re: ifconfig setinstance -> setrdomain

[Jeremie Courreges-Anglas]

Stefan Sperling  writes:

> 'instance' is the name of an ifconfig subcommand related to ifmedia
> so the name of the setinstance() function is slightly confusing.

ok

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: ifconfig setinstance -> setrdomain

[Claudio Jeker]

On Wed, Aug 31, 2016 at 02:23:00PM +0200, Stefan Sperling wrote:
> 'instance' is the name of an ifconfig subcommand related to ifmedia
> so the name of the setinstance() function is slightly confusing.

OK
 
> Index: ifconfig.c
> ===
> RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v
> retrieving revision 1.327
> diff -u -p -r1.327 ifconfig.c
> --- ifconfig.c19 Aug 2016 09:06:24 -  1.327
> +++ ifconfig.c31 Aug 2016 12:19:48 -
> @@ -218,7 +218,7 @@ void  unsetvlandev(const char *, int);
>  void mpe_status(void);
>  void mpw_status(void);
>  void vlan_status(void);
> -void setinstance(const char *, int);
> +void setrdomain(const char *, int);
>  int  main(int, char *[]);
>  int  prefix(void *val, int);
>  void getifgroups(void);
> @@ -392,7 +392,7 @@ const struct  cmd {
>   { "priority",   NEXTARG,0,  setifpriority },
>   { "rtlabel",NEXTARG,0,  setifrtlabel },
>   { "-rtlabel",   -1, 0,  setifrtlabel },
> - { "rdomain",NEXTARG,0,  setinstance },
> + { "rdomain",NEXTARG,0,  setrdomain },
>   { "mpls",   IFXF_MPLS,  0,  setifxflags },
>   { "-mpls",  -IFXF_MPLS, 0,  setifxflags },
>   { "mplslabel",  NEXTARG,0,  setmpelabel },
> @@ -5675,7 +5675,7 @@ setiflladdr(const char *addr, int param)
>  
>  #ifndef SMALL
>  void
> -setinstance(const char *id, int param)
> +setrdomain(const char *id, int param)
>  {
>   const char *errmsg = NULL;
>   int rdomainid;
> 

-- 
:wq Claudio

ifconfig setinstance -> setrdomain

[Stefan Sperling]

'instance' is the name of an ifconfig subcommand related to ifmedia
so the name of the setinstance() function is slightly confusing.

Index: ifconfig.c
===
RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.327
diff -u -p -r1.327 ifconfig.c
--- ifconfig.c  19 Aug 2016 09:06:24 -  1.327
+++ ifconfig.c  31 Aug 2016 12:19:48 -
@@ -218,7 +218,7 @@ voidunsetvlandev(const char *, int);
 void   mpe_status(void);
 void   mpw_status(void);
 void   vlan_status(void);
-void   setinstance(const char *, int);
+void   setrdomain(const char *, int);
 intmain(int, char *[]);
 intprefix(void *val, int);
 void   getifgroups(void);
@@ -392,7 +392,7 @@ const structcmd {
{ "priority",   NEXTARG,0,  setifpriority },
{ "rtlabel",NEXTARG,0,  setifrtlabel },
{ "-rtlabel",   -1, 0,  setifrtlabel },
-   { "rdomain",NEXTARG,0,  setinstance },
+   { "rdomain",NEXTARG,0,  setrdomain },
{ "mpls",   IFXF_MPLS,  0,  setifxflags },
{ "-mpls",  -IFXF_MPLS, 0,  setifxflags },
{ "mplslabel",  NEXTARG,0,  setmpelabel },
@@ -5675,7 +5675,7 @@ setiflladdr(const char *addr, int param)
 
 #ifndef SMALL
 void
-setinstance(const char *id, int param)
+setrdomain(const char *id, int param)
 {
const char *errmsg = NULL;
int rdomainid;