Re: ksyms uiomove() conversion

[Mark Kettenis]

> Date: Sun, 10 Jan 2016 19:44:27 +0100
> From: Stefan Kempf 
> 
> Martin Natano wrote:
> > Below the uiomove() conversion for dev/ksyms.c. 'len' is a size_t.
> 
> And len is computed from values >= 0 and from expressions that do not
> wrap around.
> 
> ok?

ok kettenis@

> > Index: dev/ksyms.c
> > ===
> > RCS file: /cvs/src/sys/dev/ksyms.c,v
> > retrieving revision 1.30
> > diff -u -p -u -r1.30 ksyms.c
> > --- dev/ksyms.c 29 Aug 2015 01:58:39 -  1.30
> > +++ dev/ksyms.c 9 Jan 2016 08:16:50 -
> > @@ -164,7 +164,7 @@ ksymsread(dev_t dev, struct uio *uio, in
> > if (len > uio->uio_resid)
> > len = uio->uio_resid;
> >  
> > -   if ((error = uiomovei(v, len, uio)) != 0)
> > +   if ((error = uiomove(v, len, uio)) != 0)
> > return (error);
> > }
> >  
> > cheers,
> > natano
> > 
> 
> 

Re: ksyms uiomove() conversion

[Stefan Kempf]

Martin Natano wrote:
> Below the uiomove() conversion for dev/ksyms.c. 'len' is a size_t.

And len is computed from values >= 0 and from expressions that do not
wrap around.

ok?
 
> Index: dev/ksyms.c
> ===
> RCS file: /cvs/src/sys/dev/ksyms.c,v
> retrieving revision 1.30
> diff -u -p -u -r1.30 ksyms.c
> --- dev/ksyms.c   29 Aug 2015 01:58:39 -  1.30
> +++ dev/ksyms.c   9 Jan 2016 08:16:50 -
> @@ -164,7 +164,7 @@ ksymsread(dev_t dev, struct uio *uio, in
>   if (len > uio->uio_resid)
>   len = uio->uio_resid;
>  
> - if ((error = uiomovei(v, len, uio)) != 0)
> + if ((error = uiomove(v, len, uio)) != 0)
>   return (error);
>   }
>  
> cheers,
> natano
> 

ksyms uiomove() conversion

[Martin Natano]

Below the uiomove() conversion for dev/ksyms.c. 'len' is a size_t.

Index: dev/ksyms.c
===
RCS file: /cvs/src/sys/dev/ksyms.c,v
retrieving revision 1.30
diff -u -p -u -r1.30 ksyms.c
--- dev/ksyms.c 29 Aug 2015 01:58:39 -  1.30
+++ dev/ksyms.c 9 Jan 2016 08:16:50 -
@@ -164,7 +164,7 @@ ksymsread(dev_t dev, struct uio *uio, in
if (len > uio->uio_resid)
len = uio->uio_resid;
 
-   if ((error = uiomovei(v, len, uio)) != 0)
+   if ((error = uiomove(v, len, uio)) != 0)
return (error);
}
 
cheers,
natano