yeah, i know. no need to cast to char *. also, no need to cast void
return of bzero to void.
Index: rf_alloclist.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_alloclist.c,v
retrieving revision 1.4
diff -u -r1.4 rf_alloclist.c
--- rf_alloclist.c 16 Dec 2002 07:01:03 -0000 1.4
+++ rf_alloclist.c 20 Jun 2011 22:17:04 -0000
@@ -185,6 +185,6 @@
if (p == NULL) {
return (NULL);
}
- bzero((char *) p, sizeof(RF_AllocListElem_t));
+ bzero(p, sizeof(RF_AllocListElem_t));
return (p);
}
Index: rf_cvscan.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_cvscan.c,v
retrieving revision 1.5
diff -u -r1.5 rf_cvscan.c
--- rf_cvscan.c 16 Dec 2002 07:01:03 -0000 1.5
+++ rf_cvscan.c 20 Jun 2011 22:17:10 -0000
@@ -352,7 +352,7 @@
RF_MallocAndAdd(hdr, sizeof(RF_CvscanHeader_t), (RF_CvscanHeader_t *),
clList);
- bzero((char *) hdr, sizeof(RF_CvscanHeader_t));
+ bzero(hdr, sizeof(RF_CvscanHeader_t));
hdr->range_for_avg = RF_MAX(range, 1);
hdr->change_penalty = RF_MAX(penalty, 0);
hdr->direction = rf_cvscan_RIGHT;
Index: rf_dagutils.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_dagutils.c,v
retrieving revision 1.4
diff -u -r1.4 rf_dagutils.c
--- rf_dagutils.c 16 Dec 2002 07:01:03 -0000 1.4
+++ rf_dagutils.c 20 Jun 2011 22:17:20 -0000
@@ -246,7 +246,7 @@
RF_FREELIST_GET(rf_dagh_freelist, dh, next, (RF_DagHeader_t *));
if (dh) {
- bzero((char *) dh, sizeof(RF_DagHeader_t));
+ bzero(dh, sizeof(RF_DagHeader_t));
}
return (dh);
}
Index: rf_driver.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_driver.c,v
retrieving revision 1.12
diff -u -r1.12 rf_driver.c
--- rf_driver.c 26 Jun 2008 05:42:17 -0000 1.12
+++ rf_driver.c 20 Jun 2011 22:17:25 -0000
@@ -636,7 +636,7 @@
desc->state = 0;
desc->status = 0;
- bzero((char *) &desc->tracerec, sizeof(RF_AccTraceEntry_t));
+ bzero(&desc->tracerec, sizeof(RF_AccTraceEntry_t));
desc->callbackFunc = (void (*) (RF_CBParam_t)) cbF; /* XXX */
desc->callbackArg = cbA;
desc->next = NULL;
Index: rf_evenodd.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_evenodd.c,v
retrieving revision 1.5
diff -u -r1.5 rf_evenodd.c
--- rf_evenodd.c 16 Dec 2002 07:01:03 -0000 1.5
+++ rf_evenodd.c 20 Jun 2011 22:17:44 -0000
@@ -529,7 +529,7 @@
asmap->qInfo;
/* Fire off the DAG. */
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
rd_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug) {
@@ -601,7 +601,7 @@
wrBlock->succedents[0]->params[2].v = psID;
wrBlock->succedents[0]->params[3].v =
RF_CREATE_PARAM3(RF_IO_NORMAL_PRIORITY, 0, 0, which_ru);
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
wr_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug) {
printf("Parity verify write dag:\n");
@@ -633,7 +633,7 @@
wrBlock->succedents[0]->params[2].v = psID;
wrBlock->succedents[0]->params[3].v =
RF_CREATE_PARAM3(RF_IO_NORMAL_PRIORITY, 0, 0, which_ru);
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
wr_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug) {
printf("Dag of write new second redundant information"
Index: rf_evenodd_dagfuncs.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_evenodd_dagfuncs.c,v
retrieving revision 1.7
diff -u -r1.7 rf_evenodd_dagfuncs.c
--- rf_evenodd_dagfuncs.c 16 Dec 2002 07:01:04 -0000 1.7
+++ rf_evenodd_dagfuncs.c 20 Jun 2011 22:18:11 -0000
@@ -454,7 +454,7 @@
RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
RF_Etimer_t timer;
- bzero((char *) node->results[0], rf_RaidAddressToByte(raidPtr,
failedPDA->numSector));
+ bzero(node->results[0], rf_RaidAddressToByte(raidPtr,
failedPDA->numSector));
if (node->dagHdr->status == rf_enable) {
RF_ETIMER_START(timer);
for (i = 0; i < node->numParams - 2; i += 2)
@@ -538,8 +538,8 @@
#endif
RF_ASSERT(*((long *) dest[0]) == 0);
RF_ASSERT(*((long *) dest[1]) == 0);
- bzero((char *) P, bytesPerEU);
- bzero((char *) temp, bytesPerEU);
+ bzero(P, bytesPerEU);
+ bzero(temp, bytesPerEU);
RF_ASSERT(*P == 0);
/*
* Calculate the 'P' parameter, which, not parity, is the Xor of all
Index: rf_map.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_map.c,v
retrieving revision 1.5
diff -u -r1.5 rf_map.c
--- rf_map.c 16 Dec 2002 07:01:04 -0000 1.5
+++ rf_map.c 20 Jun 2011 22:18:52 -0000
@@ -136,7 +136,7 @@
RF_ASSERT(asmList);
t_asm = asmList;
asmList = asmList->next;
- bzero((char *) t_asm, sizeof(RF_AccessStripeMap_t));
+ bzero(t_asm, sizeof(RF_AccessStripeMap_t));
if (!asm_p)
asm_list = asm_p = t_asm;
else {
@@ -167,7 +167,7 @@
RF_ASSERT(pdaList);
t_pda = pdaList;
pdaList = pdaList->next;
- bzero((char *) t_pda, sizeof(RF_PhysDiskAddr_t));
+ bzero(t_pda, sizeof(RF_PhysDiskAddr_t));
if (!pda_p)
asm_p->physInfo = pda_p = t_pda;
else {
@@ -224,7 +224,7 @@
RF_ASSERT(pdaList);
t_pda = pdaList;
pdaList = pdaList->next;
- bzero((char *) t_pda, sizeof(RF_PhysDiskAddr_t));
+ bzero(t_pda, sizeof(RF_PhysDiskAddr_t));
pda_p = asm_p->parityInfo = t_pda;
pda_p->type = RF_PDA_TYPE_PARITY;
(layoutPtr->map->MapParity) (raidPtr,
@@ -248,12 +248,12 @@
RF_ASSERT(pdaList && pdaList->next);
t_pda = pdaList;
pdaList = pdaList->next;
- bzero((char *) t_pda, sizeof(RF_PhysDiskAddr_t));
+ bzero(t_pda, sizeof(RF_PhysDiskAddr_t));
pda_p = asm_p->parityInfo = t_pda;
pda_p->type = RF_PDA_TYPE_PARITY;
t_pda = pdaList;
pdaList = pdaList->next;
- bzero((char *) t_pda, sizeof(RF_PhysDiskAddr_t));
+ bzero(t_pda, sizeof(RF_PhysDiskAddr_t));
pda_q = asm_p->qInfo = t_pda;
pda_q->type = RF_PDA_TYPE_Q;
(layoutPtr->map->MapParity) (raidPtr,
@@ -316,7 +316,7 @@
asmap->numDataFailed = asmap->numParityFailed =
asmap->numQFailed = 0;
asmap->numFailedPDAs = 0;
- bzero((char *) asmap->failedPDAs,
+ bzero(asmap->failedPDAs,
RF_MAX_FAILED_PDA * sizeof(RF_PhysDiskAddr_t *));
for (pda = asmap->physInfo; pda; pda = pda->next) {
if (RF_DEAD_DISK(disks[pda->row][pda->col].status)) {
@@ -497,7 +497,7 @@
RF_FREELIST_GET(rf_asmhdr_freelist, p, next,
(RF_AccessStripeMapHeader_t *));
- bzero((char *) p, sizeof(RF_AccessStripeMapHeader_t));
+ bzero(p, sizeof(RF_AccessStripeMapHeader_t));
return (p);
}
@@ -514,7 +514,7 @@
RF_PhysDiskAddr_t *p;
RF_FREELIST_GET(rf_pda_freelist, p, next, (RF_PhysDiskAddr_t *));
- bzero((char *) p, sizeof(RF_PhysDiskAddr_t));
+ bzero(p, sizeof(RF_PhysDiskAddr_t));
return (p);
}
@@ -559,7 +559,7 @@
RF_AccessStripeMap_t *p;
RF_FREELIST_GET(rf_asm_freelist, p, next, (RF_AccessStripeMap_t *));
- bzero((char *) p, sizeof(RF_AccessStripeMap_t));
+ bzero(p, sizeof(RF_AccessStripeMap_t));
return (p);
}
Index: rf_memchunk.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_memchunk.c,v
retrieving revision 1.4
diff -u -r1.4 rf_memchunk.c
--- rf_memchunk.c 16 Dec 2002 07:01:04 -0000 1.4
+++ rf_memchunk.c 20 Jun 2011 22:18:58 -0000
@@ -179,7 +179,7 @@
p = rf_NewMemChunk(size, buf);
}
RF_UNLOCK_MUTEX(chunkmutex);
- (void) bzero(p->buf, size);
+ bzero(p->buf, size);
return (p);
}
Index: rf_openbsdkintf.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_openbsdkintf.c,v
retrieving revision 1.63
diff -u -r1.63 rf_openbsdkintf.c
--- rf_openbsdkintf.c 5 Jun 2011 18:40:33 -0000 1.63
+++ rf_openbsdkintf.c 20 Jun 2011 22:19:10 -0000
@@ -961,7 +961,7 @@
* there is no stale data left in the case of a
* reconfiguration.
*/
- bzero((char *) raidPtr, sizeof(RF_Raid_t));
+ bzero(raidPtr, sizeof(RF_Raid_t));
/* Configure the system. */
raidPtr->raidid = unit;
@@ -1042,7 +1042,7 @@
if (clabel == NULL)
return (ENOMEM);
- bzero((char *) clabel, sizeof(RF_ComponentLabel_t));
+ bzero(clabel, sizeof(RF_ComponentLabel_t));
retcode = copyin( *clabel_ptr, clabel,
sizeof(RF_ComponentLabel_t));
@@ -1241,7 +1241,7 @@
(RF_DeviceConfig_t *));
if (d_cfg == NULL)
return (ENOMEM);
- bzero((char *) d_cfg, sizeof(RF_DeviceConfig_t));
+ bzero(d_cfg, sizeof(RF_DeviceConfig_t));
d_cfg->rows = raidPtr->numRow;
d_cfg->cols = raidPtr->numCol;
d_cfg->ndevs = raidPtr->numRow * raidPtr->numCol;
Index: rf_paritylogDiskMgr.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_paritylogDiskMgr.c,v
retrieving revision 1.6
diff -u -r1.6 rf_paritylogDiskMgr.c
--- rf_paritylogDiskMgr.c 16 Dec 2002 07:01:04 -0000 1.6
+++ rf_paritylogDiskMgr.c 20 Jun 2011 22:19:26 -0000
@@ -154,7 +154,7 @@
}
/* Initialize DAG parameters. */
RF_Malloc(tracerec, sizeof(RF_AccTraceEntry_t), (RF_AccTraceEntry_t *));
- bzero((char *) tracerec, sizeof(RF_AccTraceEntry_t));
+ bzero(tracerec, sizeof(RF_AccTraceEntry_t));
(*rrd_dag_h)->tracerec = tracerec;
rrd_rdNode = (*rrd_dag_h)->succedents[0]->succedents[0];
rrd_rdNode->params[0].p = *rrd_pda;
@@ -203,7 +203,7 @@
/* Initialize DAG parameters. */
RF_Malloc(tracerec, sizeof(RF_AccTraceEntry_t), (RF_AccTraceEntry_t *));
- bzero((char *) tracerec, sizeof(RF_AccTraceEntry_t));
+ bzero(tracerec, sizeof(RF_AccTraceEntry_t));
(*fwr_dag_h)->tracerec = tracerec;
fwr_wrNode = (*fwr_dag_h)->succedents[0]->succedents[0];
fwr_wrNode->params[0].p = *fwr_pda;
@@ -255,7 +255,7 @@
}
/* Initialize DAG parameters. */
RF_Malloc(tracerec, sizeof(RF_AccTraceEntry_t), (RF_AccTraceEntry_t *));
- bzero((char *) tracerec, sizeof(RF_AccTraceEntry_t));
+ bzero(tracerec, sizeof(RF_AccTraceEntry_t));
(*prd_dag_h)->tracerec = tracerec;
prd_rdNode = (*prd_dag_h)->succedents[0]->succedents[0];
prd_rdNode->params[0].p = *prd_pda;
@@ -301,7 +301,7 @@
/* Initialize DAG parameters. */
RF_Malloc(tracerec, sizeof(RF_AccTraceEntry_t), (RF_AccTraceEntry_t *));
- bzero((char *) tracerec, sizeof(RF_AccTraceEntry_t));
+ bzero(tracerec, sizeof(RF_AccTraceEntry_t));
(*pwr_dag_h)->tracerec = tracerec;
pwr_wrNode = (*pwr_dag_h)->succedents[0]->succedents[0];
pwr_wrNode->params[0].p = *pwr_pda;
Index: rf_parityscan.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_parityscan.c,v
retrieving revision 1.7
diff -u -r1.7 rf_parityscan.c
--- rf_parityscan.c 16 Dec 2002 07:01:04 -0000 1.7
+++ rf_parityscan.c 20 Jun 2011 22:19:34 -0000
@@ -247,7 +247,7 @@
asmap->parityInfo;
/* Fire off the DAG. */
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
rd_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug) {
@@ -298,7 +298,7 @@
wrBlock->succedents[0]->params[2].v = psID;
wrBlock->succedents[0]->params[3].v =
RF_CREATE_PARAM3(RF_IO_NORMAL_PRIORITY, 0, 0, which_ru);
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
wr_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug) {
printf("Parity verify write dag:\n");
Index: rf_raid1.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_raid1.c,v
retrieving revision 1.5
diff -u -r1.5 rf_raid1.c
--- rf_raid1.c 16 Dec 2002 07:01:04 -0000 1.5
+++ rf_raid1.c 20 Jun 2011 22:19:53 -0000
@@ -395,7 +395,7 @@
}
RF_ASSERT(pda == NULL);
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
rd_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug > 1) {
@@ -511,7 +511,7 @@
RF_CREATE_PARAM3(RF_IO_NORMAL_PRIORITY, 0, 0,
which_ru);
}
- bzero((char *) &tracerec, sizeof(tracerec));
+ bzero(&tracerec, sizeof(tracerec));
wr_dag_h->tracerec = &tracerec;
if (rf_verifyParityDebug > 1) {
printf("Parity verify write dag:\n");
Index: rf_reconmap.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_reconmap.c,v
retrieving revision 1.4
diff -u -r1.4 rf_reconmap.c
--- rf_reconmap.c 16 Dec 2002 07:01:05 -0000 1.4
+++ rf_reconmap.c 20 Jun 2011 22:20:05 -0000
@@ -102,7 +102,7 @@
(RF_ReconMapListElem_t **));
RF_ASSERT(p->status != (RF_ReconMapListElem_t **) NULL);
- (void) bzero((char *) p->status, num_rus *
+ bzero(p->status, num_rus *
sizeof(RF_ReconMapListElem_t *));
p->size = sizeof(RF_ReconMap_t) + num_rus *
Index: rf_reconstruct.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_reconstruct.c,v
retrieving revision 1.17
diff -u -r1.17 rf_reconstruct.c
--- rf_reconstruct.c 23 May 2010 13:49:35 -0000 1.17
+++ rf_reconstruct.c 20 Jun 2011 22:20:10 -0000
@@ -1165,7 +1165,7 @@
*/
rbuf->parityStripeID = ctrl->curPSID;
rbuf->which_ru = ctrl->ru_count;
- bzero((char *) &raidPtr->recon_tracerecs[col],
+ bzero(&raidPtr->recon_tracerecs[col],
sizeof(raidPtr->recon_tracerecs[col]));
raidPtr->recon_tracerecs[col].reconacc = 1;
RF_ETIMER_START(raidPtr->recon_tracerecs[col].recon_timer);
Index: rf_utils.c
===================================================================
RCS file: /home/tedu/cvs/src/sys/dev/raidframe/rf_utils.c,v
retrieving revision 1.5
diff -u -r1.5 rf_utils.c
--- rf_utils.c 16 Dec 2002 07:01:05 -0000 1.5
+++ rf_utils.c 20 Jun 2011 22:20:23 -0000
@@ -55,7 +55,7 @@
for (i = 0; i < b; i++) {
RF_MallocAndAdd(retval[i], k * sizeof(RF_RowCol_t),
(RF_RowCol_t *), allocList);
- bzero((char *) retval[i], k * sizeof(RF_RowCol_t));
+ bzero(retval[i], k * sizeof(RF_RowCol_t));
}
return (retval);
}
@@ -78,7 +78,7 @@
RF_MallocAndAdd(retval, c * sizeof(RF_RowCol_t), (RF_RowCol_t *),
allocList);
- bzero((char *) retval, c * sizeof(RF_RowCol_t));
+ bzero(retval, c * sizeof(RF_RowCol_t));
return (retval);
}
