Module name - recommendations/opinions sought
I'm in the process of modularizing the ieee80211 (Wireless LAN) code, and would like some feedback on what the module's name should be. I can think of at least three or four likely candidates: net80211 ieee80211 wlan wireless-lan I'm leaning towards the simplest one - wlan - but would like to know what others think before I commit. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: Module name - recommendations/opinions sought
On Wed, Apr 25, 2012 at 05:52:31PM -0700, Paul Goyette wrote: I'm in the process of modularizing the ieee80211 (Wireless LAN) code, and would like some feedback on what the module's name should be. I can think of at least three or four likely candidates: net80211 ieee80211 I'd vote for one of these, myself, since there's a correspondence with a directory name in the first case and with a prefix on a lot of the API names in the second case. Dave -- David Young dyo...@pobox.comUrbana, IL(217) 721-9981
link_set info needed
I've been working on modularizing the ieee80211 code, and I've
discovered that the code using a link_set to collect various one-time
initialization routines. There is a RUN_ONCE() invocation that uses
__link_set_for_each() to iterate over these init routines.
This all works just fine when including net80211 in a monolithic kernel,
but for some reason, when building as a module, the link_set sections
don't seem to get created (they're not listed by objdump -h).
__link_set_for_each tries to loop through the items in
{start,stop}_link_set_set-name - these items are contributed by
other source files. But the symbols that should identify the start and
stop of the link set are undefined.
Any suggestions on an appropriate alternate to link sets to collect the
contributions?
If anyone wants to look at the actual code, it is in
src/sys/net80211/ieee80211_netbsd.[ch]
Thanks!
-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
Re: Module name - recommendations/opinions sought
In article 20120426013452.gl20...@pixotech.com, David Young dyo...@pobox.com wrote: On Wed, Apr 25, 2012 at 05:52:31PM -0700, Paul Goyette wrote: I'm in the process of modularizing the ieee80211 (Wireless LAN) code, and would like some feedback on what the module's name should be. I can think of at least three or four likely candidates: net80211 ieee80211 I'd vote for one of these, myself, since there's a correspondence with a directory name in the first case and with a prefix on a lot of the API names in the second case. I vote for the first, because this is the one I would make the association with. christos
Re: link_set info needed
link set won't work for modules. ISTR pooka@ did a work-around for
RUMP or whatever.
(Ideal alternative is decent ctors/dtors support.)
On Thu, Apr 26, 2012 at 11:44 AM, Paul Goyette p...@whooppee.com wrote:
I've been working on modularizing the ieee80211 code, and I've discovered
that the code using a link_set to collect various one-time initialization
routines. There is a RUN_ONCE() invocation that uses __link_set_for_each()
to iterate over these init routines.
This all works just fine when including net80211 in a monolithic kernel, but
for some reason, when building as a module, the link_set sections don't seem
to get created (they're not listed by objdump -h).
__link_set_for_each tries to loop through the items in
{start,stop}_link_set_set-name - these items are contributed by other
source files. But the symbols that should identify the start and stop of
the link set are undefined.
Any suggestions on an appropriate alternate to link sets to collect the
contributions?
If anyone wants to look at the actual code, it is in
src/sys/net80211/ieee80211_netbsd.[ch]
Thanks!
-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses: |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer | | pgoyette at netbsd.org |
-
Re: Module name - recommendations/opinions sought
I thought module names alway match what's define'ed in config(1) files... ... and now I've found it's wlan, which should be changed to a saner name like net80211. On Thu, Apr 26, 2012 at 9:52 AM, Paul Goyette p...@whooppee.com wrote: I'm in the process of modularizing the ieee80211 (Wireless LAN) code, and would like some feedback on what the module's name should be. I can think of at least three or four likely candidates: net80211 ieee80211 wlan wireless-lan I'm leaning towards the simplest one - wlan - but would like to know what others think before I commit. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: Module name - recommendations/opinions sought
Yes, wlan was my first choice, cimply because that is the name of the config attribute. But it seems a consensus is emerging that the module name should be net80211 so that's what I'm going to do (assuming I figure out the link_set issue). I'll leave the rototilling of the config files for another day. On Thu, 26 Apr 2012, Masao Uebayashi wrote: I thought module names alway match what's define'ed in config(1) files... ... and now I've found it's wlan, which should be changed to a saner name like net80211. On Thu, Apr 26, 2012 at 9:52 AM, Paul Goyette p...@whooppee.com wrote: I'm in the process of modularizing the ieee80211 (Wireless LAN) code, and would like some feedback on what the module's name should be. I can think of at least three or four likely candidates: net80211 ieee80211 wlan wireless-lan I'm leaning towards the simplest one - wlan - but would like to know what others think before I commit. - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com | | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | - !DSPAM:4f98c4322402014054294! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: Module name - recommendations/opinions sought
On Sep 16, 7:17am, Masao Uebayashi wrote: } } I thought module names alway match what's define'ed in config(1) files... At this time, config(1) has absolutely nothing to do with modules. There is a movement afoot to change that. I'll just say that I don't agree with changing that, but I don't feel like getting into yet another flamewar and certainly don't have time to do so, so I won't say anything else on the subject. }-- End of excerpt from Masao Uebayashi
Can't get 100% CPU on all cores
Is this a NetBSD issue, or something else? load averages: 7.99, 7.94, 7.91; up 0+21:43:0721:25:56 34 processes: 2 runnable, 24 sleeping, 8 on CPU CPU0 states: 0.0% user, 100% nice, 0.0% system, 0.0% interrupt, 0.0% idle CPU1 states: 0.0% user, 100% nice, 0.0% system, 0.0% interrupt, 0.0% idle CPU2 states: 0.0% user, 39.7% nice, 0.0% system, 0.0% interrupt, 60.3% idle CPU3 states: 0.0% user, 100% nice, 0.0% system, 0.0% interrupt, 0.0% idle CPU4 states: 0.0% user, 100% nice, 0.0% system, 0.0% interrupt, 0.0% idle CPU5 states: 0.0% user, 100% nice, 0.0% system, 0.0% interrupt, 0.0% idle CPU6 states: 0.0% user, 100% nice, 0.0% system, 0.0% interrupt, 0.0% idle CPU7 states: 0.0% user, 99.6% nice, 0.4% system, 0.0% interrupt, 0.0% idle Memory: 1732M Act, 10M Exec, 1698M File, 27G Free Swap: 8193M Total, 8193M Free PID USERNAME PRI NICE SIZE RES STATE TIME WCPUCPU COMMAND 6102 john 5 20 8256K 8124K RUN/3 25:56 99.02% 99.02% dnetc 10545 john 5 20 8212K 4540K CPU/4 24:45 99.02% 99.02% dnetc 24632 john 5 20 8200K 4544K CPU/5 25:01 94.58% 94.58% dnetc 14493 john 5 20 8216K 4552K RUN/6 24:34 93.65% 93.65% dnetc 10715 john 6 20 8204K 4540K CPU/6 25:21 92.72% 92.72% dnetc 13965 john 5 20 8224K 4540K CPU/0 25:14 89.75% 89.75% dnetc 8117 john 5 20 8220K 2508K CPU/7 25:52 82.03% 82.03% dnetc 28320 john 5 20 8208K 4552K CPU/1 24:20 81.84% 81.84% dnetc For some reason I can't get 100% CPU on all eight cores. This is with netbsd-6 compiled from two days ago on an eight core AMD Zambezi: cpu0 at mainbus0 apid 16: AMD FX(tm)-8150 Eight-Core Processor , id 0x600f12 ... Nothing else is running on the machine. Strange... Ideas? John
