Re: Interrupt time inflation on Xen

2016-04-15 Thread Christoph Badura
On Fri, Apr 15, 2016 at 12:52:36AM -0400, Thor Lancelot Simon wrote:
> It definitely does for me (that same dd, but from /dev/rsd0d, goes to
> 60% "Interrupt" time on pkgbuild).  I can't help noticing everyone who
> doesn't see the problem is using wd, while I see it with ciss or arcmsr.

I didn't mean to sound as if what you're seeing isn't real.  Sorry if I
did.

> I have trouble seeing how the SCSI code itself could be to blame, but I
> wonder if these two drivers have something in common (how they use bus_dma
> perhaps)?

I was wondering about that.  Especially since the wds are on ahcisata and
using DMA too.

> Now that Manuel fixed profiling, I can confirm at least part of your
> suspicion:
> 
> index % timeself  childrencalled name
>  
> [1] 85.7   38.100.00 hypercall_page [1]
> --- 
> 
> This is of course not a terribly useful profiling record since it cannot
> find any other functions in the call graph, so we cannot see which hypercall
> might be to blame.  I *think* the use of static inlines in hypercall.h is
> causing that problem, though I don't understand why the "callers" of those
> inline functions are missing from the call graph.
> 
> Still puzzling about how to work through this further.

Remove the static inlines and see if that lets the callers show up?  But I
guess you thought of that yourself.

--chris


Re: bridge(4): BRIDGE_MPSAFE by default and applying psref(9)

2016-04-15 Thread Christos Zoulas
On Apr 15, 12:02pm, ozak...@netbsd.org (Ryota Ozaki) wrote:
-- Subject: Re: bridge(4): BRIDGE_MPSAFE by default and applying psref(9)

|   +#ifdef NET_MPSAFE
|   +   int s __unused;
|   +#else
|   int s;
|   +#endif
| 
| for each function. Is there another way to deal with the error?
| 

Maybe:

#ifdef NET_MPSAFE
#define DECLARE_LOCK_VARIABLE
#else
#define DECLARE_LOCK_VARIABLE int s
#endif

| Thank you for reviewing!

Thank you.

christos