Re: How to submit patches?
Like the OP I’ve experienced similar issues with X on some of my systems. Earlier versions of NetBSD (and Xorg) worked a bit better on configuring some of my setups. When Xorg was modified to try and reduce the need for an xorg.conf file things really messed up for me, but as Xorg has evolved over the last couple of years it has been getting better in this respect. Although I haven’t looked into the Xorg code, my feeling it is trying to use a combination of decoding the EDID and some set of internal tables. On my systems I’ve seen cases where setups that were in the EDID for my monitor didn’t show up during configuration and some cases where the opposite is true. I also see similar disconnects with what appear to be configurations listed in the x.log files which seem to be coming from internal tables, like the ones the OP is addressing with his modifications. There also seem to be some issues with things like blanking times and video placement on the monitor that I’ve had to adjust with MODELINES in my xorg.conf files that again appear to be addressed in the proposed modifications. Finally, for some reason I usually see fewer problems in getting my monitors configured when using various versions of Linux than I do with NetBSD when running on the same HW. I don’t know if these anomalies are in the Xorg configurations since both seem to use the same versions, or if the anomalies are a result of differences in the lower level drivers. In most cases I’ve been able to work around these by copying some of the MODELINES coming out of Linux and putting them in an xorg.conf file on my NetBSD systems.
Re: How to submit patches?
Le Sun, May 07, 2023 at 06:14:35PM +0200, Martin Husemann a écrit : > On Sun, May 07, 2023 at 04:56:33PM +0200, tlaro...@polynum.com wrote: > > I'm a bit reluctant to put all the platform lists in copy, since this > > is typically generic: it deals with the monitor capacities, updating > > the VESA DMT specs... > > I pointed a few people at your mail, but maybe you could describe the > motivation of the changes a bit more verbosly - at first it all looked > like a lot of churn for no particular reason (but that is probably because > I don't know anything about that part of the source). With NetBSD 10 beta, there was a change in resolution picked-up for the framebuffer compared to 9.3: I have a 16:9 ratio LCD; 9.3 picked-up this ratio and a correct resolution and font for the framebuffer, while 10 beta does not (on the very same hardware). Trying to investigate why this difference, I found nothing obvious. So I started to track back, starting from the end: the monitor. Since I didn't know anything about this stuff, I started to download the published specs by VESA and read the specs. So the first step was to update to the latest VESA DMT and to fix some things that were wrong: there are discrepancies about the Mac monitors "modelines"; some historical modes were missing; Xorg (the source used in NetBSD at least) is not up to date either and was used as a reference for the VESA DMT modes, while with the VESA DMT, de facto and de jure, it should not. Since I can work on that only on very scarce hours, instead of waiting (how long?) to finish all, I prefer to commit a step that is an independant unit by itself and is finished, without breaking anything (it adds modes; it corrects---printing "800x600x60" for a mode is multiplying apples by bananas, since 60 is a frequency so now it appears as "800x600@60Hz" for example; it removes unused things that just complexify things for someone who tries to update the code; etc.) so that at least, _this_, will not have to be done by someone else. Of course, some of the fields added from the VESA DMT would be needed in the future when updating code about EDID. So it is not gratuitous. Next step will be to review the EDID code and I will continue back (praying to not have to deal with drm...) until I find why it doesn't work correctly and understanding the framebuffer stuff. Is this clearer? -- Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C
Re: How to submit patches?
On Sun, May 07, 2023 at 04:56:33PM +0200, tlaro...@polynum.com wrote: > I'm a bit reluctant to put all the platform lists in copy, since this > is typically generic: it deals with the monitor capacities, updating > the VESA DMT specs... I pointed a few people at your mail, but maybe you could describe the motivation of the changes a bit more verbosly - at first it all looked like a lot of churn for no particular reason (but that is probably because I don't know anything about that part of the source). Martin
Re: How to submit patches?
Le Sun, May 07, 2023 at 09:40:56AM -0400, Thor Lancelot Simon a écrit : > On Sat, May 06, 2023 at 12:12:54PM +0200, tlaro...@polynum.com wrote: > > > > How to submit patches without wasting time? (mine included) > > It might be that you get quicker response on one of the mailing lists > for platforms where the patches are particularly useful. It might not, > too - but the set of people with the knowledge to review work in this area > is not so large, and copying the per-port lists might help get their > attention. I'm a bit reluctant to put all the platform lists in copy, since this is typically generic: it deals with the monitor capacities, updating the VESA DMT specs... -- Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C
Re: How to submit patches?
On Sat, May 06, 2023 at 12:12:54PM +0200, tlaro...@polynum.com wrote: > > How to submit patches without wasting time? (mine included) It might be that you get quicker response on one of the mailing lists for platforms where the patches are particularly useful. It might not, too - but the set of people with the knowledge to review work in this area is not so large, and copying the per-port lists might help get their attention. -- Thor Lancelot Simon t...@panix.com "Somehow it works like a joke, but it makes no sense." --Gilbert Gottfried
Re: How to submit patches?
Le Sat, May 06, 2023 at 02:13:58PM +0200, Martin Husemann a écrit : > On Sat, May 06, 2023 at 12:12:54PM +0200, tlaro...@polynum.com wrote: > > Hello, > > > > On Mon, 27 Feb 2023 12:33:32 +0100, I sent to this list a collection of > > patches for sys/dev/videomode/, starting by updating the DMT to the > > latest, and planning to review further the code (sending patches > > when I have achieved a complete step in the course, because I'm having > > a hard time finding some spare hours to work on this). > > > > There has been no comment; no reaction. > > Sorry, this happens sometimes - e.g. when topics are sligthly special > and noone who is familiar with that code has time to review immediately. > > Just ping after some reasonable time of no reaction (I'd say min one max > two weeks or so) by resending the patches. OK, I will resend the patches. Best, -- Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C
Re: How to submit patches?
On Sat, May 06, 2023 at 12:12:54PM +0200, tlaro...@polynum.com wrote: > Hello, > > On Mon, 27 Feb 2023 12:33:32 +0100, I sent to this list a collection of > patches for sys/dev/videomode/, starting by updating the DMT to the > latest, and planning to review further the code (sending patches > when I have achieved a complete step in the course, because I'm having > a hard time finding some spare hours to work on this). > > There has been no comment; no reaction. Sorry, this happens sometimes - e.g. when topics are sligthly special and noone who is familiar with that code has time to review immediately. Just ping after some reasonable time of no reaction (I'd say min one max two weeks or so) by resending the patches. Martin
How to submit patches?
Hello, On Mon, 27 Feb 2023 12:33:32 +0100, I sent to this list a collection of patches for sys/dev/videomode/, starting by updating the DMT to the latest, and planning to review further the code (sending patches when I have achieved a complete step in the course, because I'm having a hard time finding some spare hours to work on this). There has been no comment; no reaction. How to submit patches without wasting time? (mine included) TIA -- Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C
