Re: sys_ptrace_lwpstatus.c (Was: CVS commit: src/sys)

2019-12-27 Thread Kamil Rytarowski
On 26.12.2019 15:11, Valery Ushakov wrote:
> On Thu, Dec 26, 2019 at 08:52:39 +, Kamil Rytarowski wrote:
> 
>> Module Name: src
>> Committed By:kamil
>> Date:Thu Dec 26 08:52:39 UTC 2019
>>
>> Modified Files:
>>  src/sys/kern: files.kern sys_ptrace_common.c
>>  src/sys/sys: ptrace.h
>> Added Files:
>>  src/sys/kern: sys_ptrace_lwpstatus.c
>>
>> Log Message:
>> Put ptrace_read_lwpstatus() and process_read_lwpstatus() to a new file
>>
>> Fixes "no PTRACE" kernel build, in particular zaurus kernel=INSTALL_C700.
> 
> This is counterintuitive when a sys_ptrace* file with ptrace_*
> functions does not depend on options ptrace.  That seems to be a
> strong indication the functions and the file are misnamed.
> 
> filekern/sys_ptrace.c   ptrace
> filekern/sys_ptrace_common.cptrace
> filekern/sys_ptrace_lwpstatus.c kern
> 
> -uwe
> 

I will refactor this.



signature.asc
Description: OpenPGP digital signature


sys_ptrace_lwpstatus.c (Was: CVS commit: src/sys)

2019-12-26 Thread Valery Ushakov
On Thu, Dec 26, 2019 at 08:52:39 +, Kamil Rytarowski wrote:

> Module Name:  src
> Committed By: kamil
> Date: Thu Dec 26 08:52:39 UTC 2019
> 
> Modified Files:
>   src/sys/kern: files.kern sys_ptrace_common.c
>   src/sys/sys: ptrace.h
> Added Files:
>   src/sys/kern: sys_ptrace_lwpstatus.c
> 
> Log Message:
> Put ptrace_read_lwpstatus() and process_read_lwpstatus() to a new file
> 
> Fixes "no PTRACE" kernel build, in particular zaurus kernel=INSTALL_C700.

This is counterintuitive when a sys_ptrace* file with ptrace_*
functions does not depend on options ptrace.  That seems to be a
strong indication the functions and the file are misnamed.

filekern/sys_ptrace.c   ptrace
filekern/sys_ptrace_common.cptrace
filekern/sys_ptrace_lwpstatus.c kern

-uwe