Re: Interaction: firewall-applet's icon & firewalld
On 05.05.2015 17:46, Thomas Woerner wrote: > On 05/04/2015 09:05 PM, poma wrote: >> … >>> Moreover, it is worthwhile to implement them as is "Applet shows >>> notifications" >>> i.e. "notifications", >>> so they can be enabled also in the applet with the checkbox in the right >>> mouse menu. >>> >> >> I've tested it and concluded: >> when the control of appearance of the applet is in the applet itself, >> when the applet is in "none-show-inactive" mode, >> therefore, does not show its icon in the systray, >> dconf mechanism must be used to show it again. >> >> For this reason alone the use of this feature is not homogeneous, >> so I withdraw this part of the proposal. >> > > firewall-applet behaves in absence of the daemon like other applets do > also, for example the NetworkManager applet. If the daemon is not > running the applet is not shown. > Is this really a fact? Or if the nm-applet is installed and set as desktop auto-startup item: /etc/xdg/autostart/nm-applet.desktop and enabled as such, nm-applet "should be" displayed at all times, regardless of whether the NetworkManager is active (running) or not. Literally the same as I proposed for the firewall-applet. For the sake of clarity, I am referring to xfce4-panel's systray, therefore the Xfce, as shown in rhbz 1217797. "should be" - reserve toward GTK+ bugs > To show the applet in this case has pros and also cons. If for example > someone has deactivated firewalld, the applet will be visible all the > time without providing any useful functionality. > > There has been no change in the behavior of the applet since 2 releases. > "useful functionality" is exactly why I propose this - be informative at max. After all, it is about the firewall, right. > I am thinking about an additional check if the firewalld service is > enabled with systemd in this case. > Just do not say that you have adopted the "philosophy" of hiding firewall from users, you know yourself where it comes from. ;) -- test mailing list test@lists.fedoraproject.org To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
Re: Interaction: firewall-applet's icon & firewalld
On 05/04/2015 09:05 PM, poma wrote: … Moreover, it is worthwhile to implement them as is "Applet shows notifications" i.e. "notifications", so they can be enabled also in the applet with the checkbox in the right mouse menu. I've tested it and concluded: when the control of appearance of the applet is in the applet itself, when the applet is in "none-show-inactive" mode, therefore, does not show its icon in the systray, dconf mechanism must be used to show it again. For this reason alone the use of this feature is not homogeneous, so I withdraw this part of the proposal. firewall-applet behaves in absence of the daemon like other applets do also, for example the NetworkManager applet. If the daemon is not running the applet is not shown. To show the applet in this case has pros and also cons. If for example someone has deactivated firewalld, the applet will be visible all the time without providing any useful functionality. There has been no change in the behavior of the applet since 2 releases. I am thinking about an additional check if the firewalld service is enabled with systemd in this case. -- test mailing list test@lists.fedoraproject.org To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
Re: Interaction: firewall-applet's icon & firewalld
… > Moreover, it is worthwhile to implement them as is "Applet shows > notifications" > i.e. "notifications", > so they can be enabled also in the applet with the checkbox in the right > mouse menu. > I've tested it and concluded: when the control of appearance of the applet is in the applet itself, when the applet is in "none-show-inactive" mode, therefore, does not show its icon in the systray, dconf mechanism must be used to show it again. For this reason alone the use of this feature is not homogeneous, so I withdraw this part of the proposal. -- test mailing list test@lists.fedoraproject.org To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
Re: Interaction: firewall-applet's icon & firewalld
"firewall-applet icon does not appear - firewalld inactive" https://bugzilla.redhat.com/show_bug.cgi?id=1217797 -- test mailing list test@lists.fedoraproject.org To unsubscribe: https://admin.fedoraproject.org/mailman/listinfo/test
Re: Interaction: firewall-applet's icon & firewalld
On 03.05.2015 09:56, poma wrote:
>
> In Fedora 22 and Rawhide, when the firewalld.service stops i.e. is not
> running, firewall-applet's icon in systray just disappears i.e. it does not
> appear.
> This feature or bug is rather confusing - this way you do not know whether
> the icon broken, or what.
>
>
> In Fedora 21, when the firewalld.service is not running, there is a status
> tooltip,
> as part of firewall-applet's icon in systray:
> https://github.com/t-woerner/firewalld/blob/master/src/firewall-applet#L949
> _("No connection to firewall daemon") + ""
>
> with initially "flashing" icon,
> https://github.com/t-woerner/firewalld/blob/master/src/icons/32x32/apps/firewall-applet-error.png
>
> This way how it works in Fedora 21 is how it should be.
>
Correction of inaccurate statement
man 1 firewall-applet
GSETTINGS
firewall-applet has additional settings to adapt the look and feel. The
used backend depends on the distribution and can be either dconf or
GConf. The path to the settings is org.fedoraproject.FirewallApplet.
You can use dconf-editor or gconf-editor to see and modify them.
The following settings are supported:
...
show-inactive
Show applet also if firewalld is not running. If firewalld has been
stopped or is not running the applet will be hidden and not visible
in the applet tray. Enable this setting to see the applet all the
time for example to be sure that the firewall is active.
This setting defaults to false.
...
blink
If enabled, the applet icon blinks in these cases:
· Connection to firewalld lost
· Panic mode has been enabled or disabled
This setting defaults to false.
...
~~~
rpm -ql firewall-applet | grep org.fedoraproject.FirewallApplet.gschema.xml
/usr/share/glib-2.0/schemas/org.fedoraproject.FirewallApplet.gschema.xml
~~~
/usr/share/glib-2.0/schemas/org.fedoraproject.FirewallApplet.gschema.xml:
...
...
false
Applet icon blinks if true blink-count times
...
false
Show applet also if firewalld is not running
~
dconf dump /org/fedoraproject/FirewallApplet/
dconf write /org/fedoraproject/FirewallApplet/show-inactive true
dconf write /org/fedoraproject/FirewallApplet/blink true
dconf dump /org/fedoraproject/FirewallApplet/
[/]
show-inactive=true
blink=true
~~~
Let it be "true", these two settings exposed via GSettings:
"Show applet also if firewalld is not running" i.e. "show-inactive"
&
"Applet icon blinks" i.e. "blink"
In this way, it is more clear what is happening.
Moreover, it is worthwhile to implement them as is "Applet shows notifications"
i.e. "notifications",
so they can be enabled also in the applet with the checkbox in the right mouse
menu.
---
config/org.fedoraproject.FirewallApplet.gschema.xml.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/org.fedoraproject.FirewallApplet.gschema.xml.in
b/config/org.fedoraproject.FirewallApplet.gschema.xml.in
index fadf0ca..9695160 100644
--- a/config/org.fedoraproject.FirewallApplet.gschema.xml.in
+++ b/config/org.fedoraproject.FirewallApplet.gschema.xml.in
@@ -14,7 +14,7 @@
Shields-down zone
- false
+ true
Applet icon blinks if true blink-count times
@@ -22,7 +22,7 @@
Applet icon blink count
- false
+ true
Show applet also if firewalld is not running
--
2.1.0
--
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test
Interaction: firewall-applet's icon & firewalld
In Fedora 22 and Rawhide, when the firewalld.service stops i.e. is not running,
firewall-applet's icon in systray just disappears i.e. it does not appear.
This feature or bug is rather confusing - this way you do not know whether the
icon broken, or what.
In Fedora 21, when the firewalld.service is not running, there is a status
tooltip,
as part of firewall-applet's icon in systray:
https://github.com/t-woerner/firewalld/blob/master/src/firewall-applet#L949
_("No connection to firewall daemon") + ""
with initially "flashing" icon,
https://github.com/t-woerner/firewalld/blob/master/src/icons/32x32/apps/firewall-applet-error.png
This way how it works in Fedora 21 is how it should be.
--
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test
