Re: New criterion for Checksum

2012-02-20 Thread Petr Schindler
On Mon, 2012-02-13 at 14:23 +0100, Petr Schindler wrote:
> If you have some objection on this one, please, let me know till
> tomorrow, otherwise if there are no suggestions I'll make changes. 

I've made changes. I've added new alpha and final release criterion to
[1] [2]. And I've changed release level of test checksum testcases to
Alpha/Final in [3]

[1] https://fedoraproject.org/wiki/Fedora_17_Alpha_Release_Criteria
[2] https://fedoraproject.org/wiki/Fedora_17_Final_Release_Criteria
[3] https://fedoraproject.org/wiki/QA:Fedora_17_Install_Results_Template

-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-02-13 Thread Petr Schindler
If you have some objection on this one, please, let me know till
tomorrow, otherwise if there are no suggestions I'll make changes.

On Wed, 2012-02-01 at 11:40 +0100, Petr Schindler wrote:
> On Tue, 2012-01-31 at 10:23 -0800, Adam Williamson wrote:
> > On Tue, 2012-01-31 at 07:48 -0500, Petr Schindler wrote:
> > 
> > > OK, so test case should stay in alpha and new criterion should be in
> > > alpha too. I propose to drop the part about embedded checksum (that
> > > would be only additional check) and new criterion should be:
> > > 
> > > "A correct checksum must be published for each official release
> > > image."
> > > 
> > > The second possibility is to have two criteria, first in alpha and
> > > second in beta. In beta, there would be included embedded checksum.
> > > 
> > > I think that first option is better.
> > 
> > Well, I think we probably want to ensure the embedded checksum is
> > correct at final - it would look silly to ship a release where the
> > built-in media check always fails, after all. So I think we may want to
> > have that second criterion at least for final.
> 
> You are right. So beside this alpha criterion I propose new final
> criterion:
> 
> "If there is embedded checksum on ISO media, it must be correct."
> 
> Test case [1] should be mark as Alpha/Final release level.
> 
> [1] https://fedoraproject.org/wiki/QA:Testcase_Mediakit_ISO_Checksums
> 
> > BTW, Petr, can you set your mail client to wrap at 72 characters, as is
> > conventional? Thanks!
> 
> I'm sorry. I thought that Zimbra makes this implicitly, my fault. I
> moved to the Evolution and it seems to work well.
> 
> 
> 


-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-02-01 Thread Patrick O'Callaghan
On Wed, 2012-02-01 at 16:33 +, Andre Robatino wrote:
> Frank Murphy  gmail.com> writes:
> 
> > > A built-in checksum is only useful for checking for natural corruption, 
> > > not a
> > > deliberate fake (since in that case it's easy to change the checksum to 
> > > the
> > > correct one for the fake). Even md5 is more than enough for this purpose.
> > >
> > 
> > So it's not error proof,
> > it can fail and still have a perfect disk, correct.
> 
> Yes, there can be a bug that causes the mediacheck to fail even though the 
> disc
> is good (this actually happened recently during development). Conversely, it 
> can
> pass even if the disc is fake.

mediacheck failing when the disk is good is a bug. mediacheck passing
when the disk is bad may or may not be a bug, due to how checksums work.
It's always possible (though *very* unlikely) to get bad data that gives
a good checksum. This is not a failing of MD5 but of all checksum
schemes.

poc


-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-02-01 Thread Frank Murphy

On 01/02/12 16:11, Andre Robatino wrote:



A built-in checksum is only useful for checking for natural corruption, not a
deliberate fake (since in that case it's easy to change the checksum to the
correct one for the fake). Even md5 is more than enough for this purpose.



So it's not error proof,
it can fail and still have a perfect disk, correct.


--
Regards,

Frank Murphy, friend of fedoraproject
UTF_8 Encoded
--
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-02-01 Thread Frank Murphy

On 01/02/12 10:40, Petr Schindler wrote:


You are right. So beside this alpha criterion I propose new final
criterion:

"If there is embedded checksum on ISO media, it must be correct."



Not  trying to hijack.
But, is there a reason md5 is still being used?



--
Regards,

Frank Murphy, friend of fedoraproject
UTF_8 Encoded
--
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-02-01 Thread Petr Schindler
On Tue, 2012-01-31 at 10:23 -0800, Adam Williamson wrote:
> On Tue, 2012-01-31 at 07:48 -0500, Petr Schindler wrote:
> 
> > OK, so test case should stay in alpha and new criterion should be in
> > alpha too. I propose to drop the part about embedded checksum (that
> > would be only additional check) and new criterion should be:
> > 
> > "A correct checksum must be published for each official release
> > image."
> > 
> > The second possibility is to have two criteria, first in alpha and
> > second in beta. In beta, there would be included embedded checksum.
> > 
> > I think that first option is better.
> 
> Well, I think we probably want to ensure the embedded checksum is
> correct at final - it would look silly to ship a release where the
> built-in media check always fails, after all. So I think we may want to
> have that second criterion at least for final.

You are right. So beside this alpha criterion I propose new final
criterion:

"If there is embedded checksum on ISO media, it must be correct."

Test case [1] should be mark as Alpha/Final release level.

[1] https://fedoraproject.org/wiki/QA:Testcase_Mediakit_ISO_Checksums

> BTW, Petr, can you set your mail client to wrap at 72 characters, as is
> conventional? Thanks!

I'm sorry. I thought that Zimbra makes this implicitly, my fault. I
moved to the Evolution and it seems to work well.



-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-01-31 Thread Adam Williamson
On Tue, 2012-01-31 at 07:48 -0500, Petr Schindler wrote:

> OK, so test case should stay in alpha and new criterion should be in
> alpha too. I propose to drop the part about embedded checksum (that
> would be only additional check) and new criterion should be:
> 
> "A correct checksum must be published for each official release
> image."
> 
> The second possibility is to have two criteria, first in alpha and
> second in beta. In beta, there would be included embedded checksum.
> 
> I think that first option is better.

Well, I think we probably want to ensure the embedded checksum is
correct at final - it would look silly to ship a release where the
built-in media check always fails, after all. So I think we may want to
have that second criterion at least for final.

BTW, Petr, can you set your mail client to wrap at 72 characters, as is
conventional? Thanks!
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net

-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-01-31 Thread Petr Schindler
> From: "Adam Williamson" 
> To: "For testing and quality assurance of Fedora releases" 
> 
> Sent: Tuesday, January 31, 2012 1:51:16 AM
> Subject: Re: New criterion for Checksum
> 
> On Mon, 2012-01-30 at 18:02 +, Andre Robatino wrote:
> > Petr Schindler  redhat.com> writes:
> > 
> > > I propose new final criterion:
> > > 
> > > "There must be published correct checksum for each ISO media.
> > > Also if there is
> > embedded checksum on ISO
> > > media, it must be correct."
> > > 
> > > I think we should check this. We have already test case [1]. I
> > > propose to
> > change release level for this test
> > > case to final.
> > > 
> > > [1]
> > > https://fedoraproject.org/wiki/QA:Testcase_Mediakit_ISO_Checksums
> > 
> > I think that having a published correct checksum for each ISO
> > should be Alpha
> > level. If the ISO can't be verified, then the results of any other
> > testing on it
> > are suspect. Also, publishing the correct checksums can be done
> > without altering
> > the ISOs themselves, so it's easy to ensure that this test passes.
> > Getting the
> > embedded checksum correct is less important since an independent
> > check is
> > possible.
> 
> Yeah, I did think that too. It seems like the kind of thing that
> should
> always be correct.

OK, so test case should stay in alpha and new criterion should be in alpha too. 
I propose to drop the part about embedded checksum (that would be only 
additional check) and new criterion should be:

"A correct checksum must be published for each official release image."

The second possibility is to have two criteria, first in alpha and second in 
beta. In beta, there would be included embedded checksum.

I think that first option is better.
-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-01-30 Thread Adam Williamson
On Mon, 2012-01-30 at 18:02 +, Andre Robatino wrote:
> Petr Schindler  redhat.com> writes:
> 
> > I propose new final criterion: 
> > 
> > "There must be published correct checksum for each ISO media. Also if there 
> > is
> embedded checksum on ISO
> > media, it must be correct."  
> > 
> > I think we should check this. We have already test case [1]. I propose to
> change release level for this test
> > case to final.
> > 
> > [1] https://fedoraproject.org/wiki/QA:Testcase_Mediakit_ISO_Checksums
> 
> I think that having a published correct checksum for each ISO should be Alpha
> level. If the ISO can't be verified, then the results of any other testing on 
> it
> are suspect. Also, publishing the correct checksums can be done without 
> altering
> the ISOs themselves, so it's easy to ensure that this test passes. Getting the
> embedded checksum correct is less important since an independent check is
> possible.

Yeah, I did think that too. It seems like the kind of thing that should
always be correct.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net

-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test

Re: New criterion for Checksum

2012-01-30 Thread Adam Williamson
On Mon, 2012-01-30 at 11:23 -0500, Petr Schindler wrote:
> I propose new final criterion: 
> 
> "There must be published correct checksum for each ISO media. Also if
> there is embedded checksum on ISO media, it must be correct."

Small grammar fixes:

"A correct checksum published for each official release image. In the
case of any release image(s) which have embedded checksums, these
checksums must be correct."

> I think we should check this. We have already test case [1]. I propose
> to change release level for this test case to final.
> 
> [1] https://fedoraproject.org/wiki/QA:Testcase_Mediakit_ISO_Checksums

That sounds okay.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora
http://www.happyassassin.net

-- 
test mailing list
test@lists.fedoraproject.org
To unsubscribe:
https://admin.fedoraproject.org/mailman/listinfo/test