failure notice

2001-08-08 Thread Paul Edgar

Guys,

I am in the IBM Linux Technology Center.  At IBM we are participating in
testing enterprise aspects of linux and I am attempting to use apache 2.0
as part of this effort.  Eventually we will be developing some tests that
the open source community may be interested in.However, before
starting,
we want to test with your tests to get some base numbers so that we will
know if our tests perform adequately.

Thanks in advance for your response.

Now on to the problem I am having...


I am experiencing a problem with running the apache perl tests I
downloaded on 08/03/01.  I think I have everthing setup correctly be am
getting an error (file not found) in TestRequest.pm line 183.

I am sure it is something simple (or stupid on my part).  I have
included the information and appreciate any help you can provide.

Also, is there a mail group that I can subscribe to for apache testing?

using Apache/2.0.18 (threaded MPM)
waiting for server to warm up...ok
server localhost:8529 started (pid=2378)
modules/expires.Undefined subroutine &HTTP::Request::Common::HEAD
called at ../Apache-Test/lib/Apache/TestRequest.pm line 183.
modules/expires.dubious
Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 1-8
Failed 8/8 tests, 0.00% okay
modules/include.Undefined subroutine &HTTP::Request::Common::GET
called at ../Apache-Test/lib/Apache/TestRequest.pm line 183.
modules/include.dubious
Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 1-15
Failed 15/15 tests, 0.00% okay
modules/negotiation.


Thanks,

Paul Edgar
Verification Engineer
Linux Technology Center / IBM
External 512.838.1493 / TieLine 678-1493
[EMAIL PROTECTED]
http://sourceforge.net/projects/ltp/










Re: plan tests $n, test_module 'php4'

2001-08-08 Thread john sachs
killer..thanks!

On Wed, Aug 08, 2001 at 10:22:17AM -0700, Doug MacEachern wrote:
+ i added some sugar so we can get rid of ExtModules::TestEnv, instead of:
+ 
+ plan tests => 1, \&ExtModules::TestEnv::has_php4;
+ 
+ you can now say:
+  plan tests $n, test_module 'php4'
+ 
+ or
+ 
+  plan tests $n, [qw(php4 rewrite)]
+ 
+ etc.
+ 
+ 


plan tests $n, test_module 'php4'

2001-08-08 Thread Doug MacEachern
i added some sugar so we can get rid of ExtModules::TestEnv, instead of:

plan tests => 1, \&ExtModules::TestEnv::has_php4;

you can now say:
 plan tests $n, test_module 'php4'

or

 plan tests $n, [qw(php4 rewrite)]

etc.




Re: t/modules/rewrite tweaking

2001-08-08 Thread john sachs
On Wed, Aug 08, 2001 at 10:28:24AM +0800, Stas Bekman wrote:
+
+ OK, so why not to do: /^[1-6]$/ ?

this wouldnt test for the right thing.

+ 
+ I'd do it even more flexible:
+ 
+ my $pat = join '', @num;
+ /^[$pat]$/
+ 
+ so now you can change @num and not to worry about forgetting adjusting the
+ code.

this, however, is a good idea...i think i will use this.

+ 
+ > as a side note, i think you're getting this error because your
+ > particular build of apache does not contain mod_rewrite.  very soon,
+ > the test will tell you its not going to run on your platform...heh.
+ > i plan to talk to doug about this today.
+ 
+ Well, I did enable rewrite, see my original post. But I was running httpd
+ 2.0, so may be it's not the same.

yeah i missed that you did build it in there, sorry bout that.  i had the same 
problems with --enable-rewite=shared.  i build static and some of the tests 
passed.  it wouldnt let me start up with the current config because it said i 
didnt have NDBM support, but doug tells me thats because mod_rewrite.c is 
trying to execute some non-existant script...so thats a bug...probably just a 
packaging issue.

+ 
+ In any case, your code was good, but it'd didn't do initializations in
+ every place it should and didn't check for whether variables are defined
+ before using them. Something that's not acceptible with warnings mode that
+ you use. You didn't see any problems because the test has been completely
+ working for you, but if something goes wrong (which is what the test is
+ designed for) it was immediately dying without proceeding, on the first
+ warning, because warnings are fatal.
+ 
+ Please consider using parts of my patch, at least those parts where I've
+ added various initializations and checks. I guess you should try to
+ compile httpd with no mod_rewrite and see how it fails. Which can be a
+ case if it doesn't work properly.

i dont know where the missing initializations are that you are talking about...
perhaps we are talking about another patch that im not seeing at the moment.
here is what i have (minus indentation fixes):

Index: t/modules/rewrite.t
===
RCS file: /home/cvs/httpd-test/perl-framework/t/modules/rewrite.t,v
retrieving revision 1.1
diff -u -r1.1 rewrite.t
--- t/modules/rewrite.t 2001/08/02 16:38:19 1.1
+++ t/modules/rewrite.t 2001/08/07 05:54:43
@@ -25,7 +25,7 @@
chomp $r;

if ($_ eq 'RND') {
-   ok ($r =~ /^[$r-6]$/);
+   ok ($r =~ /^[$r\-6]$/);
} else {
ok ($r eq $n);
}


so i dont see the initializations you are talking about.  but if i am missing 
initializations somewhere, i certainly want to know about it.  i checked in a 
small sanity check on $r yesterday, have you seen that?

also, i realize that this rewrite test is very minimal compared to the 
functionality of mod_rewrite.  i kinda quit working on it in the middle of it 
because 1) i could spend the rest of eternity writing testcases for every 
possibility in mod_rewrite  and 2) i wanted to get some work done on writing 
test for other modules.  so, this test may not be very refined because when i 
finally came to this conclusion, i just checked in what i had at the moment 
just so it wouldnt be lost...

+ 
+ Also it'd be nice that we all follow the same ident style, which is 4
+ spaces (no tabs!) in the Perl code. thanks :)

doh!  sorry!  didnt know... i will do this from now on.  will gradually fix the 
ones in the repository...

+ 
+ _
+ Stas Bekman  JAm_pH --   Just Another mod_perl Hacker
+ http://stason.org/   mod_perl Guide  http://perl.apache.org/guide
+ mailto:[EMAIL PROTECTED]   http://apachetoday.com http://eXtropia.com/
+ http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
+ 
+ 

-j



Re: cvs commit: httpd-test LICENSE

2001-08-08 Thread Justin Erenkrantz
On Wed, Aug 08, 2001 at 04:11:02PM -, [EMAIL PROTECTED] wrote:
>* Portions of this software are based upon public domain software
>* originally written at the National Center for Supercomputing 
> Applications,
>* University of Illinois, Urbana-Champaign.
>*/

This clause is probably not necessary for httpd-test.

Roy could/would correct me if I'm wrong.  -- justin



Re: License status

2001-08-08 Thread Gary Benson

On Wed, 8 Aug 2001, Doug MacEachern wrote:

> On Wed, 8 Aug 2001, Gary Benson wrote:
>
> >
> > What license are these tests released under? I'm presuming they are under
> > the ASL...
>
> yes, i've added a copy of the LICENSE to the top-level directory.

Just spotted it. Thanks for merging my patch as well...



Re: License status

2001-08-08 Thread Doug MacEachern
On Wed, 8 Aug 2001, Gary Benson wrote:

> 
> What license are these tests released under? I'm presuming they are under
> the ASL...

yes, i've added a copy of the LICENSE to the top-level directory.



License status

2001-08-08 Thread Gary Benson

What license are these tests released under? I'm presuming they are under
the ASL...




Improvement to httpd version detection

2001-08-08 Thread Gary Benson

Hi all,

The code that parses "httpd -v" fails when the first item in the server
version line is not "Apache/x.y.z". This affects Stronghold (which reports
itself as "Stronghold/n.m Apache/x.y.z (Unix)") and possible other things
as well.

Anyway, here is a patch to fix it. It looks for the "Apache/" in the
server version string and returns that. If this isn't found then it
reverts to the previous behaviour and returns the first element of server
version.

Hope it's suitable,
Gary

[ Gary Benson, Red Hat Europe ][ [EMAIL PROTECTED] ][ GnuPG 60E8793A ]


Index: perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm
===
RCS file:
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm,v
retrieving revision 1.4
diff -u -r1.4 TestConfigParse.pm
--- perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm2001/05/08
05:17:241.4
+++ perl-framework/Apache-Test/lib/Apache/TestConfigParse.pm2001/08/08
12:38:55
@@ -226,7 +226,13 @@
 while (<$v>) {
 next unless s/^Server\s+version:\s*//i;
 chomp;
-$version = (split)[0];
+my @parts = split;
+foreach (@parts) {
+next unless /^Apache\//;
+$version = $_;
+last;
+}
+$version or $version = $parts[0];
 last;
 }



Re: cvs commit emails?

2001-08-08 Thread Stas Bekman
On Tue, 7 Aug 2001, Roy T. Fielding wrote:

> On Tue, Aug 07, 2001 at 08:30:18PM -0700, Justin Erenkrantz wrote:
> > On Wed, Aug 08, 2001 at 10:30:10AM +0800, Stas Bekman wrote:
> > > How do I get to see cvs commits for test-dev?
> >
> > [EMAIL PROTECTED]  -- justin
>
> That will work, but the list is really at [EMAIL PROTECTED]

thanks!


_
Stas Bekman  JAm_pH --   Just Another mod_perl Hacker
http://stason.org/   mod_perl Guide  http://perl.apache.org/guide
mailto:[EMAIL PROTECTED]   http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/




Re: cvs commit emails?

2001-08-08 Thread Roy T. Fielding
On Tue, Aug 07, 2001 at 08:30:18PM -0700, Justin Erenkrantz wrote:
> On Wed, Aug 08, 2001 at 10:30:10AM +0800, Stas Bekman wrote:
> > How do I get to see cvs commits for test-dev?
> 
> [EMAIL PROTECTED]  -- justin

That will work, but the list is really at [EMAIL PROTECTED]

Roy



Re: cvs commit emails?

2001-08-08 Thread Justin Erenkrantz
On Wed, Aug 08, 2001 at 10:30:10AM +0800, Stas Bekman wrote:
> How do I get to see cvs commits for test-dev?

[EMAIL PROTECTED]  -- justin



cvs commit emails?

2001-08-08 Thread Stas Bekman
How do I get to see cvs commits for test-dev?

_
Stas Bekman  JAm_pH --   Just Another mod_perl Hacker
http://stason.org/   mod_perl Guide  http://perl.apache.org/guide
mailto:[EMAIL PROTECTED]   http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/




Re: t/modules/rewrite tweaking

2001-08-08 Thread Stas Bekman
On Tue, 7 Aug 2001, john sachs wrote:

> hi,

> first let me explain the test a little. in this section of code, i am
> testing the 'rnd' rewriting functionality which takes a text file like
> this:
>
> 1 one|two|three|four|five|six
> 2 two|three|four|five|six
>
> and rewrites the key randomly to one of the possibilities you've given
> it.  in the test, the expected outcome is something between the number
> you're requesting and 6 which is max.  therefore the code:
>
> ok ($r =~ /^[$r-6]$/);
>
> the problem is i didnt take into account the condition you've run into
> where $r is a chunk of text with special characters in it.  i will
> have to somehow check for this case before i go blindly dumping it
> into the regexp.

OK, so why not to do: /^[1-6]$/ ?

I'd do it even more flexible:

my $pat = join '', @num;
/^[$pat]$/

so now you can change @num and not to worry about forgetting adjusting the
code.

> as a side note, i think you're getting this error because your
> particular build of apache does not contain mod_rewrite.  very soon,
> the test will tell you its not going to run on your platform...heh.
> i plan to talk to doug about this today.

Well, I did enable rewrite, see my original post. But I was running httpd
2.0, so may be it's not the same.

In any case, your code was good, but it'd didn't do initializations in
every place it should and didn't check for whether variables are defined
before using them. Something that's not acceptible with warnings mode that
you use. You didn't see any problems because the test has been completely
working for you, but if something goes wrong (which is what the test is
designed for) it was immediately dying without proceeding, on the first
warning, because warnings are fatal.

Please consider using parts of my patch, at least those parts where I've
added various initializations and checks. I guess you should try to
compile httpd with no mod_rewrite and see how it fails. Which can be a
case if it doesn't work properly.

Also it'd be nice that we all follow the same ident style, which is 4
spaces (no tabs!) in the Perl code. thanks :)

_
Stas Bekman  JAm_pH --   Just Another mod_perl Hacker
http://stason.org/   mod_perl Guide  http://perl.apache.org/guide
mailto:[EMAIL PROTECTED]   http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/