Re: SVN release methodology : svn copy

2004-12-13 Thread Geoffrey Young

 svn copy https://svn.apache.org/.../trunk \
 https://svn.apache.org/.../tags/1.17

 (optionally with an -r to peg at specific revision, I guess)
 
 
 Yes, that's probably what we will have to end up doing in the future.

if you can find the time, can you please make sure the RELEASE file is up to
date so that the next person to release Apache-Test has no trouble doing the
right thing?  thanks :)

--Geoff


Apache-Test/Makefile.PL r105822

2004-12-13 Thread Stas Bekman
Geoff,
This change:
http://svn.apache.org/viewcvs.cgi/httpd/test/trunk/perl-framework/Apache-Test/Makefile.PL?rev=105822r1=105299r2=105822diff_format=h
adding:
 if ($ExtUtils::MakeMaker::VERSION  6.06) {
 # now that we're using subversion, make sure that
 # .svn directories are skipped during the build process
 # for old versions of MakeMaker

 sub MY::libscan {
 my $self = shift;

 my $path = shift;

 return '' if $path =~ /\B\.svn\b/;

 return $path;
 }
 }
doesn't seem to be right. sub is a compile time directive, so putting it 
in a conditional doesn't prevent from it being compiled:

% perl -le 'if ($_ == 1) { sub a { print a } }; a()'
a
Moreover it now introduces a warning in mp2 build
Subroutine MY::libscan redefined at ./Makefile.PL line 148.
so we need to do the usual ugly workaround for MM :(
Can you fix those? I can do it if you don't have the time.
--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Re: Apache-Test/Makefile.PL r105822

2004-12-13 Thread Geoffrey Young

 doesn't seem to be right. sub is a compile time directive, so putting it
 in a conditional doesn't prevent from it being compiled:

indeed.  guess I wasn't thinking, which seems to be happening lots lately.

 Moreover it now introduces a warning in mp2 build
 Subroutine MY::libscan redefined at ./Makefile.PL line 148.

ugh.

 
 so we need to do the usual ugly workaround for MM :(

usual?

 
 Can you fix those? I can do it if you don't have the time.

well, I don't really have the time, but since it's my problem I'll take care
of it.  that is, if you can tell me exactly what needs to be done - I would
probably just put the if logic inside the sub, but I suspect there needs to
be more than that for mod_perl's sake?

--Geoff


Re: Apache-Test/Makefile.PL r105822

2004-12-13 Thread Stas Bekman
Geoffrey Young wrote:
doesn't seem to be right. sub is a compile time directive, so putting it
in a conditional doesn't prevent from it being compiled:

indeed.  guess I wasn't thinking, which seems to be happening lots lately.
No worries :) There is a way too many things to think about.
Moreover it now introduces a warning in mp2 build
Subroutine MY::libscan redefined at ./Makefile.PL line 148.

ugh.

so we need to do the usual ugly workaround for MM :(

usual?
I mean usual MM namespace workarounds, not specific to A-T :(
Can you fix those? I can do it if you don't have the time.

well, I don't really have the time, but since it's my problem I'll take care
of it.  that is, if you can tell me exactly what needs to be done - I would
probably just put the if logic inside the sub, but I suspect there needs to
be more than that for mod_perl's sake?
to make the sub definition runtime, you just use:
  *MY::foo = sub ...;
but unrelated we need to workaround with colliding identical function in mp2.
I'll take care of it.
--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com