Cookie Patch for Flood

2002-01-03 Thread Chris Williams 
I found a bug in flood_round_robin.c.  The apr_pstrcat on line 146 should
have NULL as the last argument.  I am new to submitting patches so if
someone could let me know the correct way to do it, I will repost.  Without
this, you get a bunch of garbage in the cookie string if there is more that
one cookie.

Thanks
Chris

Re: Cookie Patch for Flood

2002-01-03 Thread Aaron Bannert 
On Thu, Jan 03, 2002 at 09:43:48AM -0500, Chris Williams wrote:
 I found a bug in flood_round_robin.c.  The apr_pstrcat on line 146 should
 have NULL as the last argument.  I am new to submitting patches so if
 someone could let me know the correct way to do it, I will repost.  Without
 this, you get a bunch of garbage in the cookie string if there is more that
 one cookie.

Thanks for the find! Typically patches are posted as context diffs. If
you can manage it with your mail, it's best to attach the patches inline
(as opposed to a mime/uuencoded attachment).

There's some good info on this site for developers: http://dev.apache.org/
You'll be particular interested in: http://dev.apache.org/patches.html

So is this what you meant?


Index: flood_round_robin.c
===
RCS file: /home/cvs/httpd-test/flood/flood_round_robin.c,v
retrieving revision 1.19
diff -u -u -r1.19 flood_round_robin.c
--- flood_round_robin.c 3 Oct 2001 01:24:01 -   1.19
+++ flood_round_robin.c 3 Jan 2002 14:55:43 -
@@ -143,7 +143,7 @@
 while (cook)
 {
 if (cook != p-cookie)
-cookies = apr_pstrcat(p-pool, cookies, ;);
+cookies = apr_pstrcat(p-pool, cookies, ;, NULL);
 
 cookies = apr_pstrcat(p-pool, cookies, cook-name, =, 
   cook-value, NULL);

RE: Cookie Patch for Flood

2002-01-03 Thread Chris Williams 
Yes it is.  I will review those links for the next time.
Thanks!
Chris

 -Original Message-
 From: Aaron Bannert [mailto:[EMAIL PROTECTED]
 Sent: Thursday, January 03, 2002 9:56 AM
 To: [EMAIL PROTECTED]
 Subject: Re: Cookie Patch for Flood


 On Thu, Jan 03, 2002 at 09:43:48AM -0500, Chris Williams wrote:
  I found a bug in flood_round_robin.c.  The apr_pstrcat on line
 146 should
  have NULL as the last argument.  I am new to submitting patches so if
  someone could let me know the correct way to do it, I will
 repost.  Without
  this, you get a bunch of garbage in the cookie string if there
 is more that
  one cookie.

 Thanks for the find! Typically patches are posted as context diffs. If
 you can manage it with your mail, it's best to attach the patches inline
 (as opposed to a mime/uuencoded attachment).

 There's some good info on this site for developers: http://dev.apache.org/
 You'll be particular interested in: http://dev.apache.org/patches.html

 So is this what you meant?


 Index: flood_round_robin.c
 ===
 RCS file: /home/cvs/httpd-test/flood/flood_round_robin.c,v
 retrieving revision 1.19
 diff -u -u -r1.19 flood_round_robin.c
 --- flood_round_robin.c   3 Oct 2001 01:24:01 -   1.19
 +++ flood_round_robin.c   3 Jan 2002 14:55:43 -
 @@ -143,7 +143,7 @@
  while (cook)
  {
  if (cook != p-cookie)
 -cookies = apr_pstrcat(p-pool, cookies, ;);
 +cookies = apr_pstrcat(p-pool, cookies, ;, NULL);

  cookies = apr_pstrcat(p-pool, cookies, cook-name, =,
cook-value, NULL);

Re: Cookie Patch for Flood

2002-01-03 Thread Justin Erenkrantz 
On Thu, Jan 03, 2002 at 06:56:16AM -0800, Aaron Bannert wrote:
 There's some good info on this site for developers: http://dev.apache.org/
 You'll be particular interested in: http://dev.apache.org/patches.html

FWIW, please point people at:

http://www.apache.org/dev/
http://httpd.apache.org/dev/

More specifically:

http://httpd.apache.org/dev/patches.html

Joshua made a commit to change dev.apache.org, but he never updated it.
The front page for dev.apache.org now says it is obsolete.  I wish
that site would just die.  -- justin