[Therion] Bug#751471: Therion hanging after compile
> I am sorry, I was never able replicate this bug. It occurs with most of my large projects and never with small ones. > If it is this regex that causes problems, it can be removed completely. It is used to enable clicking on error source and opening in in appropriate editor. Feature almost never used. I don't use the feature much at all, but I expect that is because I am quite familiar with Therion and usually have the culprit files open in a text editor already. When I was a new user and had not figured out how to make use of external editors with Therion, I used the feature all the time. I think it is worth fixing the bug, especially if Olly is on the right track. Bruce -- next part -- An HTML attachment was scrubbed... URL: <http://mailman.speleo.sk/pipermail/therion/attachments/20150113/ad86284c/attachment.html>
[Therion] Therion wx3 support tweaks
Patch attached to fix some lingering issues.
One is that wxGLCanvas::OnSize() is deprecated in 3.0 - the portable
(between platforms and wx versions) way to achieve this is to call
event.Skip(); which will cause the event to be propagated to the base
class. AIUI, the only platform this matters on is OS X, which I can't
test on - it would be useful to confirm that resizing the window still
works on OS X.
The other was in my original patch, but got lost when it was applied.
As a result wx3 gives an "assertion failed" if loch fails to load a
file. The issue here is that the wxWindowDisabler needs to be off
before the messagebox gets shown, which I had carefully arranged by
reordering code and adding an extra { } block around just the section
which needs protecting. I've added a comment this time, to document the
reason for the extra { } block.
Cheers,
Olly
-- next part --
A non-text attachment was scrubbed...
Name: wx3.0-leftovers.patch
Type: text/x-diff
Size: 1958 bytes
Desc: not available
URL:
<http://mailman.speleo.sk/pipermail/therion/attachments/20150113/2e0654e6/attachment.patch>
[Therion] Bug#751471: Bug#751471: Therion hanging after compile
On Tue, Jan 13, 2015 at 12:01:51AM +, Olly Betts wrote:
> On Mon, Jan 12, 2015 at 04:29:09PM +0100, Stacho Mudrak wrote:
> > I am sorry, I was never able replicate this bug.
>
> You need a large log file for it to be noticeable, as the problem seems
> to be that trying to match this pattern causes Tcl's regexp engine to do
> a lot of backtracking:
>
> set rx {\S*[^\]\s]\s+\[\d+\]}
>
> I don't really follow the Tcl code around this, but if this is trying to
> match on lines such as:
>
> 2253> input:42871 -- gemse.th [4]
>
> Then adding "-- " to the start of the pattern and then adjusting the
> offsets when highlighting in the text widget should address the problem.
> The fixed substring "-- " serves as a way to efficiently limit where the
> regexp engine tries to match the pattern.
I managed to guess enough tcl and tk to implement this, patch attached
which fixes the 10 minute wait while xtherion parse the log, while still
creating the links as before (at least as best I can tell).
Cheers,
Olly
-- next part --
A non-text attachment was scrubbed...
Name: fix-log-file-regexp-backtracking.patch
Type: text/x-diff
Size: 1099 bytes
Desc: not available
URL:
<http://mailman.speleo.sk/pipermail/therion/attachments/20150113/953273d3/attachment.patch>
