Re: [Thunar-dev] How to use the eject function
Yves-Alexis Perez wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. Are there patches against 4.4.2? http://thunar.xfce.org/download/sources/Thunar/0.9.0/Thunar-0.9.0-use-eject-where-necessary.patch Benedikt ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] How to use the eject function
On Wed, 2007-12-12 at 01:18 +0100, Tino Keitel wrote: Btw., the 4.4.2 version is missing in Bugzilla. It's there now. -- Jean-François Wauthy [EMAIL PROTECTED] signature.asc Description: This is a digitally signed message part ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] How to use the eject function
On Wed, Dec 12, 2007 at 01:18:46 +0100, Tino Keitel wrote: On Tue, Dec 11, 2007 at 15:44:36 -0800, Brian J. Tarricone wrote: Tino Keitel wrote: On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote: Tino Keitel wrote: I can confirm that I have no Eject button in the shortcuts pane without the patch, and and Eject button with the patch. Committed. Bug Brian to fix xfdesktop as well. I patched xfdesktop in a minimal way (see the attachment), which lead to the following inconsistency: In thunar, either Eject or Unmount is shown in the menu, depending on thunar_vfs_volume_is_ejectable(). In xfdesktop, both Eject and Unmount are shown when thunar_vfs_volume_is_ejectable() returns true. What behaviour should be preferred? Eject. Feel free to cook up a patch, open a bug on bugzilla, and attach it. Done. Hi Brian, what do you think about the patch? It does not hurry for Xfce itself, but the Debian maintainers wait for a comment to decide if this fix can be included in the 4.4.2 build for Debian. Regards, Tino ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] How to use the eject function
On Wed, Dec 12, 2007 at 10:16:11 -0800, Brian J. Tarricone wrote: [...] P.S. Also, what happens for the Floppy Drive icon? Sounds pretty confusing to have an Eject menu item that -- physically -- appears to do nothing (unless you're on an old Mac). When your floppy device HAL entry contains requires_eject, then Thunar will create an Eject menu entry. So when the hardware doesn't support eject, but HAL reports it, then HAL is wrong, not Xfce. :-) Regards, Tino ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] How to use the eject function
Tino Keitel wrote: Hi Brian, what do you think about the patch? It does not hurry for Xfce itself, but the Debian maintainers wait for a comment to decide if this fix can be included in the 4.4.2 build for Debian. Functionally it looks ok (haven't tested it; just glanced at the patch). I do have issues with using the term Eject here. It makes sense for optical or tape drives, but not really for (e.g.) USB flash drives. I've seen discussion about this elsewhere, but I don't remember where, or what the conclusions were, and I don't have a better word or phrase to use in its place. It appears that both WinXP (right click on a USB drive in Explorer) and MacOS X (right click [or control-click] on USB drive in the shortcuts pane in Finder) use the Eject terminology, so at least it's not without precedent... -brian P.S. Also, what happens for the Floppy Drive icon? Sounds pretty confusing to have an Eject menu item that -- physically -- appears to do nothing (unless you're on an old Mac). ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
Re: [Thunar-dev] How to use the eject function
On mer, 2007-12-12 at 10:16 -0800, Brian J. Tarricone wrote: I do have issues with using the term Eject here. It makes sense for optical or tape drives, but not really for (e.g.) USB flash drives. Somebody just told me that vfat fs are not totally sync()ed at umount, that you needed to send and eject so everything is clean properly. I don't have any source but it may be a good idea to provide this :) Cheers, -- Yves-Alexis ___ Thunar-dev mailing list Thunar-dev@xfce.org http://foo-projects.org/mailman/listinfo/thunar-dev
